Skip to content

Fix PDF receipts not loading when receipt.source is missing#81950

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixPdfReceiptLoadingWhenSourceMissing
Closed

Fix PDF receipts not loading when receipt.source is missing#81950
MelvinBot wants to merge 1 commit into
mainfrom
claude-fixPdfReceiptLoadingWhenSourceMissing

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

When receipts are added via email forwarding or Expensify billing, the backend sometimes provides receipt.filename without populating receipt.source. The getThumbnailAndImageURIs function in ReceiptUtils.ts returns an empty string for the image path when source is missing, causing the PDF viewer to receive a blank URL and display nothing.

This fix adds a fallback in getThumbnailAndImageURIs: when receipt.source is missing but receipt.filename exists, construct the URL as https://www.expensify.com/receipts/{filename}. This is the same workaround already used in MergeTransactionUtils.ts:fillMissingReceiptSource, but applied at the general receipt utility level so all receipt display paths (not just merge) benefit from it.

Fixed Issues

$ #78846

Tests

  1. Find an expense that has a PDF receipt added via email or billing (where receipt.source is missing but receipt.filename exists)
  2. Open the expense to view the attached receipt
  3. Verify the PDF receipt loads and previews correctly in the UI
  4. Open an expense with a receipt captured via the app (where receipt.source is present)
  5. Verify the receipt still loads correctly (no regression)
  • Verify that no errors appear in the JS console

Offline tests

  1. Open an expense with a PDF receipt while online, verify it loads
  2. Go offline and open the same expense again
  3. Verify the behavior is consistent with how other receipts behave offline (cached version shows or appropriate offline state)

QA Steps

  1. Access an account that has expenses with PDF receipts added via email or billing (e.g. Expensify billing receipts) — these are the ones where receipt.source is missing
  2. Open the expense to view the receipt
  3. Verify the PDF receipt loads and displays correctly
  4. Also verify that expenses with receipts captured via the app still display correctly
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…ssing

When receipts are added via email or billing, the backend sometimes
provides receipt.filename without receipt.source. This causes the
receipt viewer to receive a blank URL, leaving PDF previews empty.

Apply the same fallback used in MergeTransactionUtils directly in
getThumbnailAndImageURIs so all receipt display paths benefit:
construct the URL as https://www.expensify.com/receipts/{filename}
when source is missing but filename exists.

Co-authored-by: Jan Nowakowski <jnowakow@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixPdfReceiptLoadingWhenSourceMissing
git checkout -b claude-fixPdfReceiptLoadingWhenSourceMissing upstream/claude-fixPdfReceiptLoadingWhenSourceMissing
git push -u origin claude-fixPdfReceiptLoadingWhenSourceMissing

Then you can close this PR and open a new one from your fork.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

The only failing check is checklist — it reports 29 out of 51 checklist items are unchecked in the PR description.

This is not a code issue. The checklist CI job validates that the PR Author Checklist in the PR body is fully filled out. Many of the unchecked items are platform testing confirmations, screenshot requirements, and other verification steps that only the PR author can complete.

To fix this: Edit the PR description and check off (or remove) the remaining unchecked checklist items. For items that don't apply to this PR (e.g. new CSS styles, new assets, deeplinks, Storybook stories, UI changes), you can check them off as N/A since they aren't relevant to this single-file change in ReceiptUtils.ts.

All other checks (ESLint, Prettier, builds, verifySignedCommits, etc.) are passing.

@jnowakow

Copy link
Copy Markdown
Contributor

I'm closing in favour of #81960

@jnowakow jnowakow closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants