Fix/80171 - Contact list does not auto load unless scrolled up by dmkt9 · Pull Request #81284 · Expensify/App

dmkt9 · 2026-02-03T10:08:44Z

Explanation of Change

Fix the issue where contacts fail to load additional items when scrolling quickly to the bottom

Fixed Issues

$ #80171
PROPOSAL: #80171 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition: Log in to Expensifail account or account with many contacts.

Launch Expensify app.
Open FAB > Create expense > Manual.
Enter amount > Next.
On confirm page, tap To field.
Scroll quickly to the bottom (on the desktop web platform, we should use the scrollbar).
Verify that the contact list will always auto load when scrolled to the bottom.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

mac.web.mp4

melvin-bot · 2026-02-03T10:08:51Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 182b4be1a5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-02-03T10:19:47Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...s/iou/request/MoneyRequestParticipantsSelector.tsx	`0.00% <ø> (ø)`
...ListWithSections/BaseSelectionListWithSections.tsx	`73.52% <62.50%> (-0.21%)`	⬇️
... and 13 files with indirect coverage changes

aimane-chnaif · 2026-02-03T10:20:53Z

We should fix sentry label error

dmkt9 · 2026-02-03T10:59:18Z

This PR is ready

aimane-chnaif · 2026-02-03T11:05:57Z

    shouldDisableHoverStyle = false,
    setShouldDisableHoverStyle = () => {},
    shouldSkipContentHeaderHeightOffset,
+    sentryLabelSelectAllButton,


I think we can just pass sentryLabel="MoneyRequestParticipantsSelector"
For select all button, maybe add suffix?

Example name: MoneyRequestParticipantsSelector-SelectAll

@dariusz-biela what do you think?

JmillsExpensify

Product polish approved

arosiclair · 2026-02-24T16:17:10Z

@aimane-chnaif @dmkt9 this PR hasn't moved in a couple weeks. What do we need to do here?

aimane-chnaif · 2026-02-24T16:36:39Z

Been waiting for confirmation here.
I don't think we should block on this.

@dmkt9 please merge main and remove sentry related codes to see if sentry label issue no longer happens on main

dmkt9 · 2026-02-24T16:51:18Z

Been waiting for confirmation here. I don't think we should block on this.

@dmkt9 please merge main and remove sentry related codes to see if sentry label issue no longer happens on main

@aimane-chnaif I see that the sentryLabel issue has been resolved, so we can move on to the next step.

aimane-chnaif · 2026-02-24T16:52:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

chatgpt-codex-connector · 2026-02-24T16:59:34Z

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aimane-chnaif · 2026-02-24T17:01:44Z

@dmkt9 please fix lint

dmkt9 · 2026-02-24T17:04:22Z

This lint error seems to come from the latest main branch rather than our code. I will merge main again, hopefully it has already been fixed.

dmkt9 · 2026-02-24T17:17:26Z

We have a tracked issue here: #83347. I will merge the main branch again once that lint issue has been resolved

aimane-chnaif · 2026-02-24T17:56:57Z

We have a tracked issue here: #83347. I will merge the main branch again once that lint issue has been resolved

It's fixed now on main

Co-authored-by: Andrew Rosiclair <arosiclair@gmail.com>

github-actions · 2026-02-25T16:18:01Z

🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-25T16:24:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81284.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-37bb590-0dbc7e1-f23c824995d4cfe3c6aef0d059fc9d14e7c8b1dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-37bb590-0dbc7e1-177e7e714a38e4f50f6e08f8b14ddc54c1a7835c/index.html

Web 🕸️
https://81284.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T18:23:30Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:55:03Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix - Contact list does not auto load unless scrolled up

182b4be

dmkt9 requested review from a team as code owners February 3, 2026 10:08

melvin-bot Bot assigned dmkt9 Feb 3, 2026

melvin-bot Bot requested review from JmillsExpensify and aimane-chnaif February 3, 2026 10:08

melvin-bot Bot removed request for a team February 3, 2026 10:08

chatgpt-codex-connector Bot reviewed Feb 3, 2026

View reviewed changes

Comment thread src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx

dmkt9 added 2 commits February 3, 2026 17:21

Fix - Contact list does not auto load unless scrolled up

5568d3a

add sentryLabel

0dad08b

aimane-chnaif reviewed Feb 3, 2026

View reviewed changes

Comment thread src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx Outdated

add sentryLabel

c2fb949

dmkt9 mentioned this pull request Feb 3, 2026

[Due for payment 2026-03-06][$250] iOS - Expense - Contact list does not auto load unless scrolled up #80171

Closed

7 tasks

aimane-chnaif reviewed Feb 3, 2026

View reviewed changes

JmillsExpensify previously approved these changes Feb 13, 2026

View reviewed changes

dmkt9 added 2 commits February 24, 2026 23:47

Merge branch 'main' into fix/80171

8acb727

remove sentryLabelSelectAllButton

864b8b4

dmkt9 dismissed JmillsExpensify’s stale review via 864b8b4 February 24, 2026 16:49

Merge branch 'main' into fix/80171

84400e8

dmkt9 added 2 commits February 25, 2026 01:03

Merge branch 'main' into fix/80171

63a1706

Merge branch 'Expensify:main' into fix/80171

2a855d6

aimane-chnaif approved these changes Feb 24, 2026

View reviewed changes

melvin-bot Bot requested a review from arosiclair February 24, 2026 21:01

arosiclair requested changes Feb 25, 2026

View reviewed changes

Comment thread src/components/SelectionListWithSections/BaseSelectionListWithSections.tsx

dmkt9 and others added 2 commits February 25, 2026 21:51

Fix - Contact list does not auto load unless scrolled up

ab90bd3

Co-authored-by: Andrew Rosiclair <arosiclair@gmail.com>

Merge branch 'Expensify:main' into fix/80171

28130b4

arosiclair approved these changes Feb 25, 2026

View reviewed changes

arosiclair merged commit 37bb590 into Expensify:main Feb 25, 2026
30 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

jponikarchuk mentioned this pull request Feb 26, 2026

[$250] Expense - “To” field is not tappable on confirm page with Expensifail account #83534

Closed

7 tasks

Uh oh!

Conversation

dmkt9 commented Feb 3, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Feb 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aimane-chnaif commented Feb 3, 2026

Uh oh!

Uh oh!

dmkt9 commented Feb 3, 2026

Uh oh!

aimane-chnaif Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

arosiclair commented Feb 24, 2026

Uh oh!

aimane-chnaif commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmkt9 commented Feb 24, 2026

Uh oh!

aimane-chnaif commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot commented Feb 24, 2026

Uh oh!

aimane-chnaif commented Feb 24, 2026

Uh oh!

dmkt9 commented Feb 24, 2026

Uh oh!

dmkt9 commented Feb 24, 2026

Uh oh!

aimane-chnaif commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Feb 3, 2026 •

edited by github-actions Bot

Loading

aimane-chnaif commented Feb 24, 2026 •

edited

Loading

aimane-chnaif commented Feb 24, 2026 •

edited

Loading