feat: Add exported-to filter in search filters#81077
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
samranahm
changed the title
exported-to filter in search
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds support for the exported-to: filter in the search functionality, allowing users to filter expenses and reports by the accounting integration they were exported to (Xero, QuickBooks Online, QuickBooks Desktop, NetSuite, Sage Intacct, or Certinia), as well as by custom export template names.
Changes:
- Added
exported-tofilter support in search query parser with both camelCase (exportedTo) and kebab-case (exported-to) syntax - Implemented SearchFiltersExportedToPage component to allow users to select export destinations from a UI
- Added Certinia as a new supported accounting integration throughout the codebase
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CONST/index.ts | Added EXPORTED_TO constants, CERTINIA integration name, and predefined integration filter values |
| src/SCREENS.ts | Added ADVANCED_FILTERS_EXPORTED_TO_RHP screen definition |
| src/types/onyx/Policy.ts | Added Certinia connection type definition |
| src/types/form/SearchAdvancedFiltersForm.ts | Added exportedTo and exportedToNot filter keys and allowed them in expense/chat/invoice type filters |
| src/libs/SearchParser/baseRules.peggy | Added exportedTo grammar rule supporting both camelCase and kebab-case syntax |
| src/libs/SearchParser/searchParser.js | Generated parser code for exportedTo filter |
| src/libs/SearchParser/autocompleteParser.js | Generated autocomplete parser code for exportedTo filter |
| src/libs/SearchParser/searchParser.peggy | Added exportedTo to key alternatives in search grammar |
| src/libs/SearchParser/autocompleteParser.peggy | Added exportedTo to autocomplete key alternatives |
| src/libs/SearchQueryUtils.ts | Added logic to build and parse exportedTo filter values |
| src/libs/SearchAutocompleteUtils.ts | Added validation for exportedTo filter values |
| src/libs/AccountingUtils.ts | Added functions to map connection names to search values and get predefined connection names |
| src/libs/ReportUtils.ts | Updated getIntegrationIcon to support CertiniaSquare icon |
| src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersExportedToPage.tsx | New page component for selecting export destinations with integration icons |
| src/pages/Search/AdvancedSearchFilters.tsx | Added exportedTo filter configuration and display logic |
| src/components/Search/SearchMultipleSelectionPicker.tsx | Added leftElement support for custom icons in picker items |
| src/components/Search/SearchAutocompleteList.tsx | Added autocomplete support for exportedTo filter with integration and template values |
| src/components/ReportActionItem/ExportWithDropdownMenu.tsx | Added CertiniaSquare to lazy-loaded icons |
| src/components/MoneyReportHeader.tsx | Added CertiniaSquare to lazy-loaded icons |
| src/components/ImportedFromAccountingSoftware.tsx | Added CertiniaSquare to lazy-loaded icons |
| src/pages/inbox/report/ReportDetailsExportPage.tsx | Added CertiniaSquare to lazy-loaded icons |
| src/libs/Navigation/linkingConfig/config.ts | Added route configuration for EXPORTED_TO filter page |
| src/libs/Navigation/linkingConfig/RELATIONS/SEARCH_TO_RHP.ts | Added EXPORTED_TO screen to search-to-RHP relations |
| src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx | Added SearchFiltersExportedToPage to modal stack navigator |
| src/hooks/useAdvancedSearchFilters.ts | Added EXPORTED_TO to allowed filters for expense, chat, and invoice types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ed3fee689
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Taking a look, will fix them ASAP. |
|
All tests failed |
|
We changed |
|
@aimane-chnaif We're good to go. |
|
@samranahm stale filter issue is not fixed yet Screen.Recording.2026-02-25.at.8.01.49.pm.mov |
|
@aimane-chnaif This is expected and match the behavior with categories/tags |
Kapture.2026-02-26.at.01.07.36.mp4 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24cc0c2c4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Resolving merge conflicts. |
|
Please let me know if you have any other concern. |
aimane-chnaif
left a comment
aimane-chnaif
left a comment
There was a problem hiding this comment.
Approving. Just fix conflict
|
@JS00001 All yours. |
|
🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.27-0 🚀
|
|
Deploy Blocker #83710 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.27-8 🚀
|
Explanation of Change
Fixed Issues
$ #80005
PROPOSAL: #80005 (comment)
Tests
Precondition:
Test 01
exported-to:integrationis not added to search query input since query input was empty initiallyTest 02
type:expense exported-to:"QuickBooks Online"QuickBooks Onlinebackground color change of filter value > press enterfilters (1)to indicate filter has been appliedexported-to:Test 03 - Negation
type:expense exported-to:"Sage Intacct"-exported-to:"QuickBooks Online"does not applyexported-tofilter and does not effect "Exported to" page itemstype:expense -exported-to:"QuickBooks Desktop" exported-to:"QuickBooks Online"and verify search result show expenses those areTest 04 - Multiple workspaces
Offline tests
QA Steps
Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.Native.mp4
Android: mWeb Chrome
Android.mWeb.Chrome.mp4
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
IOS.mWeb.Safari.mp4
MacOS: Chrome / Safari
macOS.Chrome.mp4