[Home Page] Create DiscoverSection Component #80807
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import type {ReactNode} from 'react'; | ||
| import React from 'react'; | ||
| import {View} from 'react-native'; | ||
| import useResponsiveLayout from '@hooks/useResponsiveLayout'; | ||
| import useTheme from '@hooks/useTheme'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import variables from '@styles/variables'; | ||
| import type IconAsset from '@src/types/utils/IconAsset'; | ||
| import Icon from './Icon'; | ||
| import Text from './Text'; | ||
|
|
||
| type WidgetContainerProps = { | ||
| /** The icon to display along with the title */ | ||
| icon?: IconAsset; | ||
|
|
||
| /** The text to display in the title of the widget */ | ||
| title?: string; | ||
|
|
||
| /** Custom color for the title text */ | ||
| titleColor?: string; | ||
|
|
||
| /** The width of the icon. */ | ||
| iconWidth?: number; | ||
|
|
||
| /** The height of the icon. */ | ||
| iconHeight?: number; | ||
|
|
||
| /** The content to display inside the widget container */ | ||
| children: ReactNode; | ||
| }; | ||
|
|
||
| function WidgetContainer({children, icon, title, titleColor, iconWidth = variables.iconSizeNormal, iconHeight = variables.iconSizeNormal}: WidgetContainerProps) { | ||
| const styles = useThemeStyles(); | ||
| const theme = useTheme(); | ||
| const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
|
|
||
| return ( | ||
| <View style={styles.widgetContainer}> | ||
| <View style={[styles.flexRow, styles.alignItemsStart, styles.mb5, shouldUseNarrowLayout ? styles.mh5 : styles.mh8, shouldUseNarrowLayout ? styles.mt5 : styles.mt8]}> | ||
| {!!icon && ( | ||
| <View style={[styles.flexGrow0, styles.flexShrink0]}> | ||
| <Icon | ||
| src={icon} | ||
| width={iconWidth} | ||
| height={iconHeight} | ||
| /> | ||
| </View> | ||
| )} | ||
| <View style={[styles.flexShrink1, styles.flexGrow1, styles.flexRow, styles.alignItemsCenter, styles.gap2]}> | ||
| {!!title && <Text style={styles.getWidgetContainerTitleStyle(titleColor ?? theme.text)}>{title}</Text>} | ||
| </View> | ||
| </View> | ||
| {children} | ||
| </View> | ||
| ); | ||
| } | ||
|
|
||
| export type {WidgetContainerProps}; | ||
| export default WidgetContainer; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import React from 'react'; | ||
| import {Image, Linking, View} from 'react-native'; | ||
| import HomeTestDriveImage from '@assets/images/home-testdrive-image.png'; | ||
| import MenuItemWithTopDescription from '@components/MenuItemWithTopDescription'; | ||
| import {PressableWithoutFeedback} from '@components/Pressable'; | ||
| import WidgetContainer from '@components/WidgetContainer'; | ||
| import useIsPaidPolicyAdmin from '@hooks/useIsPaidPolicyAdmin'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useOnyx from '@hooks/useOnyx'; | ||
| import useResponsiveLayout from '@hooks/useResponsiveLayout'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import {getTestDriveURL} from '@libs/TourUtils'; | ||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
|
|
||
| const MAX_NUMBER_OF_LINES_TITLE = 4; | ||
|
|
||
| function DiscoverSection() { | ||
| const {translate} = useLocalize(); | ||
| const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
| const isCurrentUserPolicyAdmin = useIsPaidPolicyAdmin(); | ||
| const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED, {canBeMissing: true}); | ||
| const styles = useThemeStyles(); | ||
|
|
||
| const handlePress = () => { | ||
|
Contributor
There was a problem hiding this comment. ❌ CONSISTENCY-5 (docs)The Suggested fix: const handlePress = () => {
const url = getTestDriveURL(shouldUseNarrowLayout, introSelected, isCurrentUserPolicyAdmin);
Linking.openURL(url).catch((error) => {
Log.error('Failed to open test drive URL', error);
// Optionally show user feedback
});
};Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
There was a problem hiding this comment. Technically correct but inconsistent with existing patterns. The codebase doesn't do this anywhere else. |
||
| Linking.openURL(getTestDriveURL(shouldUseNarrowLayout, introSelected, isCurrentUserPolicyAdmin)); | ||
| }; | ||
|
|
||
| return ( | ||
| <WidgetContainer title={translate('homePage.discoverSection.title')}> | ||
| <PressableWithoutFeedback | ||
| onPress={handlePress} | ||
| accessibilityRole={CONST.ROLE.BUTTON} | ||
| accessibilityLabel={translate('homePage.discoverSection.title')} | ||
| style={[shouldUseNarrowLayout ? styles.mh5 : styles.mh8, styles.mb5]} | ||
| > | ||
| <View style={[styles.br2, styles.overflowHidden]}> | ||
| <Image | ||
| source={HomeTestDriveImage} | ||
| style={styles.discoverSectionImage} | ||
| /> | ||
| </View> | ||
| </PressableWithoutFeedback> | ||
| <MenuItemWithTopDescription | ||
| shouldShowRightIcon | ||
| title={isCurrentUserPolicyAdmin ? translate('homePage.discoverSection.menuItemTitleAdmin') : translate('homePage.discoverSection.menuItemTitleNonAdmin')} | ||
| description={translate('homePage.discoverSection.menuItemDescription')} | ||
| onPress={handlePress} | ||
| style={shouldUseNarrowLayout ? styles.mb2 : styles.mb5} | ||
| wrapperStyle={shouldUseNarrowLayout ? styles.pl5 : styles.pl8} | ||
| numberOfLinesTitle={MAX_NUMBER_OF_LINES_TITLE} | ||
| /> | ||
| </WidgetContainer> | ||
| ); | ||
| } | ||
|
|
||
| export default DiscoverSection; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.