[No QA] [HelpDot] Add details on how to freeze or unfreeze an Expensify Card for cardholders#80723
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://53980d4d.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new section on freezing/unfreezing an Expensify Card to the existing Cardholder Settings and Features article. The content is clear and useful, but several governance violations need to be addressed before merge. Scores Summary
Key FindingsMust fix:
Should fix:
Positive aspects:
Recommendations
Files Reviewed
Review based on docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md governance standards. |
|
@MelvinBot given the review suggestions in #80723 (comment), update this PR to comply with our guidelines |
- Make section heading task-based ("How to freeze or unfreeze")
- Change ### to ## (only # and ## headings permitted)
- Remove colon from subheading
- Use consistent "Click" verb instead of mixing Click/Tap
- Replace vague "popup modal" with "dialog that appears" and specific button name
- Specify "Expensify Chat" instead of generic "via chat"
- Add freeze/unfreeze keywords to YAML frontmatter
Co-authored-by: Maria D'Costa <MariaHCD@users.noreply.github.com>
|
Updated the PR to address the review suggestions:
|
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.59-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀
|
Explanation of Change
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/593794
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari