Skip to content

Show error message when bank account deletion fails #79787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 5 commits into from
Jan 19, 2026
Merged

Show error message when bank account deletion fails #79787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4585cb
Show error message when bank account deletion fails
ShridharGoel Jan 16, 2026
59ca444
Clear pendingAction
ShridharGoel Jan 17, 2026
9425a05
Update style
ShridharGoel Jan 17, 2026
e2cb083
Add paymentMethodErrorRow style
ShridharGoel Jan 17, 2026
db7fd9b
Update to remove comment
ShridharGoel Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/BankAccounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ function deletePaymentBankAccount(bankAccountID: number, personalPolicyID: strin
const bankAccountFailureData = {
...bankAccount,
errors: getMicroSecondOnyxErrorWithTranslationKey('bankAccount.error.deletePaymentBankAccount'),
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
pendingAction: null,
};

const onyxData: OnyxData<typeof ONYXKEYS.BANK_ACCOUNT_LIST | typeof ONYXKEYS.NVP_LAST_PAYMENT_METHOD> = {
Expand Down
1 change: 1 addition & 0 deletions src/pages/settings/Wallet/PaymentMethodList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ function PaymentMethodList({
isMethodActive,
iconRight: itemIconRight ?? expensifyIcons.ThreeDots,
shouldShowRightIcon,
canDismissError: true,
};
});
return combinedPaymentMethods;
Expand Down
7 changes: 4 additions & 3 deletions src/pages/settings/Wallet/PaymentMethodListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import ONYXKEYS from '@src/ONYXKEYS';
import type {BankIcon} from '@src/types/onyx/Bank';
import type {Errors} from '@src/types/onyx/OnyxCommon';
import type PaymentMethod from '@src/types/onyx/PaymentMethod';
import {isEmptyObject} from '@src/types/utils/EmptyObject';
import type IconAsset from '@src/types/utils/IconAsset';

type PaymentMethodItem = PaymentMethod & {
Expand Down Expand Up @@ -61,6 +62,7 @@ function dismissError(item: PaymentMethodItem) {
return;
}

const hasErrors = !isEmptyObject(item.errors);
const isBankAccount = item.accountType === CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT;
const paymentList = isBankAccount ? ONYXKEYS.BANK_ACCOUNT_LIST : ONYXKEYS.FUND_LIST;
const paymentID = isBankAccount ? item.accountData?.bankAccountID : item.accountData?.fundID;
Expand All @@ -70,7 +72,7 @@ function dismissError(item: PaymentMethodItem) {
return;
}

if (item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
if (item.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || hasErrors) {
clearDeletePaymentMethodError(paymentList, paymentID);
if (!isBankAccount) {
clearDeletePaymentMethodError(ONYXKEYS.FUND_LIST, paymentID);
Expand Down Expand Up @@ -116,8 +118,7 @@ function PaymentMethodListItem({item, shouldShowDefaultBadge, threeDotsMenuItems
onClose={item.canDismissError ? () => dismissError(item) : undefined}
pendingAction={item.pendingAction}
errors={item.errors}
errorRowStyles={styles.ph6}
shouldShowErrorMessages={false}
errorRowStyles={styles.paymentMethodErrorRow}
>
<MenuItem
onPress={handleRowPress}
Expand Down
3 changes: 3 additions & 0 deletions src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5629,6 +5629,9 @@ const staticStyles = (theme: ThemeColors) =>
width: 179,
height: 180,
},
paymentMethodErrorRow: {
paddingHorizontal: variables.iconSizeMenuItem + variables.iconSizeNormal / 2,
},
}) satisfies StaticStyles;

const dynamicStyles = (theme: ThemeColors) =>
Expand Down
Loading