fix: quickly tapping a workspace row and the 3‑dot button#79319
Merged
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
January 13, 2026 08:55
trjExpensify
approved these changes
Jan 13, 2026
trjExpensify
left a comment
Contributor
There was a problem hiding this comment.
Pretty minor and unrealistic to happen in real world use, but no qualms from the product side 👍
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp79319-android-hybrid-001.mp4Android: mWeb Chrome79319-mweb-chrome-001.mp4iOS: HybridApp79319-ios-hybrid-001.mp4iOS: mWeb Safari79319-mweb-safari-001.mp4MacOS: Chrome / Safari79319-web-chrome-001.mp4 |
JS00001
approved these changes
Jan 20, 2026
85 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.5-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #78944
PROPOSAL: #78944 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
am.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
result.mov
iOS: mWeb Safari
im.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-13.at.15.55.17.mov