Thesahindia/UI/confirmView#7850
Merged
Beamanator merged 11 commits intoMar 7, 2022
Merged
Conversation
MelvinBot
requested review from
Beamanator and
parasharrajat
and removed request for
a team
Member
|
Testing shortly... |
parasharrajat
suggested changes
Feb 21, 2022
parasharrajat
suggested changes
Feb 21, 2022
Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
parasharrajat
previously approved these changes
Feb 24, 2022
Member
|
cc: @Beamanator |
Contributor
|
Thanks @parasharrajat I'll check this out today, I was on vacation last week :D |
Beamanator
requested changes
Mar 7, 2022
Beamanator
left a comment
Beamanator
left a comment
Contributor
There was a problem hiding this comment.
Overall looks great, just a few style changes and comment change suggestion
…/confirmView merge main
…pp into thesahindia/ui/confirmView merge main
Beamanator
approved these changes
Mar 7, 2022
Contributor
|
Thanks for the quick edits @thesahindia ! 👍 |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by @Beamanator in version: 1.1.42-0 🚀
|
|
We are still able to repro #7768 in IOS, so limited QA possible. Rest platforms ok |
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.1.42-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #7545
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android