Skip to content

[No QA] Update Track-Taxes.md#77956

Merged
CortneyOfstad merged 2 commits into
mainfrom
stephanieelliott-patch-25
Dec 18, 2025
Merged

[No QA] Update Track-Taxes.md#77956
CortneyOfstad merged 2 commits into
mainfrom
stephanieelliott-patch-25

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

@stephanieelliott stephanieelliott self-assigned this Dec 18, 2025
@stephanieelliott stephanieelliott requested a review from a team as a code owner December 18, 2025 04:38
@melvin-bot

This comment was marked as duplicate.

@melvin-bot melvin-bot Bot requested review from CortneyOfstad and removed request for a team December 18, 2025 04:39
@melvin-bot

melvin-bot Bot commented Dec 18, 2025

Copy link
Copy Markdown

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread docs/articles/new-expensify/workspaces/Track-Taxes.md
Comment thread docs/articles/new-expensify/workspaces/Track-Taxes.md
Comment thread docs/articles/new-expensify/workspaces/Track-Taxes.md
Comment thread docs/articles/new-expensify/workspaces/Track-Taxes.md
Comment thread docs/articles/new-expensify/workspaces/Track-Taxes.md
In Expensify, tax is *inclusive*, meaning it's already part of the total amount shown. If the tax amount doesn't show up on your receipt or is different from the calculated amount, you can manually type in the correct amount.

To determine the inclusive tax from a total price that already includes tax, you can use the following formula:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: The phrase "tax is inclusive" uses italics for emphasis when bold would be more appropriate for UI/technical terms in Expensify documentation. Consider: "tax is inclusive"


For example, if an item costs $100 and the tax rate is 20%:
Tax amount = (**$100** x .20) ÷ (1 + .**20**) = **$16.67**
This means the tax amount of $16.67 is included in the total.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: The formula formatting is inconsistent and hard to scan. Consider using a code block or consistent markdown formatting. Also, "÷" should be "/" for consistency with common notation.

Comment thread docs/articles/new-expensify/workspaces/Track-Taxes.md
Comment thread docs/articles/new-expensify/workspaces/Track-Taxes.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a comprehensive FAQ section to the Track-Taxes.md documentation and makes minor improvements to existing content. The additions address common user questions about handling multiple tax rates, receipts with multiple taxes, and tax calculation methods.

Scores Summary

  • Readability: 7/10 - Generally clear but needs grammar and consistency fixes
  • AI Readiness: 8/10 - Good descriptive headings and clear context
  • Style Compliance: 6/10 - Mixed adherence, needs UI formatting consistency

Key Findings

Positive Aspects:

  • Excellent FAQ section addressing real user pain points
  • Keywords updated to include QST and PST
  • Improved accounting integration explanation
  • Good practical examples with tax calculation formulas

Critical Issues:

  1. Line 18: Removed bold formatting from Workspaces - UI elements should be consistently bolded
  2. Line 91: Grammar error - or is it showing should be or it is showing
  3. Line 97: Formatting error - .20 should be .20
  4. Inconsistent FAQ question punctuation

Recommendations

Priority Actions:

  1. Fix grammar on line 91
  2. Restore bold for Workspaces on line 18
  3. Fix number formatting on line 97
  4. Standardize FAQ question format
  5. Update YAML description to mention FAQs

Files Reviewed

  • docs/articles/new-expensify/workspaces/Track-Taxes.md (40 additions, 5 deletions) - Needs revisions before merge

Summary: Valuable enhancement but requires grammar, formatting, and style corrections before approval.

@github-actions github-actions Bot changed the title Update Track-Taxes.md [No QA] Update Track-Taxes.md Dec 18, 2025
@OSBotify

OSBotify commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://ff01f9f2.helpdot.pages.dev ⚡️

Updated articles:

@heyjennahay heyjennahay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating!

@CortneyOfstad

Copy link
Copy Markdown
Contributor

Suggested edits are not applicable after reviewing the page — wrapping up the checklist now!

@CortneyOfstad

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@CortneyOfstad CortneyOfstad merged commit 95f96a3 into main Dec 18, 2025
12 of 13 checks passed
@CortneyOfstad CortneyOfstad deleted the stephanieelliott-patch-25 branch December 18, 2025 16:59
@melvin-bot melvin-bot Bot added the Emergency label Dec 18, 2025
@melvin-bot

melvin-bot Bot commented Dec 18, 2025

Copy link
Copy Markdown

@CortneyOfstad looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@CortneyOfstad

Copy link
Copy Markdown
Contributor

No QA needed — reviewed the edits and the page, so all set!

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.2.82-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.2.84-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants