seprate subtitle from title

[Nodebrute]

Explanation of Change

Fixed Issues

$ #76669
PROPOSAL: #76669 (comment)

Tests

1. Go to workspace chat
2. Create an expense
3. Click on newly created expense
4. Click on header
5. Verify the following design (title and form field)

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. Go to workspace chat
2. Create an expense
3. Click on newly created expense
4. Click on header
5. Verify the following design (title and form field)

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

editable version

Android: mWeb Chrome

iOS: Native

non-editable version

editable version

iOS: mWeb Safari

non-editable version

editable version

MacOS: Chrome / Safari

editable version

**non-editable version**

[melvin-bot]

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Nodebrute]

Will add the android and mweb screenshots shortly.

[Nodebrute]

@Pujan92 I was running into an issue with long subtitles wrapping into two lines.

After removing subtitleNumberOfLines={2}, the layout now looks like this. Can you confirm the expected behavior?

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ParentNavigationSubtitle.tsx	80.55% <100.00%> (+3.88%)	⬆️
src/pages/ReportDetailsPage.tsx	57.30% <85.71%> (+0.20%)	⬆️
... and 10 files with indirect coverage changes

[joekaufmanexpensify]

Change makes sense 👍

[Pujan92]

I think keeping it in a single line was the earlier behavior. In this PR, it is updated to 2 lines.

Let's confirm the doubt with @Expensify/design team.

[Pujan92]

@dannymcclain can you plz help with comment

[dubielzyk-expensify]

I think we'd probably don't want it going to two lines so truncation is fine, no strong feelings though. We have to truncate at some point so we can also do it after two lines

The text in this PR doesn't match the mock though. The font size should be the same as the Report ID and the like. It's smaller at the moment:

[dubielzyk-expensify]

On second thought maybe given the long emails and potentially long Workspace names it makes more sense two truncate after two lines

[Nodebrute]

Sorry, this got delayed due to the holidays. I’ll update today.

[Nodebrute]

@Pujan92 I have updated the code according to the design.

[Pujan92]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

[Nodebrute]

@Pujan92 conflicts resolved.

[Pujan92]

But I'd expect to see the same for a room maybe!?:

I don't think I feel as strongly about this one because there's nothing for you to click on or interact with—though I'm not against separating it out as well. I'd probably do it like this though if we're going to change that:

Room name
#purrfect >
Workspace
Expensify Chat

Just to highlight, currently we are rendering a common component for non-expense reports(eg. workspace room, invoices) and also alignment is specific to scenarios. To confirm, Do we need to make this format update for workspace room name?

---

And then I get this weird left + centered thing on my expense room:

I didn't come across this, but let's make sure we address it!

@dannymcclain Can you help to create this expense room, I thought we only have workspace room and there I didn't able to see this issue?

[dannymcclain]

@Expensify/design what do you think? Should we just make this change everywhere? Feels like that would ultimately probably be the right choice, but want to double-check.

@dannymcclain Can you help to create this expense room, I thought we only have workspace room and there I didn't able to see this issue?

I can't repro the issue Jon was having.

[dubielzyk-expensify]

@Expensify/design what do you think? Should we just make this change everywhere? Feels like that would ultimately probably be the right choice, but want to double-check.

What change are you referring to, Danny?

[shawnborton]

I think I am following. We should map out how other items would work though... like what do we show for "From" for all possible "chat" types? I guess in most cases we just show the workspace?

[dannymcclain]

Cleared it up with Jon in person, but yes Shawn for most of the other ones instead of the label for the row being From, it would just be Workspace. So for example, this one would be:

Room name
#sfonshore26 >

Workspace
Expensify Chat

[dubielzyk-expensify]

Ahh yes I'm down for this 👍

[shawnborton]

Works for me!

[Pujan92]

@Nodebrute Let's make the required change and apply the same for the workspace room

[Nodebrute]

@Pujan92 on it.

[Pujan92]

Bump @Nodebrute for the update

[Nodebrute]

Sorry, I missed this. I’ll update it today.

[Nodebrute]

@Pujan92 additionalRoomDetails is used in multiple places (Workspace Chat, Room, and Invoice Room). Should I update all of them?

   const additionalRoomDetails =
        (isPolicyExpenseChat && !!report?.isOwnPolicyExpenseChat) || isExpenseReportUtil(report) || isPolicyExpenseChat || isInvoiceRoom
            ? chatRoomSubtitle
            : `${translate('threads.in')} ${chatRoomSubtitle}`;

[Pujan92]

@Nodebrute we need this specific to workspace room where we have the workspace name. For others, as shown here don't need that change

[dannymcclain]

Did this one get lost in the shuffle? Any updates or next steps here?

[Pujan92]

@MelvinBot Let's close this PR as a new PR is up for this issue - #89714

[MelvinBot]

👋 Thanks for the heads-up, Pujan92. A replacement PR is available at #89714.

Nodebrute — since you're the PR author, could you close this PR if it's no longer needed?

[Pujan92]

@MelvinBot Plz unassing me here as we are not moving forward with this PR

[MelvinBot]

Done! I've unassigned Pujan92 from the linked issue (#76669).

[Pujan92]

@MelvinBot Plz assign me back to the issue. I was just referring this PR not the issue

[MelvinBot]

Sorry about that! I've re-assigned Pujan92 back to the linked issue (#76669).

[Pujan92]

@MelvinBot I am referring to remove me from reviewer here

[MelvinBot]

I'm unable to remove Pujan92 as a reviewer via the API since a review has already been submitted. A repo admin or the PR author would need to manually dismiss the review or remove the reviewer from the PR's sidebar on GitHub.

[Nodebrute]

Apologies for the delay. I’ve closed this PR.