Disable threading for Manager McTest messages#77484
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
NikkiWines
left a comment
There was a problem hiding this comment.
Looks good, but can we add a test to reportUtilsTest for the new condition?
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good from a product perspective
|
Added a test! |
b43d691
|
@Krishna2323 can you review + test on platforms please? |
|
Reviewing... |
|
@c3024 please update the test steps to:
|
|
Just wanted to note that we have a bug where the total section is shown twice, and this is also happening on staging: Monosnap.screencast.2025-12-08.21-51-47.mp4 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_native.mp4Android: mWeb Chromeandroid_chrome.mp4iOS: HybridAppios_native.mp4iOS: mWeb Safariios_safari.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
Krishna2323
left a comment
There was a problem hiding this comment.
The changes looks good to me! @c3024 please update the test steps when you get a chance. Thanks!
|
Done! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.84-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀
|
Explanation of Change
There is an edge-case flow in the linked issue with Manager McTest because we optimistically generate a paid message for test expenses.
I chatted with @grgia about this bug, and she suggested if we can disable threading for Manager McTest messages.
Manager McTest doesn’t chat with members anyway and already replies to members in this manner when they send a message.
So, this PR disables creating threads from McTest-sent messages.
Fixed Issues
$ #74040
PROPOSAL: NA
Tests
Screen.Recording.2025-12-12.at.11.46.20.AM.mov
Offline tests
NA
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-12.at.11.46.20.AM.mov