fix: Red dot is displayed on report preview after dismissed the error messages by nkdengineer · Pull Request #77115 · Expensify/App

nkdengineer · 2025-12-09T07:55:15Z

Explanation of Change

Some errors objects can have the key with null value. This PR introduces isEmptyValueObject util to check whether an errors object has a valid error

Fixed Issues

$ #76522
PROPOSAL: #76522 (comment)

Tests

Employee submits expense in workspace chat
Employee goes offline
Approver at other device approves the expense
Employee retract and delete the expense
Employee goes back online
Employee taps on the expense
Employee taps on X button of error message
Employee scroll down to the end and tap on X button of error message
Employee tap back button for return to report preview
Verify that no red dot appears on report preview

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-09.at.14.49.43.mov

Android: mWeb Chrome

Screen.Recording.2025-12-09.at.14.48.12.mov

iOS: Native

Screen.Recording.2025-12-09.at.14.44.20.mov

iOS: mWeb Safari

Screen.Recording.2025-12-09.at.14.45.15.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-09.at.14.54.29.mov

… messages

codecov · 2025-12-09T08:03:20Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/OfflineWithFeedback.tsx	`74.46% <100.00%> (ø)`
src/types/utils/EmptyObject.ts	`100.00% <100.00%> (ø)`
src/pages/home/report/PureReportActionItem.tsx	`52.17% <66.66%> (+0.07%)`	⬆️
src/libs/ErrorUtils.ts	`44.32% <60.00%> (ø)`
src/libs/ReportUtils.ts	`73.57% <33.33%> (ø)`
... and 8 files with indirect coverage changes

melvin-bot · 2025-12-09T08:37:39Z

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abzokhattab · 2025-12-09T18:31:15Z

Thanks @nkdengineer for the quick PR. i just have one point. is it possible to add test cases for those util files to test the new functionality.

trjExpensify

Pesky dots!

P.S Can you try to make your PR titles more reflective of what code changes the PR is making / fill out the explanation of changes section? Thanks!

nkdengineer · 2025-12-11T08:52:06Z

Because there's no visible bug in those files, what do we need to test for them?

abzokhattab · 2025-12-11T09:02:20Z

That the new function is working as expected meaning its treating objects with null keys as empty ... we can just test the isEmptyValueObject function in this case ... lets add couple of tests to ensure that the old behaviour is the same + the new behaviour

abzokhattab · 2025-12-14T13:55:34Z


-export {isEmptyObject, getEmptyObject};
+function isEmptyValueObject<T>(obj: T | EmptyValue) {
+    return Object.values(obj ?? {}).filter(Boolean).length === 0;


Let’s make this check stricter than Boolean. Using filter(Boolean) treats 0 as falsy, so an object containing this values could be incorrectly considered “empty”. We should only treat values as empty when they’re null

What do u think?

Agree, I updated.

abzokhattab · 2025-12-14T15:26:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-14.at.16.21.37.mov

Android: mWeb Chrome

Screen.Recording.2025-12-14.at.16.24.37.mov

iOS: HybridApp

Screen.Recording.2025-12-14.at.16.11.26.mov

iOS: mWeb Safari

Screen.Recording.2025-12-14.at.16.13.32.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-14.at.16.05.53.mov

abzokhattab

@nkdengineer lets me know what u think about the comments above .. but other than this the changes are fixing the bug and look good to me

OSBotify · 2025-12-15T13:30:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-16T22:47:52Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-12-17T10:09:32Z

@nkdengineer QA team faced this PR with an original issue on Native apps

1765946853140.77115A.mp4

OSBotify · 2025-12-17T12:25:34Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T18:47:03Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:10:27Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rlinoz · 2025-12-19T12:48:37Z

@nkdengineer did you get a chance to check this one? #77115 (comment)

fix: Red dot is displayed on report preview after dismissed the error…

a621c66

… messages

melvin-bot Bot assigned nkdengineer Dec 9, 2025

fix lint

65a2445

nkdengineer marked this pull request as ready for review December 9, 2025 08:37

nkdengineer requested review from a team as code owners December 9, 2025 08:37

melvin-bot Bot requested a review from abzokhattab December 9, 2025 08:37

melvin-bot Bot requested review from trjExpensify and removed request for a team December 9, 2025 08:37

Merge branch 'main' into fix/76522

cb742ed

trjExpensify previously approved these changes Dec 9, 2025

View reviewed changes

Merge branch 'main' into fix/76522

87ce2d0

abzokhattab reviewed Dec 14, 2025

View reviewed changes

abzokhattab approved these changes Dec 14, 2025

View reviewed changes

melvin-bot Bot requested a review from rlinoz December 14, 2025 15:27

nkdengineer added 2 commits December 15, 2025 14:55

Merge branch 'main' into fix/76522

8cfb259

use stricter condition

886caa1

nkdengineer dismissed trjExpensify’s stale review via 886caa1 December 15, 2025 07:56

rlinoz approved these changes Dec 15, 2025

View reviewed changes

rlinoz merged commit 4456dcd into Expensify:main Dec 15, 2025
32 checks passed

OSBotify mentioned this pull request Dec 16, 2025

Deploy Checklist: New Expensify 2025-12-16 #77818

Closed

melvin-bot Bot mentioned this pull request Dec 18, 2025

[Due for payment 2025-12-25] [$250] Hybrid - Red dot is displayed on report preview after dismissed the error messages #76522

Closed

8 tasks

Uh oh!

Conversation

nkdengineer commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Dec 9, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Dec 9, 2025

Uh oh!

abzokhattab commented Dec 9, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Dec 11, 2025

Uh oh!

abzokhattab commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkdengineer Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

abzokhattab commented Dec 14, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

abzokhattab left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 15, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

IuliiaHerets commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

rlinoz commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nkdengineer commented Dec 9, 2025 •

edited

Loading

codecov Bot commented Dec 9, 2025 •

edited by github-actions Bot

Loading

abzokhattab commented Dec 11, 2025 •

edited

Loading

abzokhattab Dec 14, 2025 •

edited

Loading

abzokhattab left a comment •

edited

Loading