-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Refactor AddressSearch to be compatible with Form #7701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcochavezf
merged 14 commits into
Expensify:main
from
kakajann:refactor/address-search
Feb 24, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5fcb7b7
AddressSearch component refactor
kakajann 255d268
update form stories
kakajann d699187
create story for AddressSearch
kakajann 4387358
Merge branch 'main' of github.com:kakajann/Expensify into refactor/ad…
kakajann e868e06
fix props.onChange is not a function error
kakajann 2219e26
remove unneccary comment
kakajann 3cebf96
make default value undefined
kakajann c2b4ce5
Merge branch 'main' of github.com:kakajann/Expensify into refactor/ad…
kakajann fbee850
Merge branch 'main' of github.com:kakajann/Expensify into refactor/ad…
kakajann 996f12b
change onChange prop to onChangeText
kakajann 7186e17
validate props.value before trimming it
kakajann 9217a76
Update src/stories/AddressSearch.stories.js
kakajann 2392560
rename getInputIDPropTypes with validateInputIDProps
kakajann 15926e2
Merge branch 'Expensify:main' into refactor/address-search
kakajann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import React, {useState} from 'react'; | ||
| import AddressSearch from '../components/AddressSearch'; | ||
|
|
||
| /** | ||
| * We use the Component Story Format for writing stories. Follow the docs here: | ||
| * | ||
| * https://storybook.js.org/docs/react/writing-stories/introduction#component-story-format | ||
| */ | ||
| export default { | ||
| title: 'Components/AddressSearch', | ||
| component: AddressSearch, | ||
| args: { | ||
| label: 'Enter street', | ||
| errorText: '', | ||
| }, | ||
| }; | ||
|
|
||
| const Template = (args) => { | ||
| const [value, setValue] = useState(''); | ||
| return ( | ||
| <AddressSearch | ||
| value={value} | ||
| onChange={({street}) => setValue(street)} | ||
| // eslint-disable-next-line react/jsx-props-no-spreading | ||
| {...args} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| // Arguments can be passed to the component by binding | ||
| // See: https://storybook.js.org/docs/react/writing-stories/introduction#using-args | ||
| const Default = Template.bind({}); | ||
|
|
||
| const ErrorStory = Template.bind({}); | ||
| ErrorStory.args = { | ||
| errorText: 'The street you are looking for does not exist', | ||
| }; | ||
|
|
||
| export { | ||
| Default, | ||
| ErrorStory, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.