-
Notifications
You must be signed in to change notification settings - Fork 4k
Use canReject property to determine if a transaction can be rejected in Reports page
#76998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
924b2e3
add `canReject` to SearchTransaction type
lakchote cb1b33b
add `canReject` to SelectedTransactionInfo
lakchote fc3a4f0
add `canReject` to selection mappings
lakchote 3534544
replace prefetching with `canReject` check
lakchote ef52fa7
add `canReject` to test mock data
lakchote edb094a
add `canReject` to test mock data
lakchote db81a18
add `canReject` to test mock data
lakchote 5de885e
add `canReject` to test mock data
lakchote f1bd51a
Merge remote-tracking branch 'origin/main' into lucien/use-canReject-…
lakchote 5656d08
update expected property count in test for `canReject`
lakchote 98d7ade
remove `canReject` from SearchTransaction type
lakchote 62b0485
compute `canReject` dynamically via `canRejectReportAction`
lakchote d6d4e13
remove `canReject` from test mocks
lakchote dd52b64
Merge branch 'main' into lucien/add-Search-canReject-property
lakchote 0712f04
fix style
lakchote d38c2bc
Merge branch 'main' into lucien/add-Search-canReject-property
lakchote 632fc5c
fixes to undo the soft revert
lakchote 2fdff4b
fix style
lakchote 08a796d
use `report.transactionCount` for accurate all-selected check
lakchote f252561
Merge branch 'main' into lucien/use-canReject-from-search
lakchote 7eae475
hide reject option for expense-report search
lakchote d02d7a8
Merge remote-tracking branch 'origin/main' into lucien/use-canReject-…
lakchote 826c2c5
fix style
lakchote 938b536
fixes
lakchote 0d0a8e1
add reject transactions route for money request report
lakchote f9f291b
add screen mapping for reject transactions route
lakchote 09abd73
add `rejectMoneyRequestInBulkFromReport` function
lakchote 005d91c
update reject navigation to use report route
lakchote ff6c641
handle both reject routes with bulk API support
lakchote 6da6bf1
fix style
lakchote d4a11b5
add `hasTransactionBeenRejected` helper
lakchote bd564bf
simplify `rejectMoneyRequestsOnSearch` type
lakchote df3f786
remove duplicate bulk reject functions
lakchote 2c32a77
use `hasTransactionBeenRejected` helper
lakchote 619943c
reuse `rejectMoneyRequestsOnSearch` for both views
lakchote 2a87aeb
filter out already rejected transactions
lakchote ce4a02d
add education modal for bulk reject
lakchote 407081b
fix style
lakchote c71f225
fix offline delete count in bulk reject
lakchote fd1d444
fix style
lakchote d865449
add `REJECT_BULK` action type for bulk reject
lakchote cf2b64f
remove redundant `isReportReimbursed` check
lakchote 99b3a16
fix bulk reject education modal navigation
lakchote 2b0c327
use Partial type for secondary actions implementation
lakchote 5b9cb3b
fix style
lakchote 506bbf3
fix lint error for default ID value
lakchote 4479bae
Merge branch 'main' into lucien/use-canReject-from-search
lakchote a641f4c
use CONST for reject action value
lakchote 154d468
match options by value instead of text
lakchote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.