fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual#76799
Conversation
… detail display as manual
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
Product behavior looks good based on the testing steps.
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp76799-android-hybrid-001.mp4Android: mWeb Chrome76799-mweb-chrome-001.mp4iOS: HybridAppCould not test as upload of scan receipt failed. But I think this is fine as we have already tested on android hybrid version. iOS: mWeb Safari76799-mweb-safari-001.mp4MacOS: Chrome / Safari76799-web-chrome-001.mp4 |
rojiphil
left a comment
There was a problem hiding this comment.
Thanks @nkdengineer for the PR.
@mjasikowski Changes LGTM and works well too.
All yours. Thanks.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.78-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
Explanation of Change
fix: Add receipt from manual expense, QAB is scan receipt but confirm detail display as manual
Fixed Issues
$ #74911
PROPOSAL: #74911 (comment)
Tests
Offline tests
None
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-05.at.14.03.08.mov
Android: mWeb Chrome
Screen.Recording.2025-12-05.at.14.02.07.mov
iOS: Native
Screen.Recording.2025-12-05.at.14.08.28.mov
iOS: mWeb Safari
Screen.Recording.2025-12-05.at.14.04.23.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-05.at.14.01.10.mov