Shortening section headers on the "Workflows" page#76787
Conversation
This comment has been minimized.
This comment has been minimized.
|
@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@danieldoglas are you able to run the command to translate this copy update to all the other languages? Thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@jamesdeanexpensify I think you only need to run the line the bot sent above.
If I run the changes myself I can't merge this PR. |
|
Am I able to do that if I only manipulate the codebase via Github itself? My skills are very basic 😆 |
0ac76c3 to
e3e5629
Compare
|
You'd need to change those in your machine @jamesdeanexpensify I've merged main here and will see if the parrot will give us a new diff, and I'll apply it. |
|
Manually running the workflow - https://github.com/Expensify/App/actions/runs/20069465025 |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 20a6a590..79402fb8 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2251,16 +2251,16 @@ ${amount} für ${merchant} – ${date}`,
workflowsPage: {
workflowTitle: 'Ausgabe',
workflowDescription: 'Konfigurieren Sie einen Workflow ab dem Zeitpunkt, an dem Ausgaben entstehen, einschließlich Genehmigung und Zahlung.',
- submissionFrequency: 'Übermittlungshäufigkeit',
+ submissionFrequency: 'Einreichungen',
submissionFrequencyDescription: 'Wählen Sie einen benutzerdefinierten Zeitplan zum Einreichen von Ausgaben.',
submissionFrequencyDateOfMonth: 'Tag des Monats',
disableApprovalPromptDescription: 'Das Deaktivieren von Genehmigungen löscht alle vorhandenen Genehmigungs-Workflows.',
- addApprovalsTitle: 'Genehmigungen hinzufügen',
+ addApprovalsTitle: 'Genehmigungen',
addApprovalButton: 'Genehmigungs-Workflow hinzufügen',
addApprovalTip: 'Dieser Standard-Workflow gilt für alle Mitglieder, sofern kein spezifischerer Workflow vorhanden ist.',
approver: 'Genehmiger',
addApprovalsDescription: 'Zusätzliche Genehmigung anfordern, bevor eine Zahlung autorisiert wird.',
- makeOrTrackPaymentsTitle: 'Zahlungen erstellen oder verfolgen',
+ makeOrTrackPaymentsTitle: 'Zahlungen',
makeOrTrackPaymentsDescription:
'Fügen Sie eine autorisierte zahlende Person für Zahlungen hinzu, die in Expensify getätigt werden, oder verfolgen Sie Zahlungen, die andernorts vorgenommen wurden.',
customApprovalWorkflowEnabled:
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 6022de2e..3f7ec3cb 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2254,16 +2254,16 @@ ${amount} pour ${merchant} - ${date}`,
workflowsPage: {
workflowTitle: 'Dépenses',
workflowDescription: 'Configurez un flux de travail depuis le moment où la dépense a lieu, en incluant l’approbation et le paiement.',
- submissionFrequency: 'Fréquence d’envoi',
+ submissionFrequency: 'Soumissions',
submissionFrequencyDescription: 'Choisissez un planning personnalisé pour soumettre les dépenses.',
submissionFrequencyDateOfMonth: 'Jour du mois',
disableApprovalPromptDescription: 'La désactivation des approbations effacera tous les workflows d’approbation existants.',
- addApprovalsTitle: 'Ajouter des approbations',
+ addApprovalsTitle: 'Approbations',
addApprovalButton: 'Ajouter un circuit de validation',
addApprovalTip: 'Ce flux de travail par défaut s’applique à tous les membres, sauf si un flux de travail plus spécifique existe.',
approver: 'Approbateur',
addApprovalsDescription: 'Exiger une approbation supplémentaire avant d’autoriser un paiement.',
- makeOrTrackPaymentsTitle: 'Effectuer ou suivre des paiements',
+ makeOrTrackPaymentsTitle: 'Paiements',
makeOrTrackPaymentsDescription: 'Ajoutez un payeur autorisé pour les paiements effectués dans Expensify ou suivez les paiements effectués ailleurs.',
customApprovalWorkflowEnabled:
'<muted-text-label>Un workflow d’approbation personnalisé est activé sur cet espace de travail. Pour examiner ou modifier ce workflow, veuillez contacter votre <account-manager-link>Account Manager</account-manager-link> ou <concierge-link>Concierge</concierge-link>.</muted-text-label>',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index fcc73786..6b09f1e9 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2244,16 +2244,16 @@ ${amount} per ${merchant} - ${date}`,
workflowsPage: {
workflowTitle: 'Spese',
workflowDescription: 'Configura un flusso di lavoro dal momento in cui si verifica la spesa, includendo approvazione e pagamento.',
- submissionFrequency: 'Frequenza di invio',
+ submissionFrequency: 'Invii',
submissionFrequencyDescription: 'Scegli una pianificazione personalizzata per l’invio delle spese.',
submissionFrequencyDateOfMonth: 'Data del mese',
disableApprovalPromptDescription: 'La disattivazione delle approvazioni eliminerà tutti i flussi di lavoro di approvazione esistenti.',
- addApprovalsTitle: 'Aggiungi approvazioni',
+ addApprovalsTitle: 'Approvazioni',
addApprovalButton: 'Aggiungi flusso di approvazione',
addApprovalTip: 'Questo flusso di lavoro predefinito si applica a tutti i membri, a meno che non esista un flusso di lavoro più specifico.',
approver: 'Approvatore',
addApprovalsDescription: "Richiedi un'approvazione aggiuntiva prima di autorizzare un pagamento.",
- makeOrTrackPaymentsTitle: 'Effettua o monitora pagamenti',
+ makeOrTrackPaymentsTitle: 'Pagamenti',
makeOrTrackPaymentsDescription: 'Aggiungi un pagatore autorizzato per i pagamenti effettuati in Expensify o tieni traccia dei pagamenti effettuati altrove.',
customApprovalWorkflowEnabled:
'<muted-text-label>Un flusso di approvazione personalizzato è abilitato in questo workspace. Per rivedere o modificare questo flusso di lavoro, contatta il tuo <account-manager-link>Account Manager</account-manager-link> o <concierge-link>Concierge</concierge-link>.</muted-text-label>',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 47c796f7..0c34a840 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2237,16 +2237,16 @@ ${merchant} への ${amount}(${date})`,
workflowsPage: {
workflowTitle: '支出',
workflowDescription: '支出が発生した瞬間から、承認と支払いまでを含めたワークフローを構成します。',
- submissionFrequency: '提出頻度',
+ submissionFrequency: '提出物',
submissionFrequencyDescription: '経費を提出するカスタムスケジュールを選択してください。',
submissionFrequencyDateOfMonth: '月の日付',
disableApprovalPromptDescription: '承認を無効にすると、既存のすべての承認ワークフローが削除されます。',
- addApprovalsTitle: '承認を追加',
+ addApprovalsTitle: '承認',
addApprovalButton: '承認ワークフローを追加',
addApprovalTip: 'より詳細なワークフローが存在しない限り、このデフォルトのワークフローはすべてのメンバーに適用されます。',
approver: '承認者',
addApprovalsDescription: '支払いを承認する前に、追加の承認を要求する。',
- makeOrTrackPaymentsTitle: '支払いの作成や追跡を行う',
+ makeOrTrackPaymentsTitle: '支払い',
makeOrTrackPaymentsDescription: 'Expensify で行われる支払い用の承認済み支払者を追加するか、他で行われた支払いを追跡します。',
customApprovalWorkflowEnabled:
'<muted-text-label>このワークスペースではカスタム承認ワークフローが有効になっています。このワークフローを確認または変更するには、<account-manager-link>アカウントマネージャー</account-manager-link>または<concierge-link>Concierge</concierge-link>までご連絡ください。</muted-text-label>',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index c3b9cab7..17cdec88 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2241,16 +2241,16 @@ ${amount} voor ${merchant} - ${date}`,
workflowsPage: {
workflowTitle: 'Uitgaven',
workflowDescription: 'Configureer een workflow vanaf het moment dat uitgaven plaatsvinden, inclusief goedkeuring en betaling.',
- submissionFrequency: 'Indieningsfrequentie',
+ submissionFrequency: 'Inzendingen',
submissionFrequencyDescription: 'Kies een aangepast schema voor het indienen van onkosten.',
submissionFrequencyDateOfMonth: 'Dag van de maand',
disableApprovalPromptDescription: 'Het uitschakelen van goedkeuringen wist alle bestaande goedkeuringsworkflows.',
- addApprovalsTitle: 'Goedkeuringen toevoegen',
+ addApprovalsTitle: 'Goedkeuringen',
addApprovalButton: 'Goedkeuringsworkflow toevoegen',
addApprovalTip: 'Deze standaardworkflow is van toepassing op alle leden, tenzij er een specifiekere workflow bestaat.',
approver: 'Fiatteur',
addApprovalsDescription: 'Extra goedkeuring vereisen voordat een betaling wordt geautoriseerd.',
- makeOrTrackPaymentsTitle: 'Betalingen uitvoeren of volgen',
+ makeOrTrackPaymentsTitle: 'Betalingen',
makeOrTrackPaymentsDescription: 'Voeg een gemachtigde betaler toe voor betalingen die in Expensify worden gedaan of houd betalingen bij die elders worden gedaan.',
customApprovalWorkflowEnabled:
'<muted-text-label>Er is een aangepast goedkeuringsworkflow ingeschakeld voor deze workspace. Neem contact op met uw <account-manager-link>Account Manager</account-manager-link> of <concierge-link>Concierge</concierge-link> om deze workflow te bekijken of te wijzigen.</muted-text-label>',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 25267a4e..62353a7b 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2239,16 +2239,16 @@ ${amount} dla ${merchant} - ${date}`,
workflowsPage: {
workflowTitle: 'Wydatki',
workflowDescription: 'Skonfiguruj proces od momentu poniesienia wydatku, obejmujący akceptację i płatność.',
- submissionFrequency: 'Częstotliwość zgłoszeń',
+ submissionFrequency: 'Zgłoszenia',
submissionFrequencyDescription: 'Wybierz niestandardowy harmonogram przesyłania wydatków.',
submissionFrequencyDateOfMonth: 'Dzień miesiąca',
disableApprovalPromptDescription: 'Wyłączenie zatwierdzeń usunie wszystkie istniejące przepływy pracy zatwierdzania.',
- addApprovalsTitle: 'Dodaj zatwierdzenia',
+ addApprovalsTitle: 'Zatwierdzenia',
addApprovalButton: 'Dodaj proces zatwierdzania',
addApprovalTip: 'Ten domyślny przepływ pracy ma zastosowanie do wszystkich członków, chyba że istnieje bardziej szczegółowy przepływ pracy.',
approver: 'Akceptujący',
addApprovalsDescription: 'Wymagaj dodatkowej akceptacji przed autoryzacją płatności.',
- makeOrTrackPaymentsTitle: 'Dokonuj lub śledź płatności',
+ makeOrTrackPaymentsTitle: 'Płatności',
makeOrTrackPaymentsDescription: 'Dodaj upoważnioną osobę dokonującą płatności w Expensify lub śledź płatności dokonane gdzie indziej.',
customApprovalWorkflowEnabled:
'<muted-text-label>W tym obszarze roboczym włączono niestandardowy proces zatwierdzania. Aby przejrzeć lub zmienić ten proces, skontaktuj się ze swoim <account-manager-link>Opiekunem klienta</account-manager-link> lub <concierge-link>Concierge</concierge-link>.</muted-text-label>',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index e066f96f..970ee088 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2238,16 +2238,16 @@ ${amount} para ${merchant} - ${date}`,
workflowsPage: {
workflowTitle: 'Gastos',
workflowDescription: 'Configure um fluxo de trabalho desde o momento em que o gasto ocorre, incluindo aprovação e pagamento.',
- submissionFrequency: 'Frequência de envio',
+ submissionFrequency: 'Envios',
submissionFrequencyDescription: 'Escolha uma programação personalizada para enviar despesas.',
submissionFrequencyDateOfMonth: 'Data do mês',
disableApprovalPromptDescription: 'Desativar as aprovações apagará todos os fluxos de trabalho de aprovação existentes.',
- addApprovalsTitle: 'Adicionar aprovações',
+ addApprovalsTitle: 'Aprovações',
addApprovalButton: 'Adicionar fluxo de aprovação',
addApprovalTip: 'Este fluxo de trabalho padrão se aplica a todos os membros, a menos que exista um fluxo de trabalho mais específico.',
approver: 'Aprovador',
addApprovalsDescription: 'Exigir aprovação adicional antes de autorizar um pagamento.',
- makeOrTrackPaymentsTitle: 'Fazer ou acompanhar pagamentos',
+ makeOrTrackPaymentsTitle: 'Pagamentos',
makeOrTrackPaymentsDescription: 'Adicione um pagador autorizado para pagamentos feitos no Expensify ou acompanhe pagamentos feitos em outros lugares.',
customApprovalWorkflowEnabled:
'<muted-text-label>Um fluxo de aprovação personalizado está ativado neste workspace. Para revisar ou alterar esse fluxo, entre em contato com seu <account-manager-link>Gerente de Conta</account-manager-link> ou com o <concierge-link>Concierge</concierge-link>.</muted-text-label>',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index cedc9a0d..194bb73e 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2208,16 +2208,16 @@ ${amount},商户:${merchant} - ${date}`,
workflowsPage: {
workflowTitle: '支出',
workflowDescription: '从支出发生的那一刻起配置完整的工作流,包括审批和付款。',
- submissionFrequency: '提交频率',
+ submissionFrequency: '提交',
submissionFrequencyDescription: '选择一个自定义报销提交计划。',
submissionFrequencyDateOfMonth: '月份中的日期',
disableApprovalPromptDescription: '禁用审批将删除所有现有的审批工作流程。',
- addApprovalsTitle: '添加审批',
+ addApprovalsTitle: '审批',
addApprovalButton: '添加审批工作流程',
addApprovalTip: '此默认工作流程适用于所有成员,除非存在更具体的工作流程。',
approver: '审批人',
addApprovalsDescription: '在授权付款前需要额外审批。',
- makeOrTrackPaymentsTitle: '发起或跟踪付款',
+ makeOrTrackPaymentsTitle: '付款',
makeOrTrackPaymentsDescription: '为在 Expensify 中进行的付款添加授权付款人,或跟踪在其他地方进行的付款。',
customApprovalWorkflowEnabled:
'<muted-text-label>此工作区已启用自定义审批流程。要查看或更改此流程,请联系您的<account-manager-link>客户经理</account-manager-link>或<concierge-link>Concierge</concierge-link>。</muted-text-label>',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@joekaufmanexpensify would you mind approving this again so we can merge it? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.82-0 🚀
|
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.84-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀
|
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/576160
Tests
Offline tests
QA Steps
More featuressection of a workspaceWorkflowsand click into itSubmissionsApprovalsPaymentsPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari