Skip to content

[NoQA] Revert "[NoQA] Update field rendering in PaymentCardFormTest"#75163

Merged
mountiny merged 1 commit into
mainfrom
revert-74847-patch-22
Nov 14, 2025
Merged

[NoQA] Revert "[NoQA] Update field rendering in PaymentCardFormTest"#75163
mountiny merged 1 commit into
mainfrom
revert-74847-patch-22

Conversation

@mountiny

Copy link
Copy Markdown
Contributor

Reverts #74847

@mountiny mountiny requested a review from a team as a code owner November 14, 2025 14:16
@melvin-bot melvin-bot Bot requested review from tylerkaraszewski and removed request for a team November 14, 2025 14:17
@melvin-bot

melvin-bot Bot commented Nov 14, 2025

Copy link
Copy Markdown

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny

Copy link
Copy Markdown
Contributor Author

Reverting as it seems like the change made the tests failing now - thought they were passing on the PR https://github.com/Expensify/App/actions/runs/19365204787

@codecov

codecov Bot commented Nov 14, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 13 files with indirect coverage changes

@mountiny mountiny merged commit cecf68a into main Nov 14, 2025
23 of 27 checks passed
@mountiny mountiny deleted the revert-74847-patch-22 branch November 14, 2025 15:35
@melvin-bot

melvin-bot Bot commented Nov 14, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

Copy link
Copy Markdown
Contributor Author

Straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.59-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.2.59-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants