[NO QA] Shorten test drive modal copy#74986
Merged
Merged
Conversation
Updated the modal copy to remove 'No pit stops required!'
Removed the phrase '¡No se requieren paradas!' from the modal description.
melvin-bot
Bot
requested review from
JmillsExpensify and
Valforte
and removed request for
a team
Contributor
Author
|
@Valforte are you able to run a command for all the other languages that need updating? Thanks! |
This comment has been minimized.
This comment has been minimized.
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 8eff56d3..2e082edf 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1415,11 +1415,11 @@ const translations: TranslationDeepObject<typeof en> = {
}),
payOnly: 'Nur bezahlen',
approveOnly: 'Nur genehmigen',
- holdEducationalTitle: 'Diese Anfrage ist an',
- holdEducationalText: 'halten',
- whatIsHoldExplain: 'Halten ist wie das Drücken der „Pause“-Taste bei einer Ausgabe, um vor der Genehmigung oder Zahlung nach weiteren Details zu fragen.',
+ holdEducationalTitle: 'Diese Anfrage ist aktiv',
+ holdEducationalText: 'Anhalten',
+ whatIsHoldExplain: 'Hold ist, als würde man bei einer Ausgabe auf „Pause“ drücken, um vor der Genehmigung oder Zahlung weitere Details anzufordern.',
holdIsLeftBehind: 'Zurückgehaltene Ausgaben werden nach Genehmigung oder Zahlung in einen anderen Bericht verschoben.',
- unholdWhenReady: 'Genehmiger können Ausgaben freigeben, wenn sie zur Genehmigung oder Zahlung bereit sind.',
+ unholdWhenReady: 'Genehmigende können Ausgaben freigeben, wenn sie zur Genehmigung oder Zahlung bereit sind.',
changePolicyEducational: {
title: 'Du hast diesen Bericht verschoben!',
description: 'Überprüfen Sie diese Punkte, die sich beim Verschieben von Berichten in einen neuen Arbeitsbereich ändern können.',
@@ -7387,8 +7387,8 @@ ${amount} für ${merchant} - ${date}`,
},
modal: {
title: 'Probieren Sie uns aus',
- description: 'Machen Sie eine schnelle Produkttour, um schnell auf den neuesten Stand zu kommen. Keine Zwischenstopps erforderlich!',
- confirmText: 'Testfahrt starten',
+ description: 'Machen Sie eine kurze Tour durch das Produkt, um schnell auf den neuesten Stand zu kommen.',
+ confirmText: 'Testversion starten',
helpText: 'Überspringen',
employee: {
description:
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 20ef3b44..7e49e720 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1418,10 +1418,10 @@ const translations: TranslationDeepObject<typeof en> = {
payOnly: 'Payer seulement',
approveOnly: 'Approuver seulement',
holdEducationalTitle: 'Cette demande est activée',
- holdEducationalText: 'tenir',
- whatIsHoldExplain: 'La mise en attente, c\'est comme appuyer sur "pause" pour une dépense afin de demander plus de détails avant l\'approbation ou le paiement.',
- holdIsLeftBehind: 'Les dépenses en attente sont déplacées vers un autre rapport après approbation ou paiement.',
- unholdWhenReady: "Les approbateurs peuvent débloquer les dépenses lorsqu'elles sont prêtes pour approbation ou paiement.",
+ holdEducationalText: 'Mettre en attente',
+ whatIsHoldExplain: 'La mise en attente, c’est comme appuyer sur « pause » sur une dépense pour demander plus de détails avant l’approbation ou le paiement.',
+ holdIsLeftBehind: 'Les dépenses en attente sont déplacées vers un autre rapport lors de l’approbation ou du paiement.',
+ unholdWhenReady: 'Les approbateurs peuvent lever la mise en attente des dépenses lorsqu’elles sont prêtes pour approbation ou paiement.',
changePolicyEducational: {
title: 'Vous avez déplacé ce rapport !',
description: 'Vérifiez ces éléments, qui ont tendance à changer lors du déplacement des rapports vers un nouvel espace de travail.',
@@ -7390,8 +7390,8 @@ ${amount} pour ${merchant} - ${date}`,
},
modal: {
title: 'Faites un essai avec nous',
- description: "Faites une visite rapide du produit pour vous mettre rapidement à jour. Pas d'arrêts nécessaires !",
- confirmText: "Commencer l'essai",
+ description: 'Faites une visite rapide du produit pour être rapidement opérationnel.',
+ confirmText: 'Commencer l’essai',
helpText: 'Passer',
employee: {
description:
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 5fd1e061..93926198 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1412,10 +1412,10 @@ const translations: TranslationDeepObject<typeof en> = {
payOnly: 'Paga solo',
approveOnly: 'Approva solo',
holdEducationalTitle: 'Questa richiesta è attiva',
- holdEducationalText: 'tieni',
- whatIsHoldExplain: 'Mettere in sospeso è come premere "pausa" su una spesa per chiedere ulteriori dettagli prima dell\'approvazione o del pagamento.',
- holdIsLeftBehind: "Le spese trattenute vengono spostate in un altro report al momento dell'approvazione o del pagamento.",
- unholdWhenReady: "Gli approvatori possono sbloccare le spese quando sono pronte per l'approvazione o il pagamento.",
+ holdEducationalText: 'in sospeso',
+ whatIsHoldExplain: 'Mettere in sospeso è come premere "pausa" su una spesa per chiedere ulteriori dettagli prima dell’approvazione o del pagamento.',
+ holdIsLeftBehind: 'Le spese in sospeso vengono spostate in un altro report al momento dell’approvazione o del pagamento.',
+ unholdWhenReady: 'Gli approvatori possono sbloccare le spese quando sono pronte per l’approvazione o per il pagamento.',
changePolicyEducational: {
title: 'Hai spostato questo report!',
description: 'Ricontrolla questi elementi, che tendono a cambiare quando si spostano i report in un nuovo spazio di lavoro.',
@@ -7396,8 +7396,8 @@ ${amount} per ${merchant} - ${date}`,
},
modal: {
title: 'Mettici alla prova',
- description: 'Fai un rapido tour del prodotto per metterti al passo velocemente. Nessuna sosta necessaria!',
- confirmText: 'Inizia la prova',
+ description: 'Fai un breve tour del prodotto per metterti subito al passo.',
+ confirmText: 'Avvia il test drive',
helpText: 'Salta',
employee: {
description:
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 3d8e3e63..afb198a2 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1411,11 +1411,11 @@ const translations: TranslationDeepObject<typeof en> = {
}),
payOnly: '支払いのみ',
approveOnly: '承認のみ',
- holdEducationalTitle: 'このリクエストはオン',
+ holdEducationalTitle: 'This request is on',
holdEducationalText: '保留',
- whatIsHoldExplain: '保留は、承認や支払いの前に詳細を確認するために、経費を「一時停止」するようなものです。',
- holdIsLeftBehind: '保留された経費は承認または支払い時に別のレポートに移動します。',
- unholdWhenReady: '承認者は、承認または支払いの準備が整ったときに経費を解除できます。',
+ whatIsHoldExplain: '「Hold」は、承認や支払いの前に詳細を確認するために、その経費に「一時停止」をかけるようなものです。',
+ holdIsLeftBehind: '保留中の経費は、承認または支払い時に別のレポートに移動します。',
+ unholdWhenReady: '承認者は、承認または支払いの準備ができたら、経費の保留を解除できます。',
changePolicyEducational: {
title: 'このレポートを移動しました！',
description: 'レポートを新しいワークスペースに移動する際に変更される傾向があるこれらの項目を再確認してください。',
@@ -7328,7 +7328,7 @@ ${date} - ${merchant}に${amount}`,
},
modal: {
title: '私たちを試してみてください',
- description: '製品ツアーをすばやく見て、すぐに追いつきましょう。途中で止まる必要はありません！',
+ description: '短いプロダクトツアーで、すぐに使い方を把握しましょう。',
confirmText: 'テストドライブを開始',
helpText: 'Skip',
employee: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 2d05ffa3..26edebb2 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1411,11 +1411,11 @@ const translations: TranslationDeepObject<typeof en> = {
}),
payOnly: 'Alleen betalen',
approveOnly: 'Alleen goedkeuren',
- holdEducationalTitle: 'Dit verzoek is ingediend op',
- holdEducationalText: 'vasthouden',
- whatIsHoldExplain: 'Vasthouden is als het indrukken van "pauze" op een uitgave om meer details te vragen voordat deze wordt goedgekeurd of betaald.',
- holdIsLeftBehind: 'Ingehouden uitgaven worden naar een ander rapport verplaatst na goedkeuring of betaling.',
- unholdWhenReady: 'Goedkeurders kunnen uitgaven vrijgeven wanneer ze klaar zijn voor goedkeuring of betaling.',
+ holdEducationalTitle: 'Dit verzoek is ingeschakeld',
+ holdEducationalText: 'reservering',
+ whatIsHoldExplain: "Hold is alsof je een uitgave op 'pauze' zet om meer details te vragen voordat deze wordt goedgekeurd of betaald.",
+ holdIsLeftBehind: 'Uitgaven in de wacht worden naar een ander rapport verplaatst na goedkeuring of betaling.',
+ unholdWhenReady: 'Goedkeurders kunnen onkosten vrijgeven wanneer ze klaar zijn voor goedkeuring of betaling.',
changePolicyEducational: {
title: 'Je hebt dit rapport verplaatst!',
description: 'Controleer deze items dubbel, aangezien ze de neiging hebben te veranderen bij het verplaatsen van rapporten naar een nieuwe werkruimte.',
@@ -7376,7 +7376,7 @@ ${amount} voor ${merchant} - ${date}`,
},
modal: {
title: 'Probeer ons uit',
- description: 'Maak een snelle producttour om snel op de hoogte te zijn. Geen tussenstops nodig!',
+ description: 'Volg een korte producttour om snel op gang te komen.',
confirmText: 'Start proefrit',
helpText: 'Overslaan',
employee: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 2872a833..d8cb3796 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1409,11 +1409,11 @@ const translations: TranslationDeepObject<typeof en> = {
}),
payOnly: 'Płać tylko',
approveOnly: 'Zatwierdź tylko',
- holdEducationalTitle: 'To żądanie jest w toku',
- holdEducationalText: 'trzymaj',
- whatIsHoldExplain: 'Wstrzymanie jest jak naciśnięcie „pauzy” na wydatku, aby poprosić o więcej szczegółów przed zatwierdzeniem lub płatnością.',
+ holdEducationalTitle: 'To żądanie jest aktywne',
+ holdEducationalText: 'wstrzymanie',
+ whatIsHoldExplain: 'Hold jest jak naciśnięcie „pauzy” na wydatku, aby poprosić o więcej szczegółów przed zatwierdzeniem lub płatnością.',
holdIsLeftBehind: 'Wstrzymane wydatki są przenoszone do innego raportu po zatwierdzeniu lub opłaceniu.',
- unholdWhenReady: 'Osoby zatwierdzające mogą zdjąć blokadę z wydatków, gdy będą gotowe do zatwierdzenia lub płatności.',
+ unholdWhenReady: 'Osoby zatwierdzające mogą zdjąć wstrzymanie wydatków, gdy są one gotowe do zatwierdzenia lub płatności.',
changePolicyEducational: {
title: 'Przeniosłeś ten raport!',
description: 'Sprawdź te elementy, które mają tendencję do zmiany podczas przenoszenia raportów do nowego obszaru roboczego.',
@@ -7364,8 +7364,8 @@ ${amount} dla ${merchant} - ${date}`,
},
modal: {
title: 'Wypróbuj nas w wersji testowej',
- description: 'Weź szybką wycieczkę po produkcie, aby szybko się zorientować. Żadnych przystanków nie potrzeba!',
- confirmText: 'Rozpocznij jazdę próbną',
+ description: 'Skorzystaj z krótkiego przewodnika po produkcie, aby szybko się wdrożyć.',
+ confirmText: 'Rozpocznij wersję demonstracyjną',
helpText: 'Pomiń',
employee: {
description:
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 6d8311c9..6eb34942 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1408,11 +1408,11 @@ const translations: TranslationDeepObject<typeof en> = {
}),
payOnly: 'Pagar apenas',
approveOnly: 'Aprovar apenas',
- holdEducationalTitle: 'Esta solicitação está em andamento',
- holdEducationalText: 'aguarde',
- whatIsHoldExplain: 'Colocar em espera é como apertar "pausa" em uma despesa para solicitar mais detalhes antes da aprovação ou pagamento.',
+ holdEducationalTitle: 'Esta solicitação está ativa',
+ holdEducationalText: 'reter',
+ whatIsHoldExplain: 'Hold é como apertar “pausa” em uma despesa para solicitar mais detalhes antes da aprovação ou do pagamento.',
holdIsLeftBehind: 'Despesas retidas são movidas para outro relatório após aprovação ou pagamento.',
- unholdWhenReady: 'Os aprovadores podem liberar despesas quando estiverem prontas para aprovação ou pagamento.',
+ unholdWhenReady: 'Os aprovadores podem liberar despesas quando elas estiverem prontas para aprovação ou pagamento.',
changePolicyEducational: {
title: 'Você moveu este relatório!',
description: 'Verifique novamente esses itens, que tendem a mudar ao mover relatórios para um novo espaço de trabalho.',
@@ -7376,7 +7376,7 @@ ${amount} para ${merchant} - ${date}`,
},
modal: {
title: 'Faça um test drive conosco',
- description: 'Faça um rápido tour pelo produto para se atualizar rapidamente. Sem paradas necessárias!',
+ description: 'Faça um tour rápido pelo produto para começar rapidamente.',
confirmText: 'Iniciar test drive',
helpText: 'Pular',
employee: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 29c003c7..60fbf0ad 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1389,11 +1389,11 @@ const translations: TranslationDeepObject<typeof en> = {
}),
payOnly: '仅支付',
approveOnly: '仅批准',
- holdEducationalTitle: '此请求正在处理中',
- holdEducationalText: '保持',
- whatIsHoldExplain: '将“暂停”用于费用上，以便在批准或付款前请求更多详细信息。',
- holdIsLeftBehind: '待处理费用在批准或支付后移至另一份报告。',
- unholdWhenReady: '审批者可以在准备好审批或付款时解除费用保留。',
+ holdEducationalTitle: '该请求已开启',
+ holdEducationalText: '搁置',
+ whatIsHoldExplain: 'Hold 就像对一笔费用按下“暂停”，以便在批准或付款之前请求更多详细信息。',
+ holdIsLeftBehind: '暂挂的费用在获批或付款后将移至另一份报告。',
+ unholdWhenReady: '当准备好进行审批或付款时，审批人可以解除费用的搁置。',
changePolicyEducational: {
title: '您已移动此报告！',
description: '请仔细检查这些项目，因为在将报告移动到新工作区时，它们往往会发生变化。',
@@ -7213,7 +7213,7 @@ ${merchant}的${amount} - ${date}`,
},
modal: {
title: '试用我们吧',
- description: '快速浏览产品，迅速上手。无需中途停留！',
+ description: '进行一次简短的产品导览，快速上手。',
confirmText: '开始试用',
helpText: 'Skip',
employee: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report✅ All modified and coverable lines are covered by tests. |
# Conflicts: # src/languages/de.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/nl.ts # src/languages/pl.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts
Contributor
|
@jamesdeanexpensify done. Will request a new reviewer |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
JmillsExpensify
left a comment
Contributor
There was a problem hiding this comment.
No concerns from a product/logic perspective.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
mjasikowski
approved these changes
Nov 14, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
69 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.59-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/grgia in version: 9.2.59-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the modal copy to remove 'No pit stops required!'
There's a hanging "orphan" word on this modal that I want to get rid of:
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop