Skip to content

Fix viewport is scrolled when suggestion list is overscrolled #74807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inimaga merged 3 commits into from
Nov 13, 2025
Merged

Fix viewport is scrolled when suggestion list is overscrolled #74807

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
741cf43
fix viewport is scrolled when suggestion list is overscrolled
bernhardoj Nov 11, 2025
0e45a12
Merge branch 'main' into fix/74596-prevent-scrolling-viewport-when-sc…
bernhardoj Nov 13, 2025
af3d8c1
lint
bernhardoj Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/AutoCompleteSuggestions/BaseAutoCompleteSuggestions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import ColorSchemeWrapper from '@components/ColorSchemeWrapper';
import PressableWithFeedback from '@components/Pressable/PressableWithFeedback';
import useStyleUtils from '@hooks/useStyleUtils';
import useThemeStyles from '@hooks/useThemeStyles';
import * as DeviceCapabilities from '@libs/DeviceCapabilities';
import {hasHoverSupport} from '@libs/DeviceCapabilities';
import CONST from '@src/CONST';
import type {AutoCompleteSuggestionsPortalProps} from './AutoCompleteSuggestionsPortal';
import type {RenderSuggestionMenuItemProps} from './types';
Expand Down Expand Up @@ -92,7 +92,7 @@ function BaseAutoCompleteSuggestions<TSuggestion>({
<Animated.View
style={[styles.autoCompleteSuggestionsContainer, animatedStyles]}
onPointerDown={(e) => {
if (DeviceCapabilities.hasHoverSupport()) {
if (hasHoverSupport()) {
return;
}
e.preventDefault();
Expand All @@ -108,6 +108,7 @@ function BaseAutoCompleteSuggestions<TSuggestion>({
removeClippedSubviews={false}
showsVerticalScrollIndicator={innerHeight > rowHeight.get()}
extraData={[highlightedSuggestionIndex, renderSuggestionMenuItem]}
style={styles.overscrollBehaviorContain}

@situchan situchan Nov 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using contain instead of none?

@bernhardoj bernhardoj Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use contain so that the default overscroll behavior on the element that we scroll is still preserved while still preventing the scroll chaining.

image

/>
</ColorSchemeWrapper>
</Animated.View>
Expand Down
Loading