Skip to content

[CP Staging] Revert "fix: Revisiting create expense page from confirm details page changes the selected user"#74678

Merged
cristipaval merged 1 commit into
Expensify:mainfrom
situchan:revert-73354-fix/72593
Nov 10, 2025
Merged

[CP Staging] Revert "fix: Revisiting create expense page from confirm details page changes the selected user"#74678
cristipaval merged 1 commit into
Expensify:mainfrom
situchan:revert-73354-fix/72593

Conversation

@situchan

@situchan situchan commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

Explanation of Change

Reverts #73354

Fixed Issues

$ #74629
$ #74664

@codecov

codecov Bot commented Nov 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rc/pages/iou/request/step/IOURequestStepAmount.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...rc/pages/iou/request/step/IOURequestStepAmount.tsx 4.93% <0.00%> (-5.29%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cristipaval cristipaval marked this pull request as ready for review November 10, 2025 09:25
@cristipaval cristipaval requested review from a team as code owners November 10, 2025 09:25
@melvin-bot melvin-bot Bot requested a review from bernhardoj November 10, 2025 09:25
@melvin-bot

melvin-bot Bot commented Nov 10, 2025

Copy link
Copy Markdown

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 10, 2025 09:25
@cristipaval cristipaval merged commit 664bbfb into Expensify:main Nov 10, 2025
26 of 30 checks passed
@cristipaval cristipaval changed the title Revert "fix: Revisiting create expense page from confirm details page changes the selected user" [CP Staging] Revert "fix: Revisiting create expense page from confirm details page changes the selected user" Nov 10, 2025
@melvin-bot melvin-bot Bot added the Emergency label Nov 10, 2025
@melvin-bot

melvin-bot Bot commented Nov 10, 2025

Copy link
Copy Markdown

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@cristipaval cristipaval added CP Staging marks PRs that have been CP'd to staging and removed Emergency labels Nov 10, 2025
@cristipaval

Copy link
Copy Markdown
Contributor

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Straight revert

OSBotify pushed a commit that referenced this pull request Nov 10, 2025
Revert "fix: Revisiting create expense page from confirm details page changes the selected user"

(cherry picked from commit 664bbfb)

(cherry-picked to staging by lakchote)
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.47-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.47-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.48-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.48-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@situchan situchan deleted the revert-73354-fix/72593 branch November 26, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants