[No QA] [Sentry] Enable browser profiling#74448
Conversation
| enableAutoPerformanceTracing: true, | ||
| enableUserInteractionTracing: true, | ||
| integrations: [navigationIntegration], | ||
| integrations: [navigationIntegration, SentryBrowser.browserProfilingIntegration(), SentryBrowser.browserTracingIntegration()], |
There was a problem hiding this comment.
does not not ruin it on mobile platforms?
There was a problem hiding this comment.
🚧 Testing in progress 🚧
There was a problem hiding this comment.
on DEV everything seems to be working. To be tested on Adhoc.
But for the sake of concern separation I can change integrations based on platform. wdyt?
There was a problem hiding this comment.
I tested this and no problem encountered on Android Adhoc and iOS Development. Profiles are still available
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 163 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@parasharrajat @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Merging this one to keep things moving! 🚀 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.49-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.49-0 🚀
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.52-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.52-0 🚀
|
Explanation of Change
This PR enables Sentry's profiling on WEB and destkop.
Fixed Issues
$ #73324
PROPOSAL:
Tests
Repeat for desktop
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
dev_android.mov
adhoc_android.mov
Android: mWeb Chrome
iOS: Native
https://github.com/user-attachments/assets/4c438f98-07dd-47b7-a756-b7d38a7a0582

iOS: mWeb Safari
MacOS: Chrome / Safari
dev_web.mov
adhoc_web.mov
MacOS: Desktop
dev_desktop.mov
adhoc_desktop_2.mov