fix: Distance expense empty chat is scrollable#74354
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I have problems while building on ios. Will add it later |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
|
@dukenv0307 I updated. Could you please to check? Thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-12.at.11.26.24.movAndroid: mWeb ChromeScreen.Recording.2025-11-12.at.11.22.45.moviOS: HybridAppScreen.Recording.2025-11-12.at.11.25.26.moviOS: mWeb SafariScreen.Recording.2025-11-12.at.11.23.12.movMacOS: Chrome / SafariScreen.Recording.2025-11-12.at.11.21.50.movMacOS: DesktopScreen.Recording.2025-11-12.at.11.26.39.mov |
|
Not a product change, and no UI changes |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.2.59-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.2.59-5 🚀
|

Explanation of Change
Fixed Issues
$#73355
PROPOSAL:#73355 (comment)
Tests
Preconditions:
Offline tests
QA Steps
Preconditions:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-11-05.at.23.49.39.mov
Android: mWeb Chrome
android_chorme.mov
iOS: Native
Screen.Recording.2025-11-09.at.15.24.01.mov
iOS: mWeb Safari
ios_safari.mov
MacOS: Chrome / Safari
chorme.mov
MacOS: Desktop
desktop.mov