Skip to content

[CP Staging] Revert "Fix lag on the wide RHP modal opening animation"#74061

Merged
mountiny merged 1 commit into
mainfrom
revert-72580-wide-rhp-animation-lag
Nov 3, 2025
Merged

[CP Staging] Revert "Fix lag on the wide RHP modal opening animation"#74061
mountiny merged 1 commit into
mainfrom
revert-72580-wide-rhp-animation-lag

Conversation

@mountiny

@mountiny mountiny commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

@mountiny mountiny self-assigned this Nov 3, 2025
@mountiny
mountiny requested a review from a team as a code owner November 3, 2025 02:59
@mountiny mountiny mentioned this pull request Nov 3, 2025
Closed
8 tasks
@melvin-bot
melvin-bot Bot requested a review from grgia November 3, 2025 03:00
@melvin-bot

melvin-bot Bot commented Nov 3, 2025

Copy link
Copy Markdown

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team November 3, 2025 03:00
@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #74061.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://74061.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov

codecov Bot commented Nov 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/WideRHPContextProvider/index.tsx 0.00% 2 Missing ⚠️
src/components/Search/index.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...stReportView/MoneyRequestReportTransactionList.tsx 4.21% <ø> (ø)
src/components/Navigation/TopBar.tsx 100.00% <100.00%> (ø)
src/libs/SearchUIUtils.ts 69.86% <100.00%> (ø)
src/components/Search/index.tsx 0.00% <0.00%> (ø)
src/components/WideRHPContextProvider/index.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mountiny
mountiny merged commit 79d30b4 into main Nov 3, 2025
28 of 30 checks passed
@mountiny
mountiny deleted the revert-72580-wide-rhp-animation-lag branch November 3, 2025 12:53
@melvin-bot melvin-bot Bot added the Emergency label Nov 3, 2025
@melvin-bot

melvin-bot Bot commented Nov 3, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Nov 3, 2025
@mountiny

mountiny commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Nov 3, 2025
@mountiny @OSBotify
Merge pull request #74061 from Expensify/revert-72580-wide-rhp-animat…
4d549c6 
…ion-lag

[CP Staging] Revert "Fix lag on the wide RHP modal opening animation"

(cherry picked from commit 79d30b4)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 3, 2025
@OSBotify OSBotify mentioned this pull request Nov 3, 2025
Closed
@OSBotify

OSBotify commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.42-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@JS00001 JS00001 mentioned this pull request Nov 3, 2025
Closed
8 tasks
@OSBotify

OSBotify commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.42-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify

OSBotify commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.43-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MonilBhavsar MonilBhavsar MonilBhavsar approved these changes
@parasharrajat parasharrajat Awaiting requested review from parasharrajat
@grgia grgia Awaiting requested review from grgia

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

App crashes after clicking outside report details RHP opened from Reports > Chats

3 participants

@mountiny @OSBotify @MonilBhavsar