Skip to content

[No QA] Create concierge-avatar-small.svg#74007

Merged
zanyrenney merged 16 commits into
mainfrom
test-image
Nov 11, 2025
Merged

[No QA] Create concierge-avatar-small.svg#74007
zanyrenney merged 16 commits into
mainfrom
test-image

Conversation

@stephanieelliott

@stephanieelliott stephanieelliott commented Nov 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Added small version of Concierge icon to for use on the New Expensify hub

Fixed Issues

Tests

N/A

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-09-23.at.12.41.27.AM.mov
Android: mWeb Chrome
Screen.Recording.2025-09-23.at.12.46.46.AM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-23.at.00.50.53.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-09-23.at.00.54.06.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-10-10.at.1.17.17.AM.mov
Screen.Recording.2025-09-23.at.12.27.18.AM.mov
MacOS: Desktop
Screen.Recording.2025-09-23.at.12.52.20.AM.mov

@stephanieelliott stephanieelliott requested review from a team as code owners November 1, 2025 04:27
@melvin-bot melvin-bot Bot requested review from marcochavezf and removed request for a team November 1, 2025 04:27
@melvin-bot

melvin-bot Bot commented Nov 1, 2025

Copy link
Copy Markdown

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

OSBotify commented Nov 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://f4ea7721.helpdot.pages.dev ⚡️

@marcochavezf marcochavezf removed their request for review November 5, 2025 13:46
@stephanieelliott stephanieelliott requested a review from a team as a code owner November 7, 2025 04:05
@stephanieelliott
Update concierge-avatar-small.svg
9dae5e3 
compressed to pass tests
@melvin-bot melvin-bot Bot requested review from trjExpensify and removed request for a team November 7, 2025 04:05
@dubielzyk-expensify

dubielzyk-expensify commented Nov 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Could we use this instead please 😇 If this is for the hub only

simple-illustration__concierge-bot.svg.zip

@stephanieelliott

stephanieelliott commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

Yay, thanks @dubielzyk-expensify! The image looks great but it's rendering too large. This is the same issue I ran into with concierge-avatar.svg (and why I initially tried creating a -small version). Is there a way to reduce the rendered size of this image in the repo via styling/layout? Or do we need to create a physically smaller version of the SVG file?

image

@dubielzyk-expensify

dubielzyk-expensify commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

Odd. I've not scaled it now, can you see if this works?
simple-illustration__concierge-bot.svg.zip

If not, we might have to add some styling to force it to be 68x68

@zanyrenney zanyrenney self-assigned this Nov 10, 2025
@twisterdotcom

twisterdotcom commented Nov 10, 2025

Copy link
Copy Markdown
Contributor
image

Back in biz.

@zanyrenney

zanyrenney commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Looking gooooood thanks @dubielzyk-expensify !

@zanyrenney zanyrenney self-requested a review November 11, 2025 11:39
@zanyrenney zanyrenney merged commit fc98b03 into main Nov 11, 2025
14 of 15 checks passed
@zanyrenney zanyrenney deleted the test-image branch November 11, 2025 11:46
@OSBotify OSBotify mentioned this pull request Nov 11, 2025
Closed
58 tasks
@cristipaval cristipaval changed the title Create concierge-avatar-small.svg [No QA] Create concierge-avatar-small.svg Nov 11, 2025
@OSBotify

OSBotify commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.2.49-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

OSBotify commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.2.49-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.2.52-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 cancelled 🔪
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/zanyrenney in version: 9.2.52-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 cancelled 🔪
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanyrenney zanyrenney zanyrenney approved these changes
@trjExpensify trjExpensify Awaiting requested review from trjExpensify

Assignees

@stephanieelliott stephanieelliott

@zanyrenney zanyrenney

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stephanieelliott @OSBotify @dubielzyk-expensify @twisterdotcom @zanyrenney