-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[No QA] Send fullstory session id to Sentry #73843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 7 commits into
Expensify:main
from
callstack-internal:feat/sentry-fullstory-session-id
Oct 31, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2d4da6b
Send fullstory session id to Sentry
sosek108 3cab3f1
CONST namespace for telemetry
sosek108 14593a8
Change the way connection to Sentry is done. Outside render loop
sosek108 ca9163b
import fix
sosek108 f166dc3
restore Fullstory checks
sosek108 2845a63
Fix fullstory mock for tests
sosek108 b433a34
add comment on the import
sosek108 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /** | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adhorodyski As you proposed I'll put all connection to external file, where I put all logic to enchance sentry data. I am open to comment on the file name |
||
| * This file contains the logic for sending additional data to Sentry. | ||
| * | ||
| * It uses Onyx.connectWithoutView as nothing here is related to the UI. We only send data to external provider and want to keep this outside of the render loop. | ||
| */ | ||
| import * as Sentry from '@sentry/react-native'; | ||
| import CONST from '@src/CONST'; | ||
| import FS from './Fullstory'; | ||
|
|
||
| /** | ||
| * Connect to FullStory to retrieve session id from it. We want to link FullStory with Sentry for easier debugging. | ||
| */ | ||
| FS.onReady().then(async () => { | ||
| const sessionId = await FS.getSessionId(); | ||
| if (!sessionId) { | ||
| return; | ||
| } | ||
| Sentry.setContext(CONST.TELEMETRY.CONTEXT_FULLSTORY, {sessionId}); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.