72031 fix required description by category by huult · Pull Request #73725 · Expensify/App

huult · 2025-10-29T06:10:28Z

Explanation of Change

Fixed Issues

$ #72031
PROPOSAL: #72031 (comment)

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Prerequisites:
A category is configured with:

Description required = Enabled
Description hint = Added
The workspace has Categories enabled.
The workspace has Rules enabled.

Open the Expensify app.
Create a new expense.
Select a category that requires a description.
Observe the Description field.
Verify that the Description field displays a “Required” label or indicator.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-10-29.at.12.39.22.mov

MacOS: Desktop

Screen.Recording.2025-10-29.at.12.44.10.mov

melvin-bot · 2025-10-29T06:10:34Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2025-10-29T06:18:54Z

@ZhenjaHorbach

I’ve finished implementing the ticket ‘The Description field should display a “Required” label or indicator.’
However, I have a question regarding it.

Should the description field also show an error when submitting a transaction? I didn’t see this in the expected result, but I double-checked and tested it locally.

Screen.Recording.2025-10-29.at.13.17.38.mov

…description-by-category

codecov · 2025-10-31T01:45:03Z

Codecov Report

❌ Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ges/iou/request/step/IOURequestStepDescription.tsx	0.00%	6 Missing ⚠️
src/pages/iou/SplitExpenseEditPage.tsx	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/MoneyRequestConfirmationList.tsx	`66.27% <100.00%> (+0.13%)`	⬆️
.../components/MoneyRequestConfirmationListFooter.tsx	`82.94% <100.00%> (+0.13%)`	⬆️
src/libs/CategoryUtils.ts	`53.44% <100.00%> (+3.44%)`	⬆️
src/pages/iou/SplitExpenseEditPage.tsx	`0.00% <0.00%> (ø)`
...ges/iou/request/step/IOURequestStepDescription.tsx	`0.00% <0.00%> (ø)`

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

huult · 2025-10-31T01:56:08Z

@ZhenjaHorbach #73725 (comment) Please take a look at this comment when you get a chance

huult · 2025-11-03T03:10:47Z

@ZhenjaHorbach

I’ve finished implementing the ticket ‘The Description field should display a “Required” label or indicator.’ However, I have a question regarding it.

Should the description field also show an error when submitting a transaction? I didn’t see this in the expected result, but I double-checked and tested it locally.

Screen.Recording.2025-10-29.at.13.17.38.mov

#73882 It seems we have another ticket to handle this

…description-by-category

ZhenjaHorbach · 2025-11-03T13:47:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-11-03.15.40.51.mov

Android: mWeb Chrome

2025-11-03.15.40.51.mov

iOS: HybridApp

2025-11-03.15.44.11.mov

iOS: mWeb Safari

2025-11-03.15.44.11.mov

MacOS: Chrome / Safari

2025-11-03.15.54.14.mov

MacOS: Desktop

2025-11-03.15.54.14.mov

ZhenjaHorbach · 2025-11-03T14:05:33Z

@ZhenjaHorbach

I’ve finished implementing the ticket ‘The Description field should display a “Required” label or indicator.’ However, I have a question regarding it.

Should the description field also show an error when submitting a transaction? I didn’t see this in the expected result, but I double-checked and tested it locally.

Screen.Recording.2025-10-29.at.13.17.38.mov

Technically, categories are also required
But we can submit expenses without a category
So I think we should do the same with required descriptions

huult · 2025-11-03T14:50:01Z

@ZhenjaHorbach Thanks! This PR is ready for review now

ZhenjaHorbach · 2025-11-03T14:56:28Z

LGTM!

neil-marcellini

Looks good, thank you.

neil-marcellini · 2025-11-04T15:35:39Z

    iouIsReimbursable,
    onToggleReimbursable,
    isReceiptEditable = false,
+    isDescriptionRequired = false,


NAB: Can we set up this flag within this components instead of taking a prop? Not a blocker because I assume that required adding a lot of additional useOnyx calls to this file.

neil-marcellini · 2025-11-04T15:38:13Z

    const isSavedRef = useRef(false);
    useRestartOnReceiptFailure(transaction, reportID, iouType, action);

+    const {policyForMovingExpensesID} = usePolicyForMovingExpenses();


What is this policy for moving expenses thing? Why don't we use the policy directly?

NAB: Oh I see, it's kind of a fall back. Still, I would like to learn more about why this is needed.

neil-marcellini · 2025-11-04T16:49:27Z

+    it('returns true when category has areCommentsRequired set to true regardless of enabled status', () => {
+        expect(isCategoryDescriptionRequired(mockPolicyCategories, 'Office', true)).toBe(true);
+    });


NAB: The name of this test makes it sound like areRulesEnabled should be false, but it's true.

OSBotify · 2025-11-04T17:03:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-04T21:13:56Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.44-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-05T20:07:21Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.44-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

gijoe0295 · 2026-05-25T18:19:17Z

+            if (isDescriptionRequired && !values.moneyRequestComment) {
+                addErrorMessage(errors, INPUT_IDS.MONEY_REQUEST_COMMENT, translate('common.error.fieldRequired'));
+            }


We should not block submission without required description to align with required category/tag cases. Only block when missing merchant. This was also C+ concern here #73725 (comment) that was not resolved.

See Slack discussion in this issue #88707 for details.

huult added 2 commits October 29, 2025 12:28

fix required description by category

d03429d

add code test

b3d7c6c

huult requested a review from a team as a code owner October 29, 2025 06:10

melvin-bot Bot assigned huult Oct 29, 2025

melvin-bot Bot requested a review from ZhenjaHorbach October 29, 2025 06:10

melvin-bot Bot removed the request for review from a team October 29, 2025 06:10

huult added 2 commits October 29, 2025 14:13

remove check rules

b9d9aec

Merge remote-tracking branch 'upstream/main' into 72031-fix-required-…

bfceb31

…description-by-category

Merge remote-tracking branch 'upstream/main' into 72031-fix-required-…

9cc0dd7

…description-by-category

ZhenjaHorbach approved these changes Nov 3, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini November 3, 2025 14:56

neil-marcellini approved these changes Nov 4, 2025

View reviewed changes

neil-marcellini merged commit 8813e2f into Expensify:main Nov 4, 2025
27 checks passed

OSBotify mentioned this pull request Nov 4, 2025

Deploy Checklist: New Expensify 2025-11-04 #74235

Closed

56 tasks

melvin-bot Bot mentioned this pull request Nov 5, 2025

[Due for payment 2025-11-12] [$250] Description field should be marked as Required when selecting a category that enforces a required description #72031

Closed

16 tasks

gijoe0295 reviewed May 25, 2026

View reviewed changes

gijoe0295 mentioned this pull request May 25, 2026

[Due for payment 2026-05-29] [$250] Expenses - Unable to save the expense description field blank when it's required #88707

Closed

7 tasks

Uh oh!

Conversation

huult commented Oct 29, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 29, 2025

Uh oh!

huult commented Oct 29, 2025

Uh oh!

codecov Bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Oct 31, 2025

Uh oh!

huult commented Nov 3, 2025

Uh oh!

ZhenjaHorbach commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huult commented Nov 3, 2025

Uh oh!

ZhenjaHorbach commented Nov 3, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

gijoe0295 May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Oct 31, 2025 •

edited

Loading

ZhenjaHorbach commented Nov 3, 2025 •

edited

Loading

ZhenjaHorbach commented Nov 3, 2025 •

edited

Loading

gijoe0295 May 25, 2026 •

edited

Loading