plural hold expenses message by mukhrr · Pull Request #73717 · Expensify/App

mukhrr · 2025-10-29T03:15:33Z

Explanation of Change

Fixed Issues

$ #73381
PROPOSAL: #73381 (comment)

Tests

The same as QA.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Reports -> Expenses
Select one expense
Click Selected dropdown
Click Hold
- Verify you see "Explain why you're holding these expense." message on top header
Select one more or multiple expenses from checkbox
Click Selected dropdown
Click Hold option
- Verify you see "Explain why you're holding these expenses." message on top header
Repeat steps in IOU chat

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android-mWeb.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2025-10-29T03:15:38Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. If you want to automatically generate translations for other locales, you can run the Generate static translations GitHub workflow.

Please look at the code and make sure there are no malicious changes before running the workflow.

If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-29T03:27:57Z

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/Search/SearchHoldReasonPage.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/pages/iou/HoldReasonFormView.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
src/pages/iou/HoldReasonPage.tsx	`0.00% <ø> (ø)`
src/pages/Search/SearchHoldReasonPage.tsx	`0.00% <0.00%> (ø)`

... and 132 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-30T02:29:33Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2025-10-30T02:30:40Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-10-30T02:32:47Z

LGTM . Thank you for your hard work!

Krishna2323 · 2025-10-30T10:32:35Z

@mukhrr test steps are missing. Also, this is not a layout/style fix so I believe you should add proper recording showing it displays "expense" when selecting a single translation and "expenses" when multiple.

- fixed IOU hold expenses also

mukhrr · 2025-10-30T22:44:20Z

@Krishna2323 it's ready

… across multiple languages

Krishna2323 · 2025-11-03T14:41:28Z

@mukhrr did you followed this to generate the translations?

mukhrr · 2025-11-03T14:44:58Z

@mukhrr did you followed this to generate the translations?

@Krishna2323 I didn't run what it suggests. BUt, yes, I used AI to generate translations

Krishna2323 · 2025-11-03T14:47:29Z

I believe we do need to use the same script. @puneetlath could you please confirm this? @mukhrr I think you should remove the translations from all the file except for the en.

Krishna2323 · 2025-11-03T14:48:49Z

@mukhrr update the tests to also include the changes for the button and header.

Krishna2323 · 2025-11-03T19:32:35Z

@mukhrr update the test steps to also include the changes for the button and header.

Krishna2323 · 2025-11-03T19:35:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the slation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

puneetlath · 2025-11-03T20:14:45Z

Yes, that's correct. That's the method we should be using to generate translations.

mukhrr · 2025-11-04T10:41:47Z

@mukhrr please also remove it from es.ts. Generate static translations will be triggered by @puneetlath. Please ready #73717 (comment)

ah okay. thanks. pushed now

Krishna2323

LGTM! The remaining translations will be added and ESLint will pass once Generate static translations is triggered by @puneetlath.

puneetlath · 2025-11-04T21:58:26Z

Hmm, getting an error when trying to generate translations:

workspace.expensifyCard.cardPending, workspace.card.issueNewCard.inviteNewMember
🧠 Translated to [de]: "Explain why you're holding this expense."
                     → "Erklären Sie, warum Sie diese Ausgabe zurückhalten."
🧠 Translated to [de]: "New report"
                     → "Neuer Bericht"
🧠 Translated to [de]: "Hold expense"
                     → "Ausgabe zurückstellen"
🧠 Translated to [de]: "Hold expenses"
                     → "Ausgaben zurückhalten"
🧠 Translated to [de]: "Explain why you're holding these expenses."
                     → "Erklären Sie, warum Sie diese Ausgaben zurückhalten."
🧠 Translated to [de]: "started settling up. Payment is on hold until ${submitterDisplayName} enables th..."
                     → "mit dem Ausgleich begonnen. Die Zahlung ist ausgesetzt, bis ${submitterDisplayNa..."
🧠 Translated to [de]: "# Let’s get you set up
👋 I’m here to help! To get you started, I’ve tailored yo..."
                     → "# Lassen Sie uns Sie einrichten
👋 Ich bin hier, um zu helfen! Um Ihnen den Eins..."
🧠 Translated to [de]: "to proceed."
                     → "um fortzufahren."
🧠 Translated to [de]: "keep only one card feed"
                     → "Nur einen Karten-Feed beibehalten"
🧠 Translated to [de]: "# Your free trial has started! Let's get you set up.
👋 Hey there, I'm your Expe..."
                     → "# Ihre kostenlose Testversion hat begonnen! Lassen Sie uns alles einrichten.
👋 ..."
🧠 Translated to [de]: "This workspace can't be downgraded because multiple card feeds are connected (ex..."
                     → "Dieser Arbeitsbereich kann nicht herabgestuft werden, da mehrere Kartenfeeds ver..."
🧠 Translated to [de]: "# Your free trial has started! Let's get you set up.
👋 Hey there, I'm your Expe..."
                     → "# Ihre kostenlose Testphase hat begonnen! Lassen Sie uns mit der Einrichtung beg..."
🧠 Translated to [de]: "Enjoy cash back on every US purchase, up to 50% off your Expensify bill, unlimit..."
                     → "Profitiere von Cashback auf jeden Einkauf in den USA, bis zu 50 % Rabatt auf dei..."
/home/runner/work/App/App/scripts/utils/TSCompilerUtils.ts:429
            throw new Error(`Cannot inject into path "${dotPath}": property "${topLevelKey}" exists but is not an object`);
                  ^
Error: Cannot inject into path "holdExpense.one": property "holdExpense" exists but is not an object
    at injectDeepObjectValue (/home/runner/work/App/App/scripts/utils/TSCompilerUtils.ts:429:19)
    at Object.injectDeepObjectValue (/home/runner/work/App/App/scripts/utils/TSCompilerUtils.ts:432:37)
    at Object.newNode (/home/runner/work/App/App/scripts/generateTranslations.ts:934:71)
    at visitWithPath (/home/runner/work/App/App/scripts/utils/TSCompilerUtils.ts:313:31)
    at /home/runner/work/App/App/scripts/utils/TSCompilerUtils.ts:293:16
    at visitNode (/home/runner/work/App/App/node_modules/typescript/lib/typescript.js:95057:19)
    at visitEachChildOfVariableDeclaration (/home/runner/work/App/App/node_modules/typescript/lib/typescript.js:96005:7)
    at Object.visitEachChild (/home/runner/work/App/App/node_modules/typescript/lib/typescript.js:95305:33)
    at visitWithPath (/home/runner/work/App/App/scripts/utils/TSCompilerUtils.ts:310:40)
    at /home/runner/work/App/App/scripts/utils/TSCompilerUtils.ts:293:16
Error: Process completed with exit code 1.

mukhrr · 2025-11-05T06:09:23Z

Hmm, getting an error when trying to generate translations:

@puneetlath I think this is a bug from TSCompilerUtils.ts. I also got this when locally generating script. And had to fix TSCompilerUtils.ts locally after which I can run it successfully.
Did we get success during genrating translations which included such case before?

JmillsExpensify

Out of scope for product reviews, so I'm unsubscribing.

Krishna2323 · 2025-11-06T16:31:36Z

@puneetlath, should we run the script locally and add the translations?

@mukhrr, you were able to successfully run the script locally after fixing the issue and generate the translations, right?

mukhrr · 2025-11-06T17:32:03Z

Yes, previous commit before the last one included those generated translations. I can revert them

mukhrr · 2025-11-06T17:33:21Z

Besides, I think we'd be better fix TSCompilerUtils.ts bug in another issue?! @puneetlath what do you think?!

puneetlath · 2025-11-06T18:21:33Z

Ok, let's do that, thanks.

mukhrr · 2025-11-06T18:25:27Z

Ok, let's do that, thanks.

@puneetlath okay. Could you create an issue and assign me there?! thanks

mukhrr · 2025-11-06T18:26:06Z

@Krishna2323 I am reverting my previous generated translations here

…ation in multiple languages

…pluralization in multiple languages" This reverts commit ca54f37.

…alization across multiple languages

Krishna2323 · 2025-11-06T19:40:06Z

@mukhrr typescript checks are failing.

mukhrr · 2025-11-06T20:14:14Z

@Krishna2323 it's finally ready

Krishna2323 · 2025-11-07T17:59:51Z

@puneetlath this one is ready to be merged 🚀

Krishna2323 · 2025-11-07T18:01:46Z

puneetlath, please let us know if you'd like us to fix this issue. @mukhrr and I can work on it. Thanks!

puneetlath · 2025-11-07T19:31:09Z

Can you raise that bug in the #open-source channel? I don't really understand it.

OSBotify · 2025-11-07T23:46:50Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.2.47-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mukhrr · 2025-11-10T11:11:06Z

npx ts-node ./scripts/generateTranslations.ts --compare-ref main

cannot reproduce it anymore

OSBotify · 2025-11-10T12:01:24Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.47-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

eh2077 · 2026-01-07T15:43:34Z

            onSubmit={onSubmit}
            validate={validate}
            backTo={backTo}
+            expenseCount={selectedTransactionIDs.length}


this change caused

[Due for payment 2026-01-05] [$250] Expense - Title, sub text and below button shows "hold expenses" instead expense #75025

we should remove it.

plural hold expenses message

bfe4a13

melvin-bot Bot assigned mukhrr Oct 29, 2025

Merge remote-tracking branch 'origin' into fix/73381

69989dc

mukhrr marked this pull request as ready for review October 30, 2025 02:30

mukhrr requested a review from a team as a code owner October 30, 2025 02:30

melvin-bot Bot requested a review from Krishna2323 October 30, 2025 02:30

melvin-bot Bot removed the request for review from a team October 30, 2025 02:30

mukhrr mentioned this pull request Oct 30, 2025

[Due for payment 2025-11-17] [$250] Incorrect singular copy when holding multiple expenses #73381

Closed

16 tasks

mukhrr added 2 commits October 31, 2025 02:48

Merge remote-tracking branch 'origin' into fix/73381

5daeda9

- added test case for singular/plural hold expense(s)

5cf1387

- fixed IOU hold expenses also

mukhrr added 3 commits November 2, 2025 12:49

Refactor holdExpense translation to support singular and plural forms…

a372c21

… across multiple languages

+

b0f6e9f

fix prettier

d6a2406

Merge remote-tracking branch 'origin' into fix/73381

54aa784

mukhrr added 2 commits November 4, 2025 05:51

includeed button and title tests

4f1dfc8

translated using script

fc61237

Krishna2323 approved these changes Nov 4, 2025

View reviewed changes

melvin-bot Bot requested a review from puneetlath November 4, 2025 21:33

JmillsExpensify reviewed Nov 5, 2025

View reviewed changes

mukhrr added 4 commits November 6, 2025 23:27

Merge remote-tracking branch 'origin' into fix/73381

97a006a

Refactor holdExpense and explainHold translations to support pluraliz…

ca54f37

…ation in multiple languages

Revert "Refactor holdExpense and explainHold translations to support …

948f90b

…pluralization in multiple languages" This reverts commit ca54f37.

Refactor translations for holdExpense and explainHold to support plur…

ab2d464

…alization across multiple languages

mukhrr added 2 commits November 7, 2025 00:45

+

ec9e2be

+

4931a90

puneetlath approved these changes Nov 7, 2025

View reviewed changes

puneetlath merged commit bca8154 into Expensify:main Nov 7, 2025
27 checks passed

OSBotify mentioned this pull request Nov 7, 2025

Deploy Checklist: New Expensify 2025-11-07 #74626

Closed

48 tasks

eh2077 reviewed Jan 7, 2026

View reviewed changes

Uh oh!

Conversation

mukhrr commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 29, 2025

Uh oh!

codecov Bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 30, 2025

Uh oh!

melvin-bot Bot commented Oct 30, 2025

Uh oh!

github-actions Bot commented Oct 30, 2025

Uh oh!

Krishna2323 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mukhrr commented Oct 30, 2025

Uh oh!

Krishna2323 commented Nov 3, 2025

Uh oh!

mukhrr commented Nov 3, 2025

Uh oh!

Krishna2323 commented Nov 3, 2025

Uh oh!

Krishna2323 commented Nov 3, 2025

Uh oh!

Krishna2323 commented Nov 3, 2025

Uh oh!

Krishna2323 commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

puneetlath commented Nov 3, 2025

Uh oh!

mukhrr commented Nov 4, 2025

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Nov 4, 2025

Uh oh!

mukhrr commented Nov 5, 2025

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Nov 6, 2025

Uh oh!

mukhrr commented Nov 6, 2025

Uh oh!

mukhrr commented Nov 6, 2025

Uh oh!

puneetlath commented Nov 6, 2025

Uh oh!

mukhrr commented Nov 6, 2025

Uh oh!

mukhrr commented Nov 6, 2025

Uh oh!

Krishna2323 commented Nov 6, 2025

Uh oh!

mukhrr commented Nov 6, 2025

Uh oh!

Krishna2323 commented Nov 7, 2025

Uh oh!

Krishna2323 commented Nov 7, 2025

Uh oh!

Uh oh!

puneetlath commented Nov 7, 2025

mukhrr commented Oct 29, 2025 •

edited

Loading

codecov Bot commented Oct 29, 2025 •

edited

Loading

Krishna2323 commented Oct 30, 2025 •

edited

Loading

Krishna2323 commented Nov 3, 2025 •

edited

Loading