Skip to content

fix: scroll to bottom on large paragraph text#7369

Merged
Beamanator merged 1 commit into
Expensify:mainfrom
mdneyazahmad:fix/7351-scroll-on-paste
Jan 28, 2022
Merged

fix: scroll to bottom on large paragraph text#7369
Beamanator merged 1 commit into
Expensify:mainfrom
mdneyazahmad:fix/7351-scroll-on-paste

Conversation

@mdneyazahmad

@mdneyazahmad mdneyazahmad commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

Details

Fixed Issues

$ #7351

Tests

  1. Copy large paragraph text (there should be no image in between) and paste.
  2. The scroll bar should move to the bottom.
  • Verify that no errors appear in the JS console

QA Steps

  1. Same as test step
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-21.at.11.53.16.PM.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mp4

@mdneyazahmad mdneyazahmad requested a review from a team as a code owner January 24, 2022 15:30
@MelvinBot MelvinBot requested review from Beamanator and rushatgabhane and removed request for a team January 24, 2022 15:30
@rushatgabhane

Copy link
Copy Markdown
Member

@mdneyazahmad could you please add video for all platforms

@rushatgabhane

Copy link
Copy Markdown
Member

could you please add video for all platforms

@mdneyazahmad bump :)

@mdneyazahmad

Copy link
Copy Markdown
Contributor Author

@rushatgabhane Sorry for not updating, I got some issues with my macbook. I will upload it soon.

@mdneyazahmad

Copy link
Copy Markdown
Contributor Author

@rushatgabhane Added screenshots

@rushatgabhane rushatgabhane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well. LGTM!
@Beamanator

@Beamanator

Copy link
Copy Markdown
Contributor

Nice work 💪

@Beamanator Beamanator merged commit b93c6d3 into Expensify:main Jan 28, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants