Fix/73240 - The site header partially overlaps the typing indicator and composer error messages when the composer is focused and virtual keyboard is open by dmkt9 · Pull Request #73630 · Expensify/App

dmkt9 · 2025-10-28T12:28:08Z

Explanation of Change

Fixed Issues

$ #73240
PROPOSAL: #73240 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition: user signed in with account A on main testing iOS 26 device and account B on secondary

Open staging.new.expensify.com
Navigate to chat with account B
Tap on the composer to open the virtual keyboard
Start typing on the secondary device where account B is logged in
Look at the typing indicator text below the composer.
Paste the following text into the composer to trigger the error message:

[] Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean ma (creating task message with more than 100 characters)
Verify that the typing indicator and error messages should be fully visible and not overlapped by the site header when the composer is focused and virtual keyboard is open

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

The issue does not occur.

Android: mWeb Chrome

android.chrome.mp4

iOS: Native

The issue does not occur.

iOS: mWeb Safari

iOS 26:

ios.safari.26.mp4

iOS 18:

ios.safari.mp4

MacOS: Chrome / Safari

mac.safari.mp4

MacOS: Desktop

mac.desktop.mp4

…i on iOS 26

melvin-bot · 2025-10-28T12:28:15Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-10-28T12:28:18Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2025-10-28T12:40:13Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/Browser/index.ts	`100.00% <100.00%> (ø)`
src/libs/Browser/index.website.ts	`21.87% <50.00%> (+0.90%)`	⬆️
src/utils/keyboard/index.android.ts	`96.77% <66.66%> (-3.23%)`	⬇️
src/utils/keyboard/index.ts	`95.23% <66.66%> (-4.77%)`	⬇️
src/utils/keyboard/index.website.ts	`0.00% <0.00%> (ø)`
...ardAvoidingView/BaseKeyboardAvoidingView/index.tsx	`0.00% <0.00%> (ø)`
... and 37 files with indirect coverage changes

situchan · 2025-10-28T13:31:02Z

    "react-plaid-link": "3.3.2",
    "react-web-config": "^1.0.0",
    "react-webcam": "^7.1.1",
+    "ua-parser-js": "^1.0.38",


No, as I said, we should get device info from expensify-common, not here.

situchan · 2025-10-28T13:32:35Z

Please raise PR in expensify-common repo which supports iOS 26 detection

dmkt9 · 2025-10-28T14:56:44Z

Please raise PR in expensify-common repo which supports iOS 26 detection

Ah, my bad. I'll submit a PR soon.

…i on iOS 26

situchan · 2025-10-29T18:13:56Z

It's merged. Please bump expensify-common to 2.0.164

…i on iOS 26

dmkt9 · 2025-10-30T03:50:22Z

Thanks for the reminder. I've just bumped expensify-common to version 2.0.164.

situchan · 2025-11-03T13:34:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-11-12.at.10.25.22.PM.mov

iOS 18.6:

Screen.Recording.2025-11-12.at.11.01.23.PM.mov

MacOS: Chrome / Safari

MacOS: Desktop

situchan · 2025-11-03T13:40:52Z

+        };
+
+        return KeyboardUtil.subscribeKeyboardVisibilityChange(handler);
+    }, [sharedValue]);


This is affected on all pages which use KeyboardAvoidingView, right?
We should apply this only to report screen which has composer. Otherwise it will cause regressions on other pages on iOS 26 safari.

That's right.

When I created the PR, I reviewed all the styles applied to BaseKeyboardAvoidingView in the app, and none of them set paddingBottom. So we don't need to worry about our PR overriding any existing paddingBottom.

That said, I still think we should apply the full padding, since in addition to the typing indicator and error messages, there's also the offline indicator. What do you think?

Even though paddingBottom prop is not passed in every KeyboardAvoidingView, animatedStyle is always applied, isn't it?

That's right, but I'm not entirely sure what you mean. The regression has been minimized since we're not overriding any paddingBottom. We still need to apply it globally because of the offline indicator.

Good for offline case but I am afraid QA will report this as regression.

Screen.Recording.2025-11-12.at.10.28.02.PM.mov

situchan · 2025-11-05T15:13:00Z

@dmkt9 please merge main

dmkt9 · 2025-11-06T02:19:11Z

@situchan The main branch has been merged.

situchan · 2025-11-06T19:35:05Z

It doesn't work for me at all.

Screen.Recording.2025-11-07.at.1.34.34.AM.mov

@dmkt9 can you please retest after merging main?

situchan · 2025-11-06T19:48:10Z

    if (browser.name === 'Mobile Safari' && browser.major === '26' && os.name === 'iOS' && os.version === '18.6') {
        osVersion = '26';
    }

On my simulator, os.version is '18.7'
We should fix this condition in expensify-common.

printing navigator.userAgent:

trjExpensify

Looks fine to my eye, but @Expensify/design might want to take a look.

dubielzyk-expensify · 2025-11-07T03:25:46Z

Videos in original post look good to me too 👍 Though if it's not working here then we should have a look

dmkt9 · 2025-11-07T04:30:43Z

@dmkt9 can you please retest after merging main?

@situchan I tested it after merging main, and it works well on my end.

On my simulator, os.version is '18.7'
We should fix this condition in expensify-common.

Sure, I’ll open a PR to fix it. Additionally, I’ve never used an iPhone before, so I’m wondering whether the Safari browser on iPhone can be upgraded to version 26, since I see that my Mac can upgrade Safari to version 26. And I think using the condition >= 18.6 would be appropriate. What do you think?

situchan · 2025-11-07T08:17:56Z

And I think using the condition >= 18.6 would be appropriate. What do you think?

Go ahead and create PR

…i on iOS 26

dmkt9 · 2025-11-12T16:00:02Z

This PR is ready for review.

situchan · 2025-11-12T16:54:16Z

@Expensify/design do you agree to add this bottom padding when show keyboard on other pages to avoid offline indicator being cut off? (This is initial view when focus on input. You can still fully see this indicator after scrolling down manually)

(iOS Safari 26 only)

Before:

After:

The only concern is minor glitch after hiding keyboard

Screen.Recording.2025-11-12.at.10.28.02.PM.mov

dubielzyk-expensify · 2025-11-13T01:05:01Z

Yeah the after looks way better 👍

OSBotify · 2025-11-14T05:38:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-14T18:45:57Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.59-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-19T15:28:42Z

🚀 Deployed to production by https://github.com/grgia in version: 9.2.59-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

dmkt9 added 5 commits October 27, 2025 08:49

Fix - Site header overlaps error messages & typing indicator in Safar…

0336cb8

…i on iOS 26

Fix - Site header overlaps error messages & typing indicator in Safar…

05452bb

…i on iOS 26

Fix - Site header overlaps error messages & typing indicator in Safar…

7dfdfc8

…i on iOS 26

Merge branch 'main' into fix/73240

60f28dc

Fix - Site header overlaps error messages & typing indicator in Safar…

270e4ad

…i on iOS 26

dmkt9 requested a review from a team as a code owner October 28, 2025 12:28

melvin-bot Bot assigned dmkt9 Oct 28, 2025

melvin-bot Bot requested review from situchan and removed request for a team October 28, 2025 12:28

fix lint

085ed9e

situchan reviewed Oct 28, 2025

View reviewed changes

dmkt9 added 2 commits October 28, 2025 22:25

Fix - Site header overlaps error messages & typing indicator in Safar…

04d0344

…i on iOS 26

Merge branch 'main' into fix/73240

d4ff196

dmkt9 added 2 commits October 30, 2025 10:45

Merge branch 'main' into fix/73240

385649e

Fix - Site header overlaps error messages & typing indicator in Safar…

959b545

…i on iOS 26

dmkt9 mentioned this pull request Oct 30, 2025

[$250] Multiline hyperlink is displayed as a single line hyperlink #65618

Closed

8 tasks

situchan reviewed Nov 3, 2025

View reviewed changes

Merge branch 'main' into fix/73240

1d483bf

Merge branch 'main' into fix/73240

3a8d2d6

dmkt9 requested a review from a team as a code owner November 6, 2025 02:18

melvin-bot Bot requested a review from trjExpensify November 6, 2025 02:18

melvin-bot Bot removed the request for review from a team November 6, 2025 02:18

trjExpensify previously approved these changes Nov 6, 2025

View reviewed changes

dmkt9 added 3 commits November 7, 2025 21:13

Merge branch 'main' into fix/73240

57aba21

Merge branch 'main' into fix/73240

512dd03

Fix - Site header overlaps error messages & typing indicator in Safar…

3a33c08

…i on iOS 26

dmkt9 dismissed trjExpensify’s stale review via 3a33c08 November 12, 2025 14:23

situchan approved these changes Nov 13, 2025

View reviewed changes

melvin-bot Bot requested a review from srikarparsi November 13, 2025 03:11

srikarparsi approved these changes Nov 14, 2025

View reviewed changes

srikarparsi merged commit 132727b into Expensify:main Nov 14, 2025
35 of 38 checks passed

OSBotify mentioned this pull request Nov 14, 2025

Deploy Checklist: New Expensify 2025-11-14 #75187

Closed

69 tasks

grgia mentioned this pull request Nov 17, 2025

“User is typing” indicator not showing on Android #75303

Closed

8 tasks

melvin-bot Bot mentioned this pull request Nov 19, 2025

[Due for payment 2025-11-26] [$175] - Chat - Site header overlaps error messages & typing indicator in Safari on iOS 26 #73240

Closed

8 tasks

Uh oh!

Conversation

dmkt9 commented Oct 28, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 28, 2025

Uh oh!

github-actions Bot commented Oct 28, 2025

Uh oh!

codecov Bot commented Oct 28, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

situchan commented Oct 28, 2025

Uh oh!

dmkt9 commented Oct 28, 2025

Uh oh!

situchan commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmkt9 commented Oct 30, 2025

Uh oh!

situchan commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

dmkt9 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

situchan Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

dmkt9 Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

situchan Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

situchan commented Nov 5, 2025

Uh oh!

dmkt9 commented Nov 6, 2025

Uh oh!

situchan commented Nov 6, 2025

Uh oh!

situchan commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify commented Nov 7, 2025

Uh oh!

dmkt9 commented Nov 7, 2025

Uh oh!

situchan commented Nov 7, 2025

Uh oh!

dmkt9 commented Nov 12, 2025

Uh oh!

situchan commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Nov 13, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 14, 2025

Uh oh!

OSBotify commented Nov 14, 2025

codecov Bot commented Oct 28, 2025 •

edited by github-actions Bot

Loading

situchan commented Oct 29, 2025 •

edited

Loading

situchan commented Nov 3, 2025 •

edited

Loading

situchan commented Nov 6, 2025 •

edited

Loading

situchan commented Nov 12, 2025 •

edited

Loading