[CFI] [FAB Follow-up] Replace the GLOBAL_CREATE emoji with a regular "+" in chat intros by JKobrynski · Pull Request #73404 · Expensify/App

JKobrynski · 2025-10-24T08:17:45Z

Explanation of Change

Fixed Issues

$ #72783
PROPOSAL: N/A

Tests

Log into the app
Navigate to a workspace chat
Make sure the GLOBAL_CREATE emoji was replaced with a regular "+" string (check attached screenshot for reference)

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

iOS: Native

MacOS: Chrome / Safari

codecov · 2025-10-24T08:29:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
src/components/ReportWelcomeText.tsx	`86.11% <100.00%> (ø)`

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-24T08:33:33Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2025-10-24T08:42:02Z

@Expensify/design
There is one thing that really bothers me 😄
We are planning to update the emoji also
In that case, does it make sense to update all texts in the project to use a regular + instead of an emoji (which we will update to match the new design soon)?

dannymcclain · 2025-10-24T13:28:04Z

@Expensify/product-pr @Expensify/design what do you think about this comment above? I don't think I really understand why we even created the :global_create: emoji in the first place, so I'm not sure how I feel. I think my personal preference would just be to use text all the time, even if the buttons matched... But that might just be my personal preference.

trjExpensify · 2025-10-24T14:10:15Z

I'm not sure either. I assumed it was because we wanted to include the button in the text instead of saying "click the green plus button?

trjExpensify · 2025-10-24T14:10:23Z

CC: @jamesdeanexpensify maybe

jamesdeanexpensify · 2025-10-24T16:14:19Z

Yeah, I think you're right @trjExpensify. Some more background I found: Vidal was running this in #convert and I think David was helping, too, here: #54643

But agreed, now that the green global create button doesn't exist, a simple update to + seems like the right move.

dubielzyk-expensify · 2025-10-26T23:35:07Z

Yeah. I think the emoji was a cool thing when it was working, but now that it's not green anymore I think it's better to just use a + text string

ZhenjaHorbach · 2025-10-27T08:53:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ZhenjaHorbach · 2025-10-27T09:16:51Z

@JKobrynski
Could you please recheck all updated translations and make sure that we don't use TextWithEmojiFragment?
If this component doesn't have an emoji in text, we don't show text

For example, usePlusButton translation

JKobrynski · 2025-10-27T13:59:22Z

@ZhenjaHorbach updated!

ZhenjaHorbach · 2025-10-28T09:51:54Z

        beginningOfChatHistory: 'This chat is with ',
        beginningOfChatHistoryPolicyExpenseChat: ({workspaceName, submitterDisplayName}: BeginningOfChatHistoryPolicyExpenseChatParams) =>
-            `This is where <strong>${submitterDisplayName}</strong> will submit expenses to <strong>${workspaceName}</strong>. Just use the <emoji>${CONST.CUSTOM_EMOJIS.GLOBAL_CREATE}</emoji> button.`,
+            `This is where <strong>${submitterDisplayName}</strong> will submit expenses to <strong>${workspaceName}</strong>. Just use the <strong>+</strong> button.`,


I rechecked the PR where we added green plus emoji
And I suppose we don't need bold text for +

https://github.com/Expensify/App/pull/68311/files#diff-2a9066512656fa29b1565e362127de5cc11ba95b28f143a9db26f76dc3750785

Friendly bump!

Nice
Thanks!

…-emoji-2

melvin-bot · 2025-10-30T16:03:43Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

JKobrynski · 2025-10-30T16:04:30Z

@ZhenjaHorbach done!

dubielzyk-expensify · 2025-10-31T02:43:09Z

Just realized we have another area where we have the green + emoji. Are we replacing it there as well? This is the empty state when searching so just search for gibberish and it should appear.

JKobrynski · 2025-10-31T10:18:46Z

            emptyResults: {
                title: 'Nothing to show',
-                subtitle: `Try adjusting your search criteria or creating something with the green ${CONST.CUSTOM_EMOJIS.GLOBAL_CREATE} button.`,
+                subtitle: `Try adjusting your search criteria or creating something with the + button.`,


@dubielzyk-expensify to answer your question, yes! We are removing the icon and the word "green" from all translations, as the button is not green anymore.

JKobrynski · 2025-11-03T08:42:14Z

@ZhenjaHorbach is there anything else you'd like me to do here?

ZhenjaHorbach · 2025-11-03T09:15:09Z

LGTM!

mountiny

Thanks!

OSBotify · 2025-11-04T22:20:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-05T20:38:04Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.45-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-06T23:20:37Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

replace global create emoji with a regular + string in translations

3d50073

melvin-bot Bot assigned JKobrynski Oct 24, 2025

JKobrynski marked this pull request as ready for review October 24, 2025 08:33

JKobrynski requested a review from a team as a code owner October 24, 2025 08:33

melvin-bot Bot requested a review from ZhenjaHorbach October 24, 2025 08:33

melvin-bot Bot removed the request for review from a team October 24, 2025 08:33

JKobrynski mentioned this pull request Oct 24, 2025

[Due for payment 2025-11-13] [CFI] [FAB Follow-up] Replace the GLOBAL_CREATE emoji with a regular "+" in chat intros #72783

Closed

remove TextWithEmojiFragment from ReportWelcomeText

ff2ea2b

ZhenjaHorbach reviewed Oct 28, 2025

View reviewed changes

JKobrynski added 2 commits October 30, 2025 17:03

replace bold + with a regular +

81b649f

Merge branch 'main' into JKobrynski/style/72783-replace-global-create…

e92fac7

…-emoji-2

JKobrynski requested a review from ZhenjaHorbach October 30, 2025 16:04

JKobrynski commented Oct 31, 2025

View reviewed changes

ZhenjaHorbach approved these changes Nov 3, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny November 3, 2025 09:15

mountiny approved these changes Nov 4, 2025

View reviewed changes

mountiny merged commit 5c8316a into Expensify:main Nov 4, 2025
30 checks passed

OSBotify mentioned this pull request Nov 5, 2025

Deploy Checklist: New Expensify 2025-11-05 #74371

Closed

79 tasks

Uh oh!

Conversation

JKobrynski commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 24, 2025

Uh oh!

ZhenjaHorbach commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Oct 24, 2025

Uh oh!

trjExpensify commented Oct 24, 2025

Uh oh!

trjExpensify commented Oct 24, 2025

Uh oh!

jamesdeanexpensify commented Oct 24, 2025

Uh oh!

dubielzyk-expensify commented Oct 26, 2025

Uh oh!

ZhenjaHorbach commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JKobrynski commented Oct 27, 2025

Uh oh!

ZhenjaHorbach Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 30, 2025

Uh oh!

JKobrynski commented Oct 30, 2025

Uh oh!

dubielzyk-expensify commented Oct 31, 2025

Uh oh!

JKobrynski Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

dubielzyk-expensify Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

JKobrynski commented Nov 3, 2025

Uh oh!

ZhenjaHorbach commented Nov 3, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Nov 4, 2025

Uh oh!

OSBotify commented Nov 5, 2025

Uh oh!

OSBotify commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

JKobrynski commented Oct 24, 2025 •

edited

Loading

codecov Bot commented Oct 24, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 24, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 27, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 27, 2025 •

edited

Loading

ZhenjaHorbach Oct 28, 2025 •

edited

Loading

ZhenjaHorbach Oct 31, 2025 •

edited

Loading