Upgraded react-native-modal to v13.0.0 - #7333
Merged
Merged
Conversation
MelvinBot
requested review from
puneetlath and
rushatgabhane
and removed request for
a team
January 20, 2022 12:47
rushatgabhane
previously approved these changes
Jan 20, 2022
rushatgabhane
left a comment
rushatgabhane
left a comment
Member
There was a problem hiding this comment.
@puneetlath Tests well on web and mobile, LGTM 🎉
Contributor
|
Just to confirm -- has this PR been tested on all platforms? If not let's make sure to do so. Then I'm happy to merge as otherwise things look good. |
Member
|
@puneetlath Yes, I've tested this PR on all platforms (added safari to my list since it tends to have some quirks of its own). @sig5 please make sure to add screenshots for all platforms for any future PRs. |
puneetlath
approved these changes
Jan 21, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
46 tasks
Contributor
|
🚀 Deployed to staging by @puneetlath in version: 1.1.32-1 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #7293
Tests
Check the JS console
QA Steps
Tested On
Screenshots
Web
New.Expensify.-.Google.Chrome.2022-01-20.17-59-05.mp4
Mobile Web
Desktop
iOS
Android