Skip to content

[No QA] Update Commercial-feeds.md#72939

Merged
sonialiap merged 3 commits into
mainfrom
stephanieelliott-patch-16
Nov 4, 2025
Merged

[No QA] Update Commercial-feeds.md#72939
sonialiap merged 3 commits into
mainfrom
stephanieelliott-patch-16

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Added a helpful keyword but this was opened mostly just to test a zap I am working on.

@stephanieelliott stephanieelliott self-assigned this Oct 20, 2025
@stephanieelliott stephanieelliott requested a review from a team as a code owner October 20, 2025 03:58
@melvin-bot

melvin-bot Bot commented Oct 20, 2025

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @sonialiap

@melvin-bot melvin-bot Bot requested review from sonialiap and removed request for a team October 20, 2025 03:58
@melvin-bot

melvin-bot Bot commented Oct 20, 2025

Copy link
Copy Markdown

@sonialiap Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

title: Commercial Card Feeds
description: Learn how to set up and manage commercial card feeds (Visa, Mastercard, Amex) in Expensify.
keywords: [New Expensify, commercial feed, Mastercard feed, Visa feed, Amex feed, company cards, corporate cards, CDF, VCF, control account]
keywords: [New Expensify, commercial feed, Mastercard feed, Visa feed, Amex feed, company cards, corporate cards, CDF, VCF, GH1025m control account]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keywords violation: The keyword "GH1025m" appears to be a test/random value and doesn't relate to commercial card feeds. Keywords should be relevant search terms that users would actually use to find this article.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephanieelliott should that be GL1025 instead of GH1025m?

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a minimal but purposeful change to the Commercial Card Feeds documentation by adding a specific keyword "GH1025m" to improve searchability. The change appears to be adding a specific identifier or code that users might search for when looking for information about commercial card feeds and control accounts.

Scores Summary

  • Readability: 9/10 - The existing documentation maintains excellent clarity and logical flow. No readability changes were made in this PR.
  • AI Readiness: 8/10 - The addition of the specific keyword "GH1025m" enhances searchability for users who might search using this identifier. The existing document structure with clear headings and metadata is well-optimized for AI parsing.
  • Style Compliance: 9/10 - The change follows proper YAML metadata formatting and maintains consistency with existing keyword structure.

Key Findings

Positive Aspects:

  • The existing document demonstrates excellent HelpDot compliance with clear headings, step-by-step instructions, and proper formatting
  • Well-structured FAQ section addresses common user questions
  • Proper use of markdown formatting, bullet points, and numbered lists
  • Good use of descriptive headings that include full feature names
  • Clear visual hierarchy with appropriate heading levels (# and ##)
  • Screenshots are properly referenced with descriptive alt text

The Change:

  • Adding "GH1025m" keyword appears to be a targeted improvement for search discoverability
  • The keyword is logically placed alongside related terms like "control account"
  • Maintains proper YAML array formatting

Recommendations

  • Approved: This minor enhancement improves searchability without affecting the high-quality existing content
  • Suggestion: Consider documenting what "GH1025m" represents if it's a commonly referenced identifier that users might encounter

Files Reviewed

  • docs/articles/new-expensify/connect-credit-cards/Commercial-feeds.md - ✅ Minor keyword enhancement to already high-quality documentation

Note: This PR makes only a single-line metadata change. The existing documentation maintains excellent quality standards with clear instructions, proper formatting, and comprehensive coverage of commercial card feed setup across all major providers.

@github-actions github-actions Bot changed the title Update Commercial-feeds.md [No QA] Update Commercial-feeds.md Oct 20, 2025
@OSBotify

OSBotify commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://e66db979.helpdot.pages.dev ⚡️

Updated articles:

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a minimal change to the Commercial Card Feeds documentation by adding a test keyword ("GH1025m") to the YAML frontmatter. While the change itself is small, the existing documentation demonstrates high quality standards and serves as a good baseline for evaluation.

Scores Summary

  • Readability: 9/10 - Clear, well-structured content with logical flow and appropriate reading level
  • AI Readiness: 8/10 - Good metadata structure with descriptive headings, though the test keyword reduces relevance
  • Style Compliance: 9/10 - Excellent adherence to Expensify documentation standards and voice

Key Findings

  • Positive Aspects:

    • Excellent document structure with clear hierarchical organization
    • Comprehensive step-by-step instructions for three major card providers
    • Proper use of Markdown formatting and visual elements
    • Well-written FAQ section addressing common user concerns
    • Consistent terminology usage ("workspace," "Control plan," etc.)
  • Minor Concerns:

    • The added test keyword "GH1025m" appears to be non-functional metadata that should be removed before merge
    • Step numbering inconsistency in Amex section ("3." appears twice on lines 70-71)

Recommendations

  • Priority Actions:

    • Remove the test keyword "GH1025m" from the keywords array before merging to production
    • Fix the duplicate step numbering in the Amex Corporate Card Feed section
  • Suggestions for Enhancement:

    • Consider adding more specific keywords related to commercial feed setup processes
    • The document could benefit from a troubleshooting section beyond the current FAQ

Files Reviewed

  • docs/articles/new-expensify/connect-credit-cards/Commercial-feeds.md - Well-structured documentation with minor formatting issue and test keyword

Technical Assessment

The underlying documentation is comprehensive and user-friendly, covering all three major commercial card feed providers with detailed setup instructions. The writing quality is professional and matches Expensify's documentation standards. The test nature of this PR means the actual content changes are minimal, but the existing content serves as an excellent example of quality HelpDot documentation.

Note: This appears to be a test PR as mentioned in the description. The test keyword should be removed before any production deployment.

title: Commercial Card Feeds
description: Learn how to set up and manage commercial card feeds (Visa, Mastercard, Amex) in Expensify.
keywords: [New Expensify, commercial feed, Mastercard feed, Visa feed, Amex feed, company cards, corporate cards, CDF, VCF, control account]
keywords: [New Expensify, commercial feed, Mastercard feed, Visa feed, Amex feed, company cards, corporate cards, CDF, VCF, GH1025m control account]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyword clarity violation: The keyword "GH1025m" appears to be an internal code or reference that wouldn't be meaningful to users searching for help. Keywords should be user-friendly terms that people would actually search for. Consider using more descriptive terms like "account number" or "account identifier" instead.

@stephanieelliott

Copy link
Copy Markdown
Contributor Author

@sonialiap can you merge plz?

@sonialiap

Copy link
Copy Markdown
Contributor

@stephanieelliott is GH1025m correct? Or should that be GL1025?

#72939 (comment)

@sonialiap sonialiap merged commit c9fad35 into main Nov 4, 2025
12 of 13 checks passed
@sonialiap sonialiap deleted the stephanieelliott-patch-16 branch November 4, 2025 21:52
@melvin-bot melvin-bot Bot added the Emergency label Nov 4, 2025
@melvin-bot

melvin-bot Bot commented Nov 4, 2025

Copy link
Copy Markdown

@sonialiap looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

OSBotify commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/sonialiap in version: 9.2.45-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.45-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants