[No QA] Update Connect-To-QuickBooks-Desktop.md#72662
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@stephanieelliott Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a helpful FAQ section addressing terminal server installation requirements for QuickBooks Desktop and Web Connector. The addition fills a specific technical gap and provides practical guidance for users in enterprise environments with file server/client setups. Scores Summary
Key FindingsStrengths:
Areas for Improvement:
RecommendationsPriority Actions:
Suggestions for Enhancement:
Files Reviewed
Note: This is a valuable addition to the documentation that addresses a legitimate user need in enterprise environments. The content is technically accurate and well-structured. Overall Quality Score: 8/10 - Solid documentation improvement with minor refinements needed. |
|
A preview of your ExpensifyHelp changes have been deployed to https://06125f8c.helpdot.pages.dev ⚡️ Updated articles: |
|
Preview looks good. |
|
Closing and reopening to run new test: Validate Github Actions and Workflows |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/kadiealexander in version: 9.2.48-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.48-1 🚀
|
Explanation of Change
Adding in FAQ for terminal server install
Fixed Issues
https://github.com/Expensify/Expensify/issues/549114
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.