feat: allow users to change user created workspace room avatar by samranahm · Pull Request #72446 · Expensify/App

samranahm · 2025-10-13T11:13:35Z

Explanation of Change

Workspace member was not able to edit the room avatar, this PR introduce AvatarWithImagePicker in RoomHeaderAvatars to let non anonymous user to change room avatar.

Fixed Issues

$ #65210
PROPOSAL: #65210 (comment)

Tests

Precondition:

Create workspace and invite invite some member on workspace
Create workspace room

[Admin]

Open workspace room
Click header to open report detail page
Verify you can edit room avatar
Edit room avatar
Verify system message appear changed the room avatar
Open report detail page and remove the room avatar
Verify room avatar is workspace avatar and system message is removed the room avatar
Verify LHN alternate text is You: removed the room avatar

[Workspace member]

Open workspace room that admin or any other user created
Click header to open report detail page
Verify you can't edit room avatar until you're a participant on that room
Send a message to room chat
Open report detail page upload and remove the avatar
Verify log message appear and it's correct for all other room members

[Non Workspace member]

Open a public room where you're not a member on workspace
Participate with chat in room
Open report detail page and verify you can't edit room avatar

[An Auditor]

Admin invite a user as auditor
Auditor open a workspace room
Participate on room
Open workspace report detail page and verify you can't edit room avatar

Verify that no errors appear in the JS console

Offline tests

Open workspace room
Upload image to edit room avatar
Verify room avatar successfully updated
Verify system message appear changed the room avatar
Remove room avatar
Verify avatar removed and system message appear removed the room avatar

QA Steps

Same as test

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.native.mp4

Android: mWeb Chrome

Android.mWeb.chrome.mp4

iOS: Native

iOS: mWeb Safari

IOS.mWeb.safari.mp4

MacOS: Chrome / Safari

macOS.chrome.mp4

MacOS: Desktop

Desktop.mp4

codecov · 2025-10-13T11:30:59Z

Codecov Report

❌ Patch coverage is 36.50794% with 40 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/RoomHeaderAvatars.tsx	0.00%	12 Missing ⚠️
src/libs/ReportActionsUtils.ts	12.50%	7 Missing ⚠️
src/libs/ReportUtils.ts	53.84%	6 Missing ⚠️
src/libs/actions/Report.ts	68.75%	5 Missing ⚠️
...lScreen/routes/report/ReportAvatarModalContent.tsx	0.00%	4 Missing ⚠️
...ges/home/report/ContextMenu/ContextMenuActions.tsx	0.00%	2 Missing ⚠️
src/components/AvatarWithImagePicker.tsx	0.00%	1 Missing ⚠️
src/libs/OptionsListUtils/index.ts	50.00%	1 Missing ⚠️
src/libs/SidebarUtils.ts	50.00%	1 Missing ⚠️
src/pages/ReportDetailsPage.tsx	50.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.71% <ø> (ø)`
src/components/AvatarButtonWithIcon.tsx	`100.00% <100.00%> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/pages/workspace/WorkspaceOverviewPage.tsx	`0.00% <ø> (ø)`
src/components/AvatarWithImagePicker.tsx	`3.84% <0.00%> (-0.08%)`	⬇️
src/libs/OptionsListUtils/index.ts	`71.92% <50.00%> (-0.04%)`	⬇️
src/libs/SidebarUtils.ts	`80.57% <50.00%> (-0.14%)`	⬇️
src/pages/ReportDetailsPage.tsx	`58.94% <50.00%> (-0.06%)`	⬇️
...ges/home/report/ContextMenu/ContextMenuActions.tsx	`0.91% <0.00%> (-0.01%)`	⬇️
...lScreen/routes/report/ReportAvatarModalContent.tsx	`5.00% <0.00%> (-1.25%)`	⬇️
... and 4 more

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…Building

…orkspaceOverviewPage

…-66883-65210/edit-room-avatar git commit --no-edit :wq

s77rt · 2025-10-22T12:04:26Z

@samranahm Can you update this to use UpdateRoomAvatar instead of UpdatePolicyRoomAvatar. cc @Beamanator this is to align with other auth commands e.g. UpdateRoomDescription

samranahm · 2025-10-22T13:33:16Z

Fair point, I'll update it shortly along with system message.

s77rt · 2025-10-22T13:59:03Z

For the system message, it's going to be a new report action of type UPDATEROOMAVATAR. You can use UPDATEROOMDESCRIPTION as a ref

s77rt · 2025-10-22T14:08:18Z

Also now the command accepts another parameter reportActionID which is the report action id for the new system message (pass an optimistic id)

samranahm · 2025-10-22T15:21:41Z

Got it

s77rt · 2025-10-22T18:24:01Z

Regarding permission, only room participants who are also workspace members can change the avatar, so for example if you invited someone to a room but they are not a a workspace member then they shouldn't see the option to change the avatar.

This is also to align with room description changes. Let me know if you have any questions

samranahm · 2025-10-22T18:35:31Z

That is indeed a practical solution. I'll update this PR ASAP.

…it-room-avatar

samranahm · 2025-10-23T12:16:55Z

@s77rt can you confirm if BE is now accepting UpdateRoomAvatar instead of UpdatePolicyRoomAvatar

s77rt · 2025-10-23T18:23:15Z

Not yet, the relevant PRs are not merged yet

samranahm · 2025-10-23T19:14:52Z

Alright, I have updated the name here.
System message is ready, just need to test before pushing once BE PRs merged.

…it-room-avatar

s77rt · 2025-10-27T21:05:17Z

Small update regarding permission: auditors can't change the avatar (even though they are effectively policy members and even if they are participants in the room)

s77rt · 2025-10-27T21:05:46Z

BE PR hit production couple of hours ago so you should be able to test

Edit: Ah actually we are waiting on another PR too

melvin-bot · 2025-10-28T12:48:42Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

samranahm · 2025-10-28T13:17:18Z

Waiting for Web-Expensify, will push the system message right after it.

eh2077

I think we need to build optimistic system message for changing room avatar, right?

eh2077 · 2025-10-29T03:36:06Z

+    /** The name associated with avatar */
+    name?: string;


Why this is needed?

@eh2077 When we upload the avatar offline and refresh the page we get workspace default icon and that default icon should be workspace name's first letter but it's fallBack workspace building icon. So we are passing workspace name to get correct workspace icon.

…atar

…e text from report

melvin-bot · 2025-10-30T13:11:05Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

samranahm · 2025-10-30T15:25:29Z

@eh2077 PR ready, please take a look.

eh2077 · 2025-10-30T16:06:25Z

+        onyxMethod: Onyx.METHOD.MERGE,
+        key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`,
+        value: {
+            [optimisticAction.reportActionID]: {pendingAction: null},


Need to clear pending action from failureData too?

Agree, we should clear pending action from failureData too.

eh2077 · 2025-10-30T16:14:13Z

+                text: avatarUrl ? `changed room avatar` : 'removed the room avatar',
+                html: avatarUrl ? `<muted-text>changed room avatar</muted-text>` : '<muted-text>removed the room avatar</muted-text>',


I think this should be fine as translateLocal is deprecated.

eh2077 · 2025-10-31T15:36:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-31.at.11.55.05.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-31.at.11.53.44.PM.mov

iOS: HybridApp

Screen.Recording.2025-10-31.at.11.53.20.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-10-31.at.11.48.00.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-31.at.11.41.24.PM.mov

MacOS: Desktop

Screen.Recording.2025-10-31.at.11.56.55.PM.mov

eh2077

LGTM 🚀

Beamanator

Loving it 👍

samranahm · 2025-10-31T18:18:56Z

@Beamanator This turned out to be a pretty deep one. If appropriate, maybe we could consider increasing the bounty?

OSBotify · 2025-10-31T21:46:02Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.2.42-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

eh2077 · 2025-11-01T03:14:31Z

+        if (isUserCreatedPolicyRoom(report)) {
+            return {
+                source: report?.avatarUrl ? getFullSizeAvatar(report.avatarUrl, 0) : undefined,
+                headerTitle: getReportName(report),
+                isWorkspaceAvatar: false,
+            };
+        }


@samranahm these lines might be related to the deployment blocker. Can you take a look please? Thanks

OSBotify · 2025-11-03T22:39:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.42-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Krishna2323 · 2025-12-30T09:29:31Z

+                    errors={report.errorFields?.avatar ?? null}
+                    errorRowStyles={styles.mt6}
+                    onErrorClose={() => clearAvatarErrors(report.reportID)}
+                    style={[styles.w100, styles.mb3, styles.alignItemsStart, styles.sectionMenuItemTopDescription]}


Adding styles.sectionMenuItemTopDescription caused this alignment issue: #76647. That style seemed unnecessary so we have remove that in this PR: #77394

More details in this proposal: #76647 (comment)

Revert "[CP Staging] Revert "feat: allow users to change room avatar""

51353d1

melvin-bot Bot assigned samranahm Oct 13, 2025

fix: prevent anonymous (not logged-in) users from editing room avatar

7a4a421

samranahm mentioned this pull request Oct 13, 2025

[Due for payment 2025-11-11] [$500] Can't edit room avatar #65210

Closed

16 tasks

samranahm added 3 commits October 13, 2025 20:19

fix: default WorkspaceAvatar to use first letter instead of Workspace…

015993b

…Building

fix: pass policyName to display correct default Workspace avatar in W…

90a6bc1

…orkspaceOverviewPage

Merge remote-tracking branch 'upstream/main' into revert-72436-revert…

d584102

…-66883-65210/edit-room-avatar git commit --no-edit :wq

Merge branch 'Expensify:main' into revert-72436-revert-66883-65210/ed…

eebb50f

…it-room-avatar

samranahm closed this Oct 23, 2025

samranahm deleted the revert-72436-revert-66883-65210/edit-room-avatar branch October 23, 2025 11:26

samranahm restored the revert-72436-revert-66883-65210/edit-room-avatar branch October 23, 2025 11:27

samranahm reopened this Oct 23, 2025

fix: change command name to UpdateRoomAvatar

67ee603

Merge branch 'Expensify:main' into revert-72436-revert-66883-65210/ed…

08c697b

…it-room-avatar

update can edit room avatar permissions

e5cf954

samranahm marked this pull request as ready for review October 28, 2025 12:48

samranahm requested a review from a team as a code owner October 28, 2025 12:48

melvin-bot Bot requested review from eh2077 and removed request for a team October 28, 2025 12:48

lint

be630fd

eh2077 reviewed Oct 29, 2025

View reviewed changes

samranahm added 6 commits October 30, 2025 00:47

Merge branch 'main' into revert-72436-revert-66883-65210/edit-room-av…

864cde7

…atar

fix merge conflict

4c5c737

feat: add room avatar updated log message in all locals

25e40b1

add getRoomAvatarUpdatedMessage util to get the message accordingly

9167f5e

build optimistic room avatar updated report action

4fc58be

use getRoomAvatarUpdatedMessage to get alternate text and last messag…

82325e8

…e text from report

update canEditRoomAvatar to check current user in participants

24a56d4

eh2077 reviewed Oct 30, 2025

View reviewed changes

clear pending action from failure data

332d571

eh2077 approved these changes Oct 31, 2025

View reviewed changes

melvin-bot Bot requested a review from Beamanator October 31, 2025 16:00

Beamanator approved these changes Oct 31, 2025

View reviewed changes

Beamanator merged commit ef2def5 into Expensify:main Oct 31, 2025
29 checks passed

OSBotify mentioned this pull request Oct 31, 2025

Deploy Checklist: New Expensify 2025-10-31 #73985

Closed

mitarachim mentioned this pull request Nov 1, 2025

[Due for payment 2025-11-11] Room - Room avatar is blank when viewed as invited room member #74000

Closed

8 tasks

eh2077 reviewed Nov 1, 2025

View reviewed changes

Krishna2323 mentioned this pull request Dec 10, 2025

[Due for payment] [$250] Avatar - "Size Error" message overlaps with highlight from "Room Name" #76647

Closed

8 tasks

Krishna2323 reviewed Dec 30, 2025

View reviewed changes

		text: avatarUrl ? `changed room avatar` : 'removed the room avatar',
		html: avatarUrl ? `<muted-text>changed room avatar</muted-text>` : '<muted-text>removed the room avatar</muted-text>',

Uh oh!

Conversation

samranahm commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

s77rt commented Oct 22, 2025

Uh oh!

samranahm commented Oct 22, 2025

Uh oh!

s77rt commented Oct 22, 2025

Uh oh!

s77rt commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samranahm commented Oct 22, 2025

Uh oh!

s77rt commented Oct 22, 2025

Uh oh!

samranahm commented Oct 22, 2025

Uh oh!

samranahm commented Oct 23, 2025

Uh oh!

s77rt commented Oct 23, 2025

Uh oh!

samranahm commented Oct 23, 2025

Uh oh!

s77rt commented Oct 27, 2025

Uh oh!

s77rt commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 28, 2025

Uh oh!

samranahm commented Oct 28, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

samranahm Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 30, 2025

Uh oh!

samranahm commented Oct 30, 2025

Uh oh!

eh2077 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

samranahm Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

samranahm commented Oct 13, 2025 •

edited

Loading

codecov Bot commented Oct 13, 2025 •

edited

Loading

s77rt commented Oct 22, 2025 •

edited

Loading

s77rt commented Oct 27, 2025 •

edited

Loading

eh2077 commented Oct 31, 2025 •

edited

Loading