Skip to content

Update translation for spanish#7226

Merged
Gonals merged 3 commits into
mainfrom
amal-policy-rooms-translation-update
Jan 14, 2022
Merged

Update translation for spanish#7226
Gonals merged 3 commits into
mainfrom
amal-policy-rooms-translation-update

Conversation

@TomatoToaster

@TomatoToaster TomatoToaster commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

CC: @jasperhuangg @iwiznia

Details

Updating the spanish translations to be more accurate (Didn't make it to the original PR). Also changing the notification preference we show users to be "Immediately" instead of "Always" (we don't have to change the code) because it's more grammatically correct.

Fixed Issues

related to Expensify/Expensify#176851
Follow up from https://expensify.slack.com/archives/C21FRDWCV/p1641490225006000

Tests/QA Steps

  • Verify that no errors appear in the JS console
  1. Make sure you have spanish as your set language to test this
  2. Click the green plus on the bottom left, create a new Room. If you already have a room, you can use that
  3. Click on the icon in the Header of the room chat and then click on Settings
  4. Verify that the Notifications section now match the screenshot below.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@TomatoToaster TomatoToaster self-assigned this Jan 14, 2022
@TomatoToaster
TomatoToaster marked this pull request as ready for review January 14, 2022 16:19
@TomatoToaster
TomatoToaster requested a review from a team as a code owner January 14, 2022 16:19
@MelvinBot
MelvinBot requested review from Gonals and removed request for a team January 14, 2022 16:19
@Gonals
Gonals merged commit c5cc746 into main Jan 14, 2022
@Gonals
Gonals deleted the amal-policy-rooms-translation-update branch January 14, 2022 17:28
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.29-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants