Skip to content

[CP Staging] Revert "Implement confirmation message when toggling off approvals"#72101

Merged
mountiny merged 1 commit into
mainfrom
revert-71555-fix/71336
Oct 8, 2025
Merged

[CP Staging] Revert "Implement confirmation message when toggling off approvals"#72101
mountiny merged 1 commit into
mainfrom
revert-71555-fix/71336

Conversation

@lakchote

@lakchote lakchote commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Reverts #71555

Fixes blocker #72087

@lakchote lakchote self-assigned this Oct 8, 2025
@lakchote lakchote requested a review from a team as a code owner October 8, 2025 14:12
@melvin-bot melvin-bot Bot requested review from Gonals and removed request for a team October 8, 2025 14:13
@melvin-bot

melvin-bot Bot commented Oct 8, 2025

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 8054eae7..b969c9ce 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1106,7 +1106,7 @@ const translations = {
         totalAmountGreaterThanOriginal: ({amount}: TotalAmountGreaterOrLessThanOriginalParams) => `Het totale bedrag is ${amount} meer dan de oorspronkelijke uitgave.`,
         totalAmountLessThanOriginal: ({amount}: TotalAmountGreaterOrLessThanOriginalParams) => `Het totale bedrag is ${amount} minder dan de oorspronkelijke uitgave.`,
         splitExpenseZeroAmount: 'Voer een geldig bedrag in voordat u doorgaat.',
-        splitExpenseOneMoreSplit: 'Geen splitsing toegevoegd. Voeg er ten minste \u00E9\u00E9n toe om op te slaan.',
+        splitExpenseOneMoreSplit: 'Geen splitsing toegevoegd. Voeg er ten minste één toe om op te slaan.',
         splitExpenseCannotBeEditedModalTitle: 'Deze uitgave kan niet worden bewerkt',
         splitExpenseCannotBeEditedModalDescription: 'Goedgekeurde of betaalde uitgaven kunnen niet worden bewerkt',
         splitExpenseEditTitle: ({amount, merchant}: SplitExpenseEditTitleParams) => `Bewerk ${amount} voor ${merchant}`,

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert, straight to jail

@mountiny mountiny merged commit c877625 into main Oct 8, 2025
22 of 24 checks passed
@mountiny mountiny deleted the revert-71555-fix/71336 branch October 8, 2025 14:14
@melvin-bot melvin-bot Bot added the Emergency label Oct 8, 2025
@melvin-bot

melvin-bot Bot commented Oct 8, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Oct 8, 2025
@mountiny

mountiny commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Straight revert

@lakchote lakchote removed the request for review from Gonals October 8, 2025 14:15
OSBotify pushed a commit that referenced this pull request Oct 8, 2025
[CP Staging] Revert "Implement confirmation message when toggling off approvals"

(cherry picked from commit c877625)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 8, 2025
@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.27-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.28-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants