-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Navigate to expense detail page after adding a receipt #71818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
773b3aa
recreated a previous Pr and attempt to fix the issue with redirecting…
kubabutkiewicz 841c415
Merge branch 'main' of github.com:callstack-internal/Expensify-App in…
kubabutkiewicz 2d6c9e2
fix: update navigation state handling in IOURequestStepScan to use fi…
kubabutkiewicz 98ce645
remove native file for shouldOpenLastVisitedPath as its the same as i…
kubabutkiewicz fe2f940
Merge branch 'main' of github.com:callstack-internal/Expensify-App in…
kubabutkiewicz 11249bb
Merge branches 'main' and 'fix-70920' of github.com:callstack-interna…
kubabutkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'd like to make sure about this part :)
Why do we need to save it here? Can't we save it when we open this page like it's done in
parseAndLogRoute?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its added because we are trying to fix the issue when you are going to change some permissions in the OS settings then app navigation state is reset and user is navigated to Inbox. this is for saving the navigation state before doing that to be able then to navigate to the screen which user was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I understand that part. I'm just wondering if we can save this information earlier. Now,
saveCurrentPathBeforeBackgroundwill be called every time the app goes to the background. Is the navigation state different when we go to the background and when we're on the scanned receipt screen?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
CONST.EXCLUDE_FROM_LAST_VISITED_PATHhas been modified, soupdateLastVisitedPathwon't be called inparseAndLogRoutewhen we're on this page