feat: Secure Onyx export#70059
Conversation
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mountiny Are you going to create an issue for this so I can link it or should I just leave it empty? |
|
@MrMuzyk can you please merge main to fix the tests? @hoangzinh you can review now please |
|
@MrMuzyk LGTM, let's discard the change from Mobile Expensify 😄 |
|
Yup, on it. I had to also update the test ^^ |
|
Weird bug when I imported Onyx state, double left bar, I'll check on main if it's also reproducible Screen.Recording.2025-09-10.at.09.04.26.mov |
|
Nevermind, it looks like my local issue. I clean caches and it's gone. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromemChrome.moviOS: HybridAppios.moviOS: mWeb SafariSaf.movMacOS: Chrome / SafariChrome.movMacOS: DesktopDesk.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.9-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.11-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀
|
Explanation of Change
Fixed Issues
$ #70107
PROPOSAL:
Slack link to proposal
Tests
Same as QA steps
Offline tests
QA Steps
keysToMaskvariable should now be masked when user opens exported onyx .txt filePR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
masked.android.native.mp4
Android: mWeb Chrome
masked.android.web.mp4
iOS: Native
masked.native.ios.mp4
iOS: mWeb Safari
masked.web.ios.mp4
MacOS: Chrome / Safari
masked.onyx.state.mov
MacOS: Desktop
masked.desktop.mp4