[No QA] Deprecate backTo#69756
Conversation
e041633 to
66f6f71
Compare
|
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Refactor PR, doesn’t have any new product considerations. Removing the tag and unsubscribing myself. |
|
@allroundexperts bump 😄 |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2025-09-08.at.2.09.30.AM.mov |
allroundexperts
left a comment
There was a problem hiding this comment.
Looks good. I noticed a few new cases on main, so please merge main and resolve them before merging this in.
|
@allroundexperts done |
mountiny
left a comment
There was a problem hiding this comment.
Thanks! @adamgrzybowski
Should we create more documentation for how to avoid using the backTo param cc @jmusial too
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.3-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.5-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.8-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀
|
Explanation of Change
We concluded that the
backTois overused and unnecessary in most cases.This PR adds an ESLint rule to block new use cases of screens with
backToparams. Old use cases will have exceptions, but the long term goal is to reduce them as well.Fixed Issues
$ #67284
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
NO QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop