Support switching between transactions without transaction threads using arrows in the header by VickyStash · Pull Request #69648 · Expensify/App

VickyStash · 2025-09-02T12:34:49Z

Explanation of Change

Fixed Issues

$ #67887
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Turn on noOptimisticTransactionThreads beta
In the troubleshoot section turn on Block transaction thread report creation toggle (you can also turn it on in the troubleshoot modal CMD + D)
Open any 1-1 chat and create several expenses.
Open one of them.
Make sure you can switch between transaction threads using arrows and the transaction threads are created and visible as usual.

Offline tests

Same, as in the Tests section

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…ing arrows in the header

…transactions # Conflicts: # src/components/SelectionList/Search/TransactionGroupListItem.tsx

…transactions

codecov · 2025-10-14T14:03:10Z

Codecov Report

❌ Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...tView/MoneyRequestReportTransactionsNavigation.tsx	0.00%	47 Missing ⚠️
src/libs/actions/TransactionThreadNavigation.ts	0.00%	4 Missing ⚠️
...stReportView/MoneyRequestReportTransactionList.tsx	0.00%	2 Missing ⚠️
...thSections/Search/TransactionGroupListExpanded.tsx	0.00%	2 Missing ⚠️
src/components/MoneyRequestHeader.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/components/MoneyRequestHeader.tsx	`0.63% <0.00%> (+<0.01%)`	⬆️
...stReportView/MoneyRequestReportTransactionList.tsx	`2.64% <0.00%> (ø)`
...thSections/Search/TransactionGroupListExpanded.tsx	`1.26% <0.00%> (ø)`
src/libs/actions/TransactionThreadNavigation.ts	`0.00% <0.00%> (ø)`
...tView/MoneyRequestReportTransactionsNavigation.tsx	`3.27% <0.00%> (-0.89%)`	⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-14T15:20:17Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2025-10-14T16:40:08Z

+        const backTo = Navigation.getActiveRoute();
+        const nextThreadReportID = nextParentReportAction?.childReportID;
+        const navigationParams = {reportID: nextThreadReportID, backTo};
+        e?.preventDefault();


NAB make this the first line of the callback

Updated in f59ea98

roryabraham · 2025-10-14T16:51:12Z

+            const transactionThreadReport = createTransactionThreadReport(parentReport, nextParentReportAction);
+            navigationParams.reportID = transactionThreadReport?.reportID;
+        }
+        requestAnimationFrame(() => Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute(navigationParams), {forceReplace: true}));


Why did you wrap the navigation in requestAnimationFrame? Can you add a comment explaining why?

Added comment in 536cd4d

Overall I added requestAnimationFrame to have the space for the optimistic Onyx updates to be written.

…transactions # Conflicts: # src/components/SelectionListWithSections/Search/TransactionGroupListItem.tsx

hungvu193 · 2025-10-15T14:28:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-15.at.22.23.36.mov

Android: mWeb Chrome

Screen.Recording.2025-10-15.at.22.15.09.mov

iOS: HybridApp

Screen.Recording.2025-10-15.at.22.11.32.mov

iOS: mWeb Safari

Screen.Recording.2025-10-15.at.21.45.22.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desk.mov

Screen.Recording.2025-10-15.at.18.11.03.mov

OSBotify · 2025-10-15T16:06:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-15T23:13:53Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.32-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-16T23:20:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.32-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jjcoffee · 2026-02-11T12:32:57Z

            // to display prev/next arrows in RHP for navigation
-            const sortedSiblingTransactionReportIDs = getThreadReportIDsForTransactions(reportActions, sortedTransactions);
-            setActiveTransactionThreadIDs(sortedSiblingTransactionReportIDs).then(() => {
+            const sortedSiblingTransactionIDs = sortedTransactions.map((transaction) => transaction.transactionID);


Coming from #77286 where we are unable to navigate using the arrows for expenses added to a report (either using the Duplicate option or adding an expense from another account) after an expense has been opened. The solution is to dynamically update when activeTransactionIDs changes, rather than only on opening the RHP.

Support switching between transactions without transaction threads us…

f034188

…ing arrows in the header

melvin-bot Bot assigned VickyStash Sep 2, 2025

Prettier fixes

c28989b

This was referenced Sep 2, 2025

[Due for payment 2025-10-23] Support switching between transactions without transaction threads using arrows in the header #67887

Closed

[Due for payment 2025-11-03] [$125] Do not create optimistic transaction thread report on RequestMoney #58828

Closed

Merge branch 'main' into VickyStash/refactor/67887-switching-between-…

59f3ef3

…transactions # Conflicts: # src/components/SelectionList/Search/TransactionGroupListItem.tsx

VickyStash commented Sep 10, 2025

View reviewed changes

Comment thread src/libs/Permissions.ts Outdated

VickyStash added 3 commits September 10, 2025 09:14

Resolve TODO

a8e0100

Merge branch 'main' into VickyStash/refactor/67887-switching-between-…

9214ff1

…transactions

Update the logic after merging main

6297368

Remove unnecessary code

3623c1f

VickyStash marked this pull request as ready for review October 14, 2025 15:20

VickyStash requested a review from a team as a code owner October 14, 2025 15:20

melvin-bot Bot requested review from hungvu193 and removed request for a team October 14, 2025 15:20

roryabraham reviewed Oct 14, 2025

View reviewed changes

VickyStash added 4 commits October 15, 2025 09:07

Merge branch 'main' into VickyStash/refactor/67887-switching-between-…

d5e65d5

…transactions # Conflicts: # src/components/SelectionListWithSections/Search/TransactionGroupListItem.tsx

Align updates after merging main

35e2aea

Minor improvement

f59ea98

Add comments

536cd4d

hungvu193 reviewed Oct 15, 2025

View reviewed changes

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx Outdated

Simplify the logic

0a38699

hungvu193 approved these changes Oct 15, 2025

View reviewed changes

melvin-bot Bot requested a review from roryabraham October 15, 2025 15:28

hungvu193 mentioned this pull request Oct 15, 2025

[Due for payment 2025-11-14][$250] Review duplicates- Navigation arrows only appear when expense RHP is opened for the first time #72221

Closed

16 tasks

roryabraham approved these changes Oct 15, 2025

View reviewed changes

roryabraham merged commit bb87eaa into Expensify:main Oct 15, 2025
22 of 23 checks passed

OSBotify mentioned this pull request Oct 15, 2025

Deploy Checklist: New Expensify 2025-10-15 #72723

Closed

52 tasks

shubham1206agra mentioned this pull request Oct 20, 2025

[Due for payment 2025-10-30] [$250] Web - Expense - Scroller is briefly displayed when switching between expenses #72736

Closed

8 tasks

jjcoffee reviewed Feb 11, 2026

View reviewed changes

Uh oh!

Conversation

VickyStash commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

codecov Bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 14, 2025

Uh oh!

roryabraham Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hungvu193 commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Oct 15, 2025

Uh oh!

OSBotify commented Oct 15, 2025

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

jjcoffee Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Sep 2, 2025 •

edited

Loading

codecov Bot commented Oct 14, 2025 •

edited

Loading

hungvu193 commented Oct 15, 2025 •

edited

Loading