Skip to content

fix resend button width#6958

Merged
stitesExpensify merged 4 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui/fix-btn-width
Jan 14, 2022
Merged

fix resend button width#6958
stitesExpensify merged 4 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui/fix-btn-width

Conversation

@thesahindia

@thesahindia thesahindia commented Dec 30, 2021

Copy link
Copy Markdown
Member

Details

fixed the changing width of resend link button

Fixed Issues

$ #6893

Tests

QA Steps

  1. Go to login page
  2. Enter Email
  3. Choose forget password

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-15.at.2.38.33.AM.mov

Mobile Web

Screen.Recording.2022-01-15.at.2.37.34.AM.mov

Desktop

Screen.Recording.2022-01-15.at.2.39.47.AM.mov

iOS

Screen.Recording.2022-01-15.at.2.33.07.AM.mov

Android

Screen.Recording.2022-01-15.at.2.34.31.AM.mov

@thesahindia thesahindia requested a review from a team as a code owner December 30, 2021 19:09
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team December 30, 2021 19:09
@rushatgabhane

Copy link
Copy Markdown
Member

Nitpicking here.
The button resizes for Spanish lang.

Screencast.from.05-01-22.06-09-14.AM.+03.mp4

@stitesExpensify

Copy link
Copy Markdown
Contributor

Nitpicking here.
The button resizes for Spanish lang.

I don't think that's nitpicking, I think that's a great catch! Something a lot of people would miss

@thesahindia

Copy link
Copy Markdown
Member Author

For some weird reason the width is not changing after changing the language for the first time. It's working after reloading.

Comment thread src/styles/StyleUtils.js Outdated
@stitesExpensify stitesExpensify merged commit 76b8718 into Expensify:main Jan 14, 2022
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.29-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants