[No QA][Manual distance] Add quick action support for manual distance by dominictb · Pull Request #69390 · Expensify/App

dominictb · 2025-08-27T19:59:43Z

Explanation of Change

Fixed Issues

$ #70499
PROPOSAL:

Tests

Precondition:

manualDistance beta is enabled

Create a manual distance request in a workspace chat
Press FAB
Verify quick action button shows "Track distance" with correct workspace avatar and car left icon
Press the QAB
Verify app opens manual distance request page
Create a map distance request in a workspace chat
Press FAB
Verify quick action button shows "Track distance" with correct workspace avatar and car left icon
Press the QAB
Verify app opens map distance request page

Verify that no errors appear in the JS console

Offline tests

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-09-15.at.13.35.09-compressed.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-09-15.at.13.29.51-compressed.mov

MacOS: Desktop

…p into feat/64849-qab

…eat/64849-qab

neil-marcellini · 2025-09-12T18:56:35Z

I recall that we discussed somewhere that no backend changes are needed at this point. Lmk if that's wrong though.

neil-marcellini · 2025-09-12T19:02:57Z

I updated this PR to link to the new issue specifically for this.

…eat/64849-qab

…ype in quick action flow

melvin-bot · 2025-09-15T02:44:22Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2025-09-16T00:33:29Z

        value: recentServerValidatedWaypoints,
    });

+    if (transaction && (transaction.iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE_MAP || isManualDistanceRequestTransactionUtils(transaction))) {


Why not use a util method for checking if it's a distance map request?

allroundexperts · 2025-09-16T00:35:26Z

+    action: QuickActionName | undefined,
+    lastDistanceExpenseType?: DistanceExpenseType,
+    isManualDistanceTrackingEnabled?: boolean,


Hm... I think it would be better to add these as a object.

Yeah it's already an object parameter:

App/src/libs/actions/QuickActionNavigation.ts

Line 45 in d98c088

function navigateToQuickAction(params: NavigateToQuickActionParams) {

allroundexperts · 2025-09-16T01:18:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-09-16.at.7.30.51.AM.mov

iOS: HybridApp

Screen.Recording.2025-09-16.at.7.29.46.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-09-16.at.7.29.07.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-16.at.7.24.48.AM.mov

MacOS: Desktop

Screen.Recording.2025-09-16.at.7.27.56.AM.mov

allroundexperts

Several NABs, but overall looks good!

…eat/64849-qab

neil-marcellini

Great work, thank you!

neil-marcellini · 2025-09-16T18:54:31Z

+        onyxData?.optimisticData?.push({
+            onyxMethod: Onyx.METHOD.SET,
+            key: ONYXKEYS.NVP_LAST_DISTANCE_EXPENSE_TYPE,
+            value: transaction?.iouRequestType,


NAB: We only need to set this value when IOU request type is manual since map is the default.

Not really important though, and maybe this is more clear

OSBotify · 2025-09-16T19:08:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-19T22:51:15Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.16-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

m-natarajan · 2025-09-19T22:56:45Z

@dominictb @neil-marcellini Is expensifail account manualbeta enabled?

dominictb · 2025-09-22T03:11:48Z

@neil-marcellini This should be Internal QA, right?

neil-marcellini · 2025-09-22T23:34:37Z

No QA, as I modified in the description.

OSBotify · 2025-09-23T19:33:28Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: add quick action support for manual distance

4ddd8fa

melvin-bot Bot assigned dominictb Aug 27, 2025

dominictb mentioned this pull request Aug 27, 2025

[$500] [Due for payment 2025-09-12] Create the distance creation tabs #64849

Closed

dominictb added 2 commits September 4, 2025 01:09

Merge branch 'feat/64849-2' of github.com-dominictb:dominictb/epsf-ap…

c4c5684

…p into feat/64849-qab

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

bcad481

…eat/64849-qab

dominictb changed the title ~~[Manual distance] Add quick action support for manual distance~~ [HOLD BE] [Manual distance] Add quick action support for manual distance Sep 3, 2025

neil-marcellini changed the title ~~[HOLD BE] [Manual distance] Add quick action support for manual distance~~ [Manual distance] Add quick action support for manual distance Sep 12, 2025

dominictb added 3 commits September 15, 2025 09:19

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

d9e06bc

…eat/64849-qab

feat: decide map or manual request type based on lastDistanceExpenseT…

d98c088

…ype in quick action flow

remove redundant changes

3a7e0f5

dominictb marked this pull request as ready for review September 15, 2025 02:44

dominictb requested a review from a team as a code owner September 15, 2025 02:44

melvin-bot Bot requested review from allroundexperts and removed request for a team September 15, 2025 02:44

suppor track case

b15a0a2

allroundexperts reviewed Sep 16, 2025

View reviewed changes

allroundexperts approved these changes Sep 16, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini September 16, 2025 02:35

dominictb added 2 commits September 16, 2025 12:12

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

9f19ce2

…eat/64849-qab

use isMapDistanceRequest util

6c0ce0a

neil-marcellini approved these changes Sep 16, 2025

View reviewed changes

neil-marcellini merged commit 10797e7 into Expensify:main Sep 16, 2025
24 checks passed

OSBotify mentioned this pull request Sep 19, 2025

Deploy Checklist: New Expensify 2025-09-19 #70900

Closed

roryabraham changed the title ~~[Manual distance] Add quick action support for manual distance~~ [No QA][Manual distance] Add quick action support for manual distance Sep 23, 2025

melvin-bot Bot mentioned this pull request Sep 23, 2025

[$250] [Due for payment 2025-09-30] Add quick action button support for manual distance. #70499

Closed

Uh oh!

Conversation

dominictb commented Aug 27, 2025 • edited by neil-marcellini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

neil-marcellini commented Sep 12, 2025

Uh oh!

neil-marcellini commented Sep 12, 2025

Uh oh!

melvin-bot Bot commented Sep 15, 2025

Uh oh!

allroundexperts Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

allroundexperts Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 16, 2025

Uh oh!

OSBotify commented Sep 19, 2025

Uh oh!

m-natarajan commented Sep 19, 2025

Uh oh!

dominictb commented Sep 22, 2025

Uh oh!

neil-marcellini commented Sep 22, 2025

Uh oh!

OSBotify commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dominictb commented Aug 27, 2025 •

edited by neil-marcellini

Loading

allroundexperts commented Sep 16, 2025 •

edited

Loading