fix:68830: clear error on BA confirmation step by Eskalifer1 · Pull Request #69228 · Expensify/App

Eskalifer1 · 2025-08-26T09:52:16Z

Explanation of Change

Fixed Issues

$#68830
PROPOSAL:#68830 (comment)

Tests

Go to Settings > Wallet > Add bank account
Choose a country that has IBAN field to fill (e.g. France)
Fill the IBAN field with the correct format
Fill the bank and holder details with any data
Check the Term of service and click confirm
Verify the error validation Invalid IBAN will appear
Return to the previous step and click Next
Confirm that the error is no longer displayed
Reload the page
Confirm that the error is no longer displayed
Close the RHP and click Add bank account
Select any country
Fill all field with random data test
Verify that the error Invalid IBAN does not appear on the Add bank account confirmation page

Verify that no errors appear in the JS console

Offline tests

No offline tests as related to backend validation

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

68830-android-native.mp4

Android: mWeb Chrome

68830-android-web.mp4

iOS: Native

68139-ios-native.mp4

iOS: mWeb Safari

68830-ios-web.mp4

MacOS: Chrome / Safari

68830-desktop-web.mp4

MacOS: Desktop

68830-Desktop.mp4

melvin-bot · 2025-08-26T09:52:22Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Eskalifer1 · 2025-08-26T09:57:39Z

The PR is ready. I combined two of my solutions: clearing upon returning from the page and clearing errors upon entering the page. I added clearing the error when entering the page, I did this so that after reloading the page, the error would also be cleared (and also, if the user goes to another page via the URL without closing this one, and then clicks “Add Bank account” again, the error will also be cleared). - If the error is cleared only after going back, the error will remain in these two cases when the page is opened again. Added a comment to useEffect.

If you think this is unnecessary and only clearing the error when going back is sufficient, please let me know.

cc: @allroundexperts

allroundexperts · 2025-09-01T02:23:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-09-01.at.7.21.40.AM.mov

iOS: HybridApp

Screen.Recording.2025-09-01.at.7.19.56.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-09-01.at.7.17.42.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-01.at.7.12.19.AM.mov

MacOS: Desktop

Screen.Recording.2025-09-01.at.7.16.03.AM.mov

allroundexperts · 2025-09-01T02:31:06Z

+        hideBankAccountErrors();
+        return () => {
+            hideBankAccountErrors();
+        };


Even if you reload, the unmount function does get called. I think only one of these is necessary here.

No, that's not actually the case. I recorded a video with two cases where the error is not cleared if it is not cleared before entering the page, because useEffect on unmount is not called before reloading/changing the page URL.

-.-2025-09-01-.-10.14.30.mp4

OSBotify · 2025-09-08T02:56:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-09T03:27:19Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.3-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-09T18:19:05Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.5-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-09-09T21:21:03Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.8-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-10T22:58:57Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.8-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix:68830: clear error on BA confirmation step

7b95fd7

Eskalifer1 requested a review from a team as a code owner August 26, 2025 09:52

melvin-bot Bot assigned Eskalifer1 Aug 26, 2025

melvin-bot Bot requested review from allroundexperts and removed request for a team August 26, 2025 09:52

allroundexperts reviewed Sep 1, 2025

View reviewed changes

allroundexperts approved these changes Sep 8, 2025

View reviewed changes

melvin-bot Bot requested a review from carlosmiceli September 8, 2025 02:42

carlosmiceli approved these changes Sep 8, 2025

View reviewed changes

carlosmiceli merged commit 5dcacfe into Expensify:main Sep 8, 2025
23 of 25 checks passed

OSBotify mentioned this pull request Sep 9, 2025

Deploy Checklist: New Expensify 2025-09-09 #70157

Closed

83 tasks

melvin-bot Bot mentioned this pull request Sep 10, 2025

[Due for payment 2025-09-17] [$250] Wallet - The error Invalid IBAN still appears on the other bank country submission #68830

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix:68830: clear error on BA confirmation step#69228

fix:68830: clear error on BA confirmation step#69228
carlosmiceli merged 1 commit into
Expensify:mainfrom
Eskalifer1:fix/68830

Eskalifer1 commented Aug 26, 2025

Uh oh!

melvin-bot Bot commented Aug 26, 2025

Uh oh!

Eskalifer1 commented Aug 26, 2025

Uh oh!

allroundexperts commented Sep 1, 2025 •

edited

Loading

Uh oh!

allroundexperts Sep 1, 2025

Uh oh!

Eskalifer1 Sep 1, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 8, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Eskalifer1 commented Aug 26, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 26, 2025

Uh oh!

Eskalifer1 commented Aug 26, 2025

Uh oh!

allroundexperts commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 8, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 9, 2025

Uh oh!

OSBotify commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allroundexperts commented Sep 1, 2025 •

edited

Loading