fix: show not found page on change owner page for invalid account by daledah · Pull Request #68935 · Expensify/App

daledah · 2025-08-21T16:58:53Z

Explanation of Change

Fixed Issues

$ #68574
PROPOSAL: #68574 (comment)

Tests

Deeplink into workspaces/:workspaceID/change-owner/12345/failure
Verify that: Not found page is shown
Press back button
Verify that: User is navigated back previous page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Deeplink into workspaces/:workspaceID/change-owner/12345/failure
Verify that: Not found page is shown
Press back button
Verify that: User is navigated back to previous page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-08-22.at.00.20.56.mov

Android: mWeb Chrome

Screen.Recording.2025-08-22.at.00.30.19.mov

iOS: Native

Screen_Recording_2025-12-15_at_13.27.15.mov

iOS: mWeb Safari

Screen.Recording.2025-08-22.at.00.30.59.mov

MacOS: Chrome / Safari

Screen.Recording.2025-08-22.at.00.31.39.mov

MacOS: Desktop

Screen.Recording.2025-08-22.at.00.33.04.mov

melvin-bot · 2025-08-21T17:36:23Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2025-08-30T11:14:09Z

@hoangzinh Can you please continue review this PR

hoangzinh · 2025-08-31T09:45:22Z

sure @s77rt. I will start to review it today

hoangzinh · 2025-09-06T08:52:57Z

@daledah just in case you missed my comment here

daledah · 2025-09-09T04:21:24Z

@hoangzinh Sorry for delays, I'll update soon!

daledah · 2025-09-11T07:06:59Z

@hoangzinh I updated. Additional changes is to fix some bugs.

hoangzinh · 2025-09-25T22:55:14Z

Hi @daledah can you check my comment here https://github.com/Expensify/App/pull/68935/files#r2357347709? TY

hoangzinh · 2025-09-29T23:08:19Z

friendly bump @daledah

daledah · 2025-09-30T02:43:13Z

@hoangzinh Sorry for the delay. We'll call requestWorkspaceOwnerChange on page load here:

https://github.com/Expensify/App/pull/68935/files#diff-5fdd842a7eb9fa7bcb2aa46d29ee540569dfa8b81f16c60d66d3f10eacc71644R37-R39

So the call here is redundant now

https://github.com/Expensify/App/pull/68935/files#diff-77d95fb89b7456e2a952802101e5684a74ccebd2ac3a3ea7f162125be861a7bbL274

codecov · 2025-09-30T02:54:30Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...s/workspace/members/WorkspaceMemberDetailsPage.tsx	`0.00% <ø> (ø)`
...orkspace/members/WorkspaceOwnerChangeErrorPage.tsx	`0.00% <0.00%> (ø)`
...kspace/members/WorkspaceOwnerChangeSuccessPage.tsx	`0.00% <0.00%> (ø)`
...kspace/members/WorkspaceOwnerChangeWrapperPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

hoangzinh · 2025-09-30T10:03:47Z

@daledah I got it. However, what I would like to confirm is:

What is the issue with the current approach?
And with the new approach, I found an issue here

daledah · 2025-10-20T03:22:32Z

@hoangzinh Sorry for the delay.

The bug I mentioned here still exists so I keep current change here with some updates to prevent duplicated API calls.

There's one issue I've discovered with current implementation: When we deeplink using a nonexistent account, the flow works well, but after going back we get not found page:

Screen.Recording.2025-10-20.at.10.23.18.mov

To fix this we should reapply this commit. What do you think?

daledah · 2025-11-26T07:53:42Z

@hoangzinh sorry for the delay, here's the deeplink behaviour in prod:

Screen.Recording.2025-11-26.at.14.52.22.mov

trjExpensify

So niche for someone to do this 😅

hoangzinh · 2025-11-28T14:05:24Z

            Navigation.goBack();
            Navigation.navigate(ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID));
        }
+        InteractionManager.runAfterInteractions(() => {


We have ESLint failure here. We just marked using InteractionManager as deprecated for new RN version ref unless it's need to fix a critical bug.

Can we simply solve original issue and don't worry too much other edge cases until it's a real issue for customers? As long as it doesn't break the happy case then it LGTM.

da.mov

If don't use it, the page will be not found when closing RHP.

Should we move clearWorkspaceOwnerChangeFlow on page unmount to fix this issue? Or can we use a boolean state to fix this issue? We should avoid using InteractionManager

@hoangzinh i updated

hoangzinh · 2025-12-13T14:18:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-13.at.21.15.05.android.mov

Android: mWeb Chrome

Screen.Recording.2025-12-13.at.20.53.27.android.c.mov

iOS: HybridApp

Screen.Recording.2025-12-13.at.21.15.47.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-12-13.at.21.17.13.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-13.at.20.49.54.web.mov

hoangzinh · 2025-12-13T14:19:35Z

@daledah can you resolve conflicts and add recording for IOS?

daledah · 2025-12-15T07:17:20Z

@hoangzinh i resolved and added the ios record

hoangzinh

LGTM

srikarparsi · 2025-12-17T06:35:17Z

Looks like some checks are failing @daledah

daledah · 2025-12-17T09:10:26Z

@srikarparsi all looks good now

OSBotify · 2025-12-17T11:00:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-18T19:00:11Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T19:29:34Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:44:25Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.82-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T13:16:40Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.84-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-19T23:37:50Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.84-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

shubham1206agra · 2026-01-31T12:40:39Z

+            return;
+        }
+        requestWorkspaceOwnerChange(policyID, currentUserPersonalDetails.accountID, currentUserPersonalDetails.login ?? '');
+        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps


@daledah Can you please give a reason why we use only policyID as dependency here?

This effect is meant to call ⁨requestWorkspaceOwnerChange⁩ once on page mount, so I only use ⁨policyID⁩ as a dependency.

fix: show not found page on change owner page for invalid account

322ed4e

melvin-bot Bot assigned daledah Aug 21, 2025

daledah marked this pull request as ready for review August 21, 2025 17:36

daledah requested a review from a team as a code owner August 21, 2025 17:36

melvin-bot Bot requested review from s77rt and removed request for a team August 21, 2025 17:36

daledah mentioned this pull request Aug 21, 2025

[Due for payment 2025-12-26] [$250] When tapping back, not here page is seen #68574

Closed

8 tasks

s77rt suggested changes Aug 21, 2025

View reviewed changes

Comment thread src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx Outdated

Comment thread src/pages/workspace/members/WorkspaceOwnerChangeSuccessPage.tsx Outdated

Comment thread src/pages/workspace/members/useShouldShowChangeOwnerPage.ts Outdated

daledah added 2 commits September 10, 2025 23:34

Merge branch 'main' into fix/68574

b90ab99

fix: update logics

5e94cd2

daledah mentioned this pull request Sep 11, 2025

[$250] iOS&Android - App crashed when opening deeplink for changing workspace owner #70377

Closed

8 tasks

hoangzinh reviewed Sep 12, 2025

View reviewed changes

Comment thread src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx Outdated

Comment thread src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx Outdated

daledah added 2 commits September 17, 2025 15:34

Merge branch 'main' into fix/68574

845217d

fix: simplify should show page logic

23d2a41

Merge branch 'main' into fix/68574

4bc513d

daledah added 2 commits October 17, 2025 17:12

Merge branch 'main' into fix/68574

8c494c5

fix: prevent multiple API calls

8afd24e

fix: lint

71bf2ca

melvin-bot Bot requested review from trjExpensify and removed request for a team November 26, 2025 07:45

trjExpensify previously approved these changes Nov 26, 2025

View reviewed changes

hoangzinh reviewed Nov 28, 2025

View reviewed changes

resolve conflict

c69a36d

daledah dismissed trjExpensify’s stale review via c69a36d December 4, 2025 10:44

daledah added 2 commits December 4, 2025 17:45

resolve conlifct

6a80b17

fix lint and fix comments

145b2cc

hoangzinh reviewed Dec 8, 2025

View reviewed changes

Comment thread src/pages/workspace/members/WorkspaceOwnerChangeSuccessPage.tsx

Merge branch 'main' into fix/68574

a046f1d

resolve conflict

25c283b

hoangzinh approved these changes Dec 15, 2025

View reviewed changes

melvin-bot Bot requested a review from srikarparsi December 15, 2025 09:17

Merge branch 'main' into fix/68574

497a246

srikarparsi approved these changes Dec 17, 2025

View reviewed changes

srikarparsi merged commit d25d90d into Expensify:main Dec 17, 2025
30 checks passed

OSBotify mentioned this pull request Dec 18, 2025

Deploy Checklist: New Expensify 2025-12-18 #78018

Closed

shubham1206agra reviewed Jan 31, 2026

View reviewed changes

Uh oh!

Conversation

daledah commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s77rt commented Aug 30, 2025

Uh oh!

hoangzinh commented Aug 31, 2025

Uh oh!

hoangzinh commented Sep 6, 2025

Uh oh!

daledah commented Sep 9, 2025

Uh oh!

daledah commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

hoangzinh commented Sep 25, 2025

Uh oh!

hoangzinh commented Sep 29, 2025

Uh oh!

daledah commented Sep 30, 2025

Uh oh!

codecov Bot commented Sep 30, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hoangzinh commented Sep 30, 2025

Uh oh!

daledah commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledah commented Nov 26, 2025

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

daledah Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hoangzinh commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Dec 13, 2025

Uh oh!

daledah commented Dec 15, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

srikarparsi commented Dec 17, 2025

Uh oh!

daledah commented Dec 17, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 17, 2025

daledah commented Aug 21, 2025 •

edited

Loading

codecov Bot commented Sep 30, 2025 •

edited by github-actions Bot

Loading

daledah commented Oct 20, 2025 •

edited

Loading

hoangzinh commented Dec 13, 2025 •

edited

Loading