Skip to content

fix: Expense disappears from Reports when splitted while offline #68639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blimpich merged 6 commits into from
Sep 9, 2025
Merged

fix: Expense disappears from Reports when splitted while offline #68639

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac4e9cf
fix: Expense disappears from Reports when splitted while offline
nkdengineer Aug 18, 2025
d2c2240
Merge branch 'main' into fix/68350
nkdengineer Aug 18, 2025
36f5309
Merge branch 'main' into fix/68350
nkdengineer Aug 20, 2025
45c855a
Merge branch 'main' into fix/68350
nkdengineer Sep 4, 2025
a5410e3
Merge branch 'main' into fix/68350
nkdengineer Sep 8, 2025
ca1a643
fix getCurrentSearchQueryJSON issue
nkdengineer Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/libs/SearchQueryUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {getCardDescription} from './CardUtils';
import {convertToBackendAmount, convertToFrontendAmountAsInteger} from './CurrencyUtils';
import Log from './Log';
import {validateAmount} from './MoneyRequestUtils';
import {getPreservedNavigatorState} from './Navigation/AppNavigator/createSplitNavigator/usePreserveNavigatorState';
import navigationRef from './Navigation/navigationRef';
import type {SearchFullscreenNavigatorParamList} from './Navigation/types';
import {getPersonalDetailByEmail} from './PersonalDetailsUtils';
Expand Down Expand Up @@ -1017,13 +1018,14 @@ function getQueryWithUpdatedValues(query: string) {

function getCurrentSearchQueryJSON() {
const rootState = navigationRef.getRootState();
const lastPolicyRoute = rootState?.routes?.findLast((route) => route.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR || route.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR);
const lastSearchNavigator = rootState?.routes?.findLast((route) => route.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR);

if (!lastPolicyRoute) {
const lastSearchNavigatorState = lastSearchNavigator && lastSearchNavigator.key ? getPreservedNavigatorState(lastSearchNavigator?.key) : undefined;
if (!lastSearchNavigatorState) {
return;
}

const lastSearchRoute = lastPolicyRoute.state?.routes.findLast((route) => route.name === SCREENS.SEARCH.ROOT);
const lastSearchRoute = lastSearchNavigatorState.routes.findLast((route) => route.name === SCREENS.SEARCH.ROOT);
if (!lastSearchRoute || !lastSearchRoute.params) {
return;
}
Expand Down
Loading