Fix: Missing Split indicator next to Amount when card expense is split by ryntgh · Pull Request #67916 · Expensify/App

ryntgh · 2025-08-05T13:19:12Z

Explanation of Change

Fixed Issues

$ #66900
PROPOSAL: #66900 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition:

User has added Wells Fargo card feed and assigned themselves Plaid Credit Card 3333.
There is at least one imported card transaction.

Go to workspace chat.
Submit an expense to the workspace chat.
Open the expense preview and then transaction thread.
Click More > Split > Save.
Open the split expense.
Note that it shows the Split indicator next to Amount.
Open card transaction.
Click More > Split > Save.
Open the split card transaction.
Verify it shows the Split indicator next to Amount.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

melvin-bot · 2025-08-05T13:59:22Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

suneox · 2025-08-13T16:25:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-08-14.at.01.43.13.mp4

Android: mWeb Chrome

Screen.Recording.2025-08-14.at.01.41.16.mp4

iOS: HybridApp

Screen.Recording.2025-08-14.at.01.40.58.mp4

iOS: mWeb Safari

Screen.Recording.2025-08-14.at.01.44.06.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-08-14.at.01.35.17.mp4

MacOS: Desktop

Screen.Recording.2025-08-14.at.01.36.59.mp4

luacmartins · 2025-08-13T19:24:34Z

        if (formattedOriginalAmount) {
            amountDescription += ` ${CONST.DOT_SEPARATOR} ${translate('iou.original')} ${formattedOriginalAmount}`;
        }
+        if (getOriginalTransactionWithSplitInfo(transaction).isExpenseSplit) {


@ryntgh I'm sorry, but we should avoid using getOriginalTransactionWithSplitInfo since it uses allTransactions which is retrieved via Onyx.connect and we're deprecating uses of Onyx.connect, so this PR will make deprecating it harder. Can we instead subscribe to the originalTransactionID via useOnyx and retrieving the data we need that way?

Sure! I’ve added a new helper function that replicates the functionality of getOriginalTransactionWithSplitInfo to retrieve the isExpenseSplit value
Please let me know your thoughts on this approach

OSBotify · 2025-08-15T19:46:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-08-18T15:52:32Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.96-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-08-19T18:58:27Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.96-2 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-08-19T20:12:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.96-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jjcoffee · 2026-03-16T08:47:16Z

    return transactions?.length === 1 && hasPendingUI(transactions?.at(0), getTransactionViolations(transactions?.at(0), allTransactionViolations));
 }

+function isExpenseSplit(transaction: OnyxEntry<Transaction>, originalTransaction: OnyxEntry<Transaction>): boolean {


Coming from #73732, we missed cases here where there is only one split remaining, in which case it shouldn't be visually displayed as if it were a split expense.

Fix: Missing Split indicator next to Amount when card expense is split

db07a8d

ryntgh marked this pull request as ready for review August 5, 2025 13:59

ryntgh requested a review from a team as a code owner August 5, 2025 13:59

melvin-bot Bot requested review from suneox and removed request for a team August 5, 2025 13:59

ryntgh mentioned this pull request Aug 5, 2025

[Due for payment 2025-08-26] [$250] Expense - Missing Split indicator next to Amount when card expense is split #66900

Closed

8 tasks

Merge branch 'main' into issue-66900

5451edb

luacmartins assigned ryntgh Aug 13, 2025

suneox approved these changes Aug 13, 2025

View reviewed changes

melvin-bot Bot requested a review from luacmartins August 13, 2025 18:48

luacmartins reviewed Aug 13, 2025

View reviewed changes

Fix: Missing Split indicator next to Amount when card expense is split

07ff33b

luacmartins requested changes Aug 14, 2025

View reviewed changes

Comment thread src/components/ReportActionItem/MoneyRequestView.tsx Outdated

ryntgh added 2 commits August 16, 2025 01:51

Merge branch 'main' into issue-66900

ec71970

Fix: Missing Split indicator next to Amount when card expense is split

3f2cff1

luacmartins approved these changes Aug 15, 2025

View reviewed changes

luacmartins merged commit 7da0c45 into Expensify:main Aug 15, 2025
24 checks passed

OSBotify mentioned this pull request Aug 18, 2025

Deploy Checklist: New Expensify 2025-08-18 #68664

Closed

47 tasks

jjcoffee reviewed Mar 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Missing Split indicator next to Amount when card expense is split#67916

Fix: Missing Split indicator next to Amount when card expense is split#67916
luacmartins merged 5 commits into
Expensify:mainfrom
ryntgh:issue-66900

ryntgh commented Aug 5, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Aug 5, 2025

Uh oh!

suneox commented Aug 13, 2025 •

edited

Loading

Uh oh!

luacmartins Aug 13, 2025

Uh oh!

ryntgh Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Aug 15, 2025

Uh oh!

OSBotify commented Aug 18, 2025

Uh oh!

OSBotify commented Aug 19, 2025

Uh oh!

OSBotify commented Aug 19, 2025

Uh oh!

jjcoffee Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ryntgh commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 5, 2025

Uh oh!

suneox commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

ryntgh Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Aug 15, 2025

Uh oh!

OSBotify commented Aug 18, 2025

Uh oh!

OSBotify commented Aug 19, 2025

Uh oh!

OSBotify commented Aug 19, 2025

Uh oh!

jjcoffee Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ryntgh commented Aug 5, 2025 •

edited

Loading

suneox commented Aug 13, 2025 •

edited

Loading