Skip to content

[CP Staging] Revert "improve ReportActionItem performance" - #67170

Merged
mountiny merged 1 commit into
mainfrom
revert-66927-feat/66148-improve-ReportActionItem-performance
Jul 25, 2025
Merged

[CP Staging] Revert "improve ReportActionItem performance"#67170
mountiny merged 1 commit into
mainfrom
revert-66927-feat/66148-improve-ReportActionItem-performance

Conversation

@mountiny

@mountiny mountiny commented Jul 25, 2025 •
edited by cristipaval
Loading

Copy link
Copy Markdown
Contributor

Reverts #66927

Straight revert

Fixes #67148
Fixes #67153

Test steps from the linked issue

@mountiny
mountiny requested a review from NikkiWines July 25, 2025 13:40
@mountiny mountiny self-assigned this Jul 25, 2025
@mountiny
mountiny requested a review from a team as a code owner July 25, 2025 13:40
@melvin-bot
melvin-bot Bot requested a review from AndrewGable July 25, 2025 13:41
@melvin-bot

melvin-bot Bot commented Jul 25, 2025

Copy link
Copy Markdown

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 25, 2025 13:41
@mountiny mountiny changed the title Revert "improve ReportActionItem performance" [CP Staging] Revert "improve ReportActionItem performance" Jul 25, 2025
NikkiWines
NikkiWines approved these changes Jul 25, 2025
View reviewed changes

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mountiny
mountiny merged commit 262117e into main Jul 25, 2025
20 of 25 checks passed
@mountiny
mountiny deleted the revert-66927-feat/66148-improve-ReportActionItem-performance branch July 25, 2025 13:56
@melvin-bot

melvin-bot Bot commented Jul 25, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Jul 25, 2025
@mountiny

mountiny commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Jul 25, 2025
@mountiny @OSBotify
Merge pull request #67170 from Expensify/revert-66927-feat/66148-impr…
bacb3fe 
…ove-ReportActionItem-performance

[CP Staging] Revert "improve ReportActionItem performance"

(cherry picked from commit 262117e)

(cherry-picked to staging by cristipaval)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 25, 2025
@github-actions github-actions Bot mentioned this pull request Jul 25, 2025
Closed
51 tasks
@OSBotify

OSBotify commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.1.86-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@cristipaval cristipaval mentioned this pull request Jul 28, 2025
Closed
8 tasks
@grgia grgia mentioned this pull request Jul 28, 2025
Closed
8 tasks
@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.1.86-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.1.87-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.1.87-14 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes
@AndrewGable AndrewGable Awaiting requested review from AndrewGable

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[$250] Thread - Reacted emoji to parent message is not displayed in thread Thread - Parent message does not enter edit mode in thread

3 participants

@mountiny @OSBotify @NikkiWines