Skip to content

fix: Workspace - Selected users to invite turn deselected when refresh Add message page. #66772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuckdries merged 6 commits into from
Jul 28, 2025
Merged

fix: Workspace - Selected users to invite turn deselected when refresh Add message page. #66772

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58d43c3
fix: Workspace - Selected users to invite turn deselected when refres…
Krishna2323 Jul 20, 2025
cbbdb33
fix empty screen when options are loading after reset.
Krishna2323 Jul 20, 2025
18ba38a
minor update.
Krishna2323 Jul 20, 2025
e04a4f6
Merge branch 'Expensify:main' into krishna2323/issue/66202
Krishna2323 Jul 22, 2025
b67e687
minro update.
Krishna2323 Jul 23, 2025
af4d93c
remove useEffect.
Krishna2323 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/components/OptionListContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,13 @@ const useOptionsList = (options?: {shouldInitialize: boolean}) => {
const [isLoadingApp] = useOnyx(ONYXKEYS.IS_LOADING_APP, {canBeMissing: false});
const [internalOptions, setInternalOptions] = useState<OptionList>(optionsList);
const prevOptions = useRef<OptionList>(null);
const [areInternalOptionsInitialized, setAreInternalOptionsInitialized] = useState(false);

@QichenZhu QichenZhu Jul 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why did you choose to use state instead of ref as you suggested earlier?

@Krishna2323 Krishna2323 Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I faced an edge case where the list was not currently re-rendered with the correct value areInternalOptionsInitialized ref value.

@QichenZhu QichenZhu Jul 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind sharing how to trigger that edge case?


useEffect(() => {
if (!prevOptions.current) {

@QichenZhu QichenZhu Jul 22, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the new part isn't related to the rest of the effect and has different dependencies. Why not add a separate effect for it?

@Krishna2323 Krishna2323 Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, updated.

prevOptions.current = optionsList;
setInternalOptions(optionsList);
setAreInternalOptionsInitialized(areOptionsInitialized);
return;
}
/**
Expand All @@ -283,7 +285,8 @@ const useOptionsList = (options?: {shouldInitialize: boolean}) => {
return;
}
setInternalOptions(optionsList);

@QichenZhu QichenZhu Jul 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setInternalOptions(optionsList);
setInternalOptions(optionsList);
setAreInternalOptionsInitialized(areOptionsInitialized);

Same suggestion for the other setInternalOptions().

}, [optionsList]);
setAreInternalOptionsInitialized(areOptionsInitialized);
}, [optionsList, areOptionsInitialized]);

@QichenZhu QichenZhu Jul 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed an unused dependency areOptionsInitialized. Is that intentional?

Please ignore this comment for now.


useEffect(() => {
if (!shouldInitialize || areOptionsInitialized || isLoadingApp) {
Expand All @@ -293,14 +296,19 @@ const useOptionsList = (options?: {shouldInitialize: boolean}) => {
initializeOptions();
}, [shouldInitialize, initializeOptions, areOptionsInitialized, isLoadingApp]);

const resetInternalOptions = useCallback(() => {
setAreInternalOptionsInitialized(false);
resetOptions();
}, [resetOptions]);

return useMemo(
() => ({
initializeOptions,
options: internalOptions,
areOptionsInitialized,
resetOptions,
areOptionsInitialized: areInternalOptionsInitialized,
resetOptions: resetInternalOptions,
}),
[initializeOptions, internalOptions, areOptionsInitialized, resetOptions],
[initializeOptions, internalOptions, resetInternalOptions, areInternalOptionsInitialized],
);
};

Expand Down
Loading