-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Jakubkalinski0/show report total and report status in the new report preview component #66260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 43 commits into
Expensify:main
from
software-mansion-labs:jakubkalinski0/Show-report-total-and-report-status-in-the-new-report-preview-component
Jul 25, 2025
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
8300b62
Show report total and report status in the new report preview component
jakubkalinski0 461eb5c
Small fixes to the comments
jakubkalinski0 f869b7f
Small code cleanup in the MoneyRequestReportPreviewContent.tsx component
jakubkalinski0 fc314ca
Updating code style after running prettier
jakubkalinski0 ebc4817
Code adjusted to PR comments
jakubkalinski0 0aaa2b9
Commit after prettier changes
jakubkalinski0 6b4af2a
Fixing typecheck in languages
jakubkalinski0 399c574
Small style cleanup
jakubkalinski0 2edf3e6
Update src/libs/ReportUtils.ts
jakubkalinski0 8e8c3d3
Resolving comments pointed out by @Kicu in review
jakubkalinski0 45109a1
Merge branch 'jakubkalinski0/Show-report-total-and-report-status-in-t…
jakubkalinski0 12fd5aa
Removing testID from subheader
jakubkalinski0 19649f6
Removed min-height from the report title
jakubkalinski0 38cfcd4
Changes after running prettier
jakubkalinski0 dfd6f8d
Added skeleton for the subheader
jakubkalinski0 fc5ffa2
Changed the localization of approve/paid icon to the subheader
jakubkalinski0 96674d5
Added the visible 'View' button during loading
jakubkalinski0 e7a8682
Small code styling changes
jakubkalinski0 509f3c2
Commit after running prettier
jakubkalinski0 9e70810
Small adjustments to the icons
jakubkalinski0 e14c1f7
Fixed gap when the icon is missing
jakubkalinski0 92e710b
Centered icons and placed title, subheader and arrow buttons in one b…
jakubkalinski0 ba94768
Improved the performence of status translation by limiting report gua…
jakubkalinski0 04af12f
Commit after prettier run
jakubkalinski0 54d11c5
Added missing stateNum to CONST
jakubkalinski0 8c6292a
Added proper checks for all the state/status pairs in the getReportSt…
jakubkalinski0 ce500b5
Commit afted prettier run in ReportUtils.ts
jakubkalinski0 2f75a6d
Removed total from the bottom button
jakubkalinski0 63e99cb
Added unit tests for getReportStatusTranslation function
jakubkalinski0 8af16d5
Commit after prettier run in ReportUtilsTest.ts
jakubkalinski0 83072bb
Added AUTOREIMBURSED to the spellcheck
jakubkalinski0 7ad157c
Removed workaround for icon padding at the end of report preview name
jakubkalinski0 61d2a65
Fixed subheader alignment on mobile
jakubkalinski0 c974c03
Fixed wrapping on overflowing report preview name
jakubkalinski0 ba7a270
Added flexshrink1 to another container wrapping title
jakubkalinski0 bdda448
Small changes for better code quality and fixed empty space before st…
jakubkalinski0 7c1f2ab
Prettier run
jakubkalinski0 55b6110
Fixed typo
jakubkalinski0 6c2d83b
Properly fixed typo in margin
jakubkalinski0 173f4de
Improved efficiency of getReportStatusTranslation as proposed by @mou…
jakubkalinski0 198c9ca
Adjusted the tests to the changes in getReportStatusTranslation
jakubkalinski0 b261861
Fixed getReportStatusTranslation function to properly hangle undefine…
jakubkalinski0 a61d1d7
Added comment to clarify icon occurrence
jakubkalinski0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 56 additions & 78 deletions
134
...omponents/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.