Skip to content

Fix: margin for Save button on Password page#6600

Merged
stitesExpensify merged 1 commit into
Expensify:mainfrom
parasharrajat:password-page
Dec 6, 2021
Merged

Fix: margin for Save button on Password page#6600
stitesExpensify merged 1 commit into
Expensify:mainfrom
parasharrajat:password-page

Conversation

@parasharrajat

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #6497

Tests | QA Steps

  1. Open the Change Password page from the Settings menu page.
  2. Observe the gap around the Save Button.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop | Mobile Web | iOS | Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner December 6, 2021 19:39
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team December 6, 2021 19:39
@stitesExpensify stitesExpensify merged commit 339c19f into Expensify:main Dec 6, 2021
@OSBotify

OSBotify commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the password-page branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants